mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> internal only doc [go/moving-a11y-guidelines](http://goto.google.com/moving-a11y-guidelines) fixes https://github.com/flutter/flutter/issues/32057 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
249 lines
8.3 KiB
Dart
249 lines
8.3 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter/src/foundation/_features.dart';
|
|
import 'package:flutter/src/widgets/_accessibility_evaluations.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'widgets_app_tester.dart';
|
|
|
|
void main() {
|
|
group('MinimumTapTargetEvaluation', () {
|
|
late final Set<String> originalFeatureFlags;
|
|
setUpAll(() {
|
|
originalFeatureFlags = {...debugEnabledFeatureFlags};
|
|
debugEnabledFeatureFlags.add('accessibility_evaluations');
|
|
});
|
|
tearDownAll(() {
|
|
debugEnabledFeatureFlags.clear();
|
|
debugEnabledFeatureFlags.addAll(originalFeatureFlags);
|
|
});
|
|
|
|
const evaluation = MinimumTapTargetEvaluation(size: Size(48.0, 48.0), link: 'link');
|
|
|
|
testWidgets('passes for valid targets', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 48.0,
|
|
height: 48.0,
|
|
child: Semantics(label: 'button', onTap: () {}),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult result = await evaluation.evaluate(tester.binding);
|
|
expect(result.violations, isEmpty);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('fails for small targets', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
TestWidgetsApp(
|
|
home: Center(
|
|
child: SizedBox(
|
|
width: 40.0,
|
|
height: 40.0,
|
|
child: Semantics(label: 'button', onTap: () {}),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult result = await evaluation.evaluate(tester.binding);
|
|
expect(result.violations, hasLength(1));
|
|
expect(
|
|
result.violations.first.reason,
|
|
contains('expected tap target size of at least Size(48.0, 48.0)'),
|
|
);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('skips hidden nodes', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 40.0,
|
|
height: 40.0,
|
|
child: Semantics(label: 'button', onTap: () {}, hidden: true),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult result = await evaluation.evaluate(tester.binding);
|
|
expect(result.violations, isEmpty);
|
|
handle.dispose();
|
|
});
|
|
});
|
|
|
|
group('LabeledTapTargetEvaluation', () {
|
|
late final Set<String> originalFeatureFlags;
|
|
setUpAll(() {
|
|
originalFeatureFlags = {...debugEnabledFeatureFlags};
|
|
debugEnabledFeatureFlags.add('accessibility_evaluations');
|
|
});
|
|
tearDownAll(() {
|
|
debugEnabledFeatureFlags.clear();
|
|
debugEnabledFeatureFlags.addAll(originalFeatureFlags);
|
|
});
|
|
const evaluation = LabeledTapTargetEvaluation();
|
|
|
|
testWidgets('passes for labeled targets', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 48.0,
|
|
height: 48.0,
|
|
child: Semantics(label: 'button', onTap: () {}),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult result = await evaluation.evaluate(tester.binding);
|
|
expect(result.violations, isEmpty);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('fails for unlabeled targets', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
TestWidgetsApp(
|
|
home: SizedBox(width: 48.0, height: 48.0, child: Semantics(onTap: () {})),
|
|
),
|
|
);
|
|
final EvaluationResult result = await evaluation.evaluate(tester.binding);
|
|
expect(result.violations, hasLength(1));
|
|
expect(
|
|
result.violations.first.reason,
|
|
contains('expected tappable node to have semantic label'),
|
|
);
|
|
handle.dispose();
|
|
});
|
|
});
|
|
|
|
group('MinimumTextContrastEvaluation', () {
|
|
late final Set<String> originalFeatureFlags;
|
|
setUpAll(() {
|
|
originalFeatureFlags = {...debugEnabledFeatureFlags};
|
|
debugEnabledFeatureFlags.add('accessibility_evaluations');
|
|
});
|
|
tearDownAll(() {
|
|
debugEnabledFeatureFlags.clear();
|
|
debugEnabledFeatureFlags.addAll(originalFeatureFlags);
|
|
});
|
|
const evaluation = MinimumTextContrastEvaluation();
|
|
|
|
testWidgets('passes for high contrast', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
const TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 100,
|
|
height: 100,
|
|
child: ColoredBox(
|
|
color: Color(0xFFFFFFFF),
|
|
child: Center(
|
|
child: Text('test', style: TextStyle(color: Color(0xFF000000), fontSize: 14)),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult? result = await tester.runAsync<EvaluationResult>(() async {
|
|
return await evaluation.evaluate(tester.binding);
|
|
});
|
|
expect(result!.violations, isEmpty);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('fails for low contrast', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
const TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 100,
|
|
height: 100,
|
|
child: ColoredBox(
|
|
color: Color(0xFFFFFFFF),
|
|
child: Center(
|
|
child: Text('test', style: TextStyle(color: Color(0xFFEEEEEE), fontSize: 14)),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult? result = await tester.runAsync<EvaluationResult>(() async {
|
|
return await evaluation.evaluate(tester.binding);
|
|
});
|
|
expect(result!.violations, hasLength(1));
|
|
expect(result.violations.first.reason, contains('Expected contrast ratio of at least 4.5'));
|
|
handle.dispose();
|
|
});
|
|
});
|
|
|
|
group('MinimumTextContrastEvaluationAAA', () {
|
|
late final Set<String> originalFeatureFlags;
|
|
setUpAll(() {
|
|
originalFeatureFlags = {...debugEnabledFeatureFlags};
|
|
debugEnabledFeatureFlags.add('accessibility_evaluations');
|
|
});
|
|
tearDownAll(() {
|
|
debugEnabledFeatureFlags.clear();
|
|
debugEnabledFeatureFlags.addAll(originalFeatureFlags);
|
|
});
|
|
const evaluation = MinimumTextContrastEvaluationAAA();
|
|
|
|
testWidgets('passes for very high contrast', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
const TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 100,
|
|
height: 100,
|
|
child: ColoredBox(
|
|
color: Color(0xFFFFFFFF),
|
|
child: Center(
|
|
child: Text('test', style: TextStyle(color: Color(0xFF000000), fontSize: 14)),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult? result = await tester.runAsync<EvaluationResult>(() async {
|
|
return await evaluation.evaluate(tester.binding);
|
|
});
|
|
expect(result!.violations, isEmpty);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('fails for normal contrast (AA but not AAA)', (WidgetTester tester) async {
|
|
// Gray on white: 0xFF777777 on 0xFFFFFFFF
|
|
// Contrast is ~4.5:1 which passes AA but fails AAA (needs 7:1)
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await tester.pumpWidget(
|
|
const TestWidgetsApp(
|
|
home: SizedBox(
|
|
width: 100,
|
|
height: 100,
|
|
child: ColoredBox(
|
|
color: Color(0xFFFFFFFF),
|
|
child: Center(
|
|
child: Text('test', style: TextStyle(color: Color(0xFF767676), fontSize: 14)),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final EvaluationResult? result = await tester.runAsync<EvaluationResult>(() async {
|
|
return await evaluation.evaluate(tester.binding);
|
|
});
|
|
expect(result!.violations, isNotEmpty);
|
|
expect(result.violations.first.reason, contains('Expected contrast ratio of at least 7'));
|
|
handle.dispose();
|
|
});
|
|
});
|
|
}
|