mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Relands https://github.com/flutter/flutter/pull/179647 There were only two failing tests (there were also two bringup failures, the `mac_arm64_mokey` versions of these) https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_mokey%20run_release_test/3866/overview https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_mokey%20run_debug_test_android/5454/overview They failed with the same logs ``` Task result: { "success": false, "reason": "Task failed: flutter run had unexpected output on standard error." } ``` The stderr in question: ``` [2025-12-15 14:06:56.311794] [STDOUT] run:stderr: - integration_test requires Android NDK 28.2.13676358 [2025-12-15 14:06:56.311989] [STDOUT] run:stderr: Fix this issue by using the highest Android NDK version (they are backward compatible). [2025-12-15 14:06:56.312019] [STDOUT] run:stderr: Add the following to /opt/s/w/ir/x/w/rc/tmpr6kj09d_/flutter sdk/dev/integration_tests/ui/android/app/build.gradle: [2025-12-15 14:06:56.312074] [STDOUT] run:stderr: [2025-12-15 14:06:56.312092] [STDOUT] run:stderr: android { [2025-12-15 14:06:56.312144] [STDOUT] run:stderr: ndkVersion = "28.2.13676358" [2025-12-15 14:06:56.312162] [STDOUT] run:stderr: ... [2025-12-15 14:06:56.312205] [STDOUT] run:stderr: } ``` We can just set the ndk version to `flutter.ndkVersion`, which is this value. It's also what is set in the templates, so it isn't a hack that doesn't represent a real flutter app. Verified the tests pass now with ``` ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t run_release_test ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t run_debug_test_android ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
97 lines
2.9 KiB
Dart
97 lines
2.9 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:flutter_devicelab/framework/runner.dart';
|
|
import 'package:flutter_devicelab/framework/task_result.dart';
|
|
|
|
import '../common.dart';
|
|
|
|
void main() {
|
|
final isolateParams = <String, String>{'runFlutterConfig': 'false', 'timeoutInMinutes': '1'};
|
|
|
|
test('runs build and test when no args are passed', () async {
|
|
final TaskResult result = await runTask(
|
|
'smoke_test_build_test',
|
|
deviceId: 'FAKE_SUCCESS',
|
|
isolateParams: isolateParams,
|
|
);
|
|
expect(result.data!['benchmark'], 'data');
|
|
});
|
|
|
|
test('runs build only when build arg is given', () async {
|
|
final TaskResult result = await runTask(
|
|
'smoke_test_build_test',
|
|
taskArgs: <String>['--build'],
|
|
deviceId: 'FAKE_SUCCESS',
|
|
isolateParams: isolateParams,
|
|
);
|
|
expect(result.message, 'No tests run');
|
|
});
|
|
|
|
test('runs test only when test arg is given', () async {
|
|
final TaskResult result = await runTask(
|
|
'smoke_test_build_test',
|
|
taskArgs: <String>['--test'],
|
|
deviceId: 'FAKE_SUCCESS',
|
|
isolateParams: isolateParams,
|
|
);
|
|
expect(result.data!['benchmark'], 'data');
|
|
});
|
|
|
|
test('sets environment', () async {
|
|
final capturedPrintLines = StringBuffer();
|
|
await runZoned<Future<void>>(
|
|
() async {
|
|
await runTask(
|
|
'smoke_test_build_test',
|
|
taskArgs: <String>['--test'],
|
|
deviceId: 'FAKE_SUCCESS',
|
|
isolateParams: isolateParams,
|
|
);
|
|
},
|
|
zoneSpecification: ZoneSpecification(
|
|
// Intercept printing from the task.
|
|
print: (Zone self, ZoneDelegate parent, Zone zone, String line) async {
|
|
capturedPrintLines.writeln(line);
|
|
},
|
|
),
|
|
);
|
|
final capturedPrint = capturedPrintLines.toString();
|
|
expect(
|
|
capturedPrint,
|
|
allOf(
|
|
contains('with environment {'),
|
|
contains('FLUTTER_DEVICELAB_DEVICEID: FAKE_SUCCESS'),
|
|
contains('BOT: true'),
|
|
),
|
|
);
|
|
expect(capturedPrint, contains('Process terminated with exit code 0.'));
|
|
});
|
|
|
|
test('throws exception when build and test arg are given', () async {
|
|
final TaskResult result = await runTask(
|
|
'smoke_test_build_test',
|
|
taskArgs: <String>['--build', '--test'],
|
|
deviceId: 'FAKE_SUCCESS',
|
|
isolateParams: isolateParams,
|
|
);
|
|
expect(
|
|
result.message,
|
|
'Task failed: Exception: Both build and test should not be passed. Pass only one.',
|
|
);
|
|
});
|
|
|
|
test('copies artifacts when build and application binary arg are given', () async {
|
|
final TaskResult result = await runTask(
|
|
'smoke_test_build_test',
|
|
taskArgs: <String>['--build', '--application-binary-path=test'],
|
|
deviceId: 'FAKE_SUCCESS',
|
|
isolateParams: isolateParams,
|
|
);
|
|
expect(result.message, 'No tests run');
|
|
});
|
|
}
|