mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Bumps the Dart version to 3.8 across the repo (excluding engine/src/flutter/third_party) and applies formatting updates from Dart 3.8. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
117 lines
3.8 KiB
Dart
117 lines
3.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:convert';
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'multi_view_testing.dart';
|
|
|
|
void main() {
|
|
testWidgets('Detects tap targets in all views', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await pumpViews(
|
|
tester: tester,
|
|
viewContents: <Widget>[
|
|
SizedBox(width: 47.0, height: 47.0, child: GestureDetector(onTap: () {})),
|
|
SizedBox(width: 46.0, height: 46.0, child: GestureDetector(onTap: () {})),
|
|
],
|
|
);
|
|
final Evaluation result = await androidTapTargetGuideline.evaluate(tester);
|
|
expect(result.passed, false);
|
|
expect(
|
|
result.reason,
|
|
contains('expected tap target size of at least Size(48.0, 48.0), but found Size(47.0, 47.0)'),
|
|
);
|
|
expect(
|
|
result.reason,
|
|
contains('expected tap target size of at least Size(48.0, 48.0), but found Size(46.0, 46.0)'),
|
|
);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('Detects labeled tap targets in all views', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await pumpViews(
|
|
tester: tester,
|
|
viewContents: <Widget>[
|
|
SizedBox(width: 47.0, height: 47.0, child: GestureDetector(onTap: () {})),
|
|
SizedBox(width: 46.0, height: 46.0, child: GestureDetector(onTap: () {})),
|
|
],
|
|
);
|
|
final Evaluation result = await labeledTapTargetGuideline.evaluate(tester);
|
|
expect(result.passed, false);
|
|
final List<String> lines = const LineSplitter().convert(result.reason!);
|
|
expect(lines, hasLength(2));
|
|
expect(lines.first, startsWith('SemanticsNode#1(Rect.fromLTRB(0.0, 0.0, 47.0, 47.0)'));
|
|
expect(
|
|
lines.first,
|
|
endsWith('expected tappable node to have semantic label, but none was found.'),
|
|
);
|
|
expect(lines.last, startsWith('SemanticsNode#2(Rect.fromLTRB(0.0, 0.0, 46.0, 46.0)'));
|
|
expect(
|
|
lines.last,
|
|
endsWith('expected tappable node to have semantic label, but none was found.'),
|
|
);
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('Detects contrast problems in all views', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
await pumpViews(
|
|
tester: tester,
|
|
viewContents: <Widget>[
|
|
Container(
|
|
width: 200.0,
|
|
height: 200.0,
|
|
color: Colors.yellow,
|
|
child: const Text(
|
|
'this is a test',
|
|
style: TextStyle(fontSize: 14.0, color: Colors.yellowAccent),
|
|
),
|
|
),
|
|
Container(
|
|
width: 200.0,
|
|
height: 200.0,
|
|
color: Colors.yellow,
|
|
child: const Text(
|
|
'this is a test',
|
|
style: TextStyle(fontSize: 25.0, color: Colors.yellowAccent),
|
|
),
|
|
),
|
|
],
|
|
);
|
|
final Evaluation result = await textContrastGuideline.evaluate(tester);
|
|
expect(result.passed, false);
|
|
expect(
|
|
result.reason,
|
|
contains('Expected contrast ratio of at least 4.5 but found 0.88 for a font size of 14.0.'),
|
|
);
|
|
expect(
|
|
result.reason,
|
|
contains('Expected contrast ratio of at least 3.0 but found 0.88 for a font size of 25.0.'),
|
|
);
|
|
handle.dispose();
|
|
});
|
|
}
|
|
|
|
Future<void> pumpViews({required WidgetTester tester, required List<Widget> viewContents}) {
|
|
final List<Widget> views = <Widget>[
|
|
for (int i = 0; i < viewContents.length; i++)
|
|
View(
|
|
view: FakeView(tester.view, viewId: i + 100),
|
|
child: Center(child: viewContents[i]),
|
|
),
|
|
];
|
|
|
|
return tester.pumpWidget(
|
|
wrapWithView: false,
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: ViewCollection(views: views),
|
|
),
|
|
);
|
|
}
|