mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Bumps the Dart version to 3.8 across the repo (excluding engine/src/flutter/third_party) and applies formatting updates from Dart 3.8. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
109 lines
3.5 KiB
Dart
109 lines
3.5 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
|
|
|
|
void main() {
|
|
testWidgets('ErrorWidget displays actual error when throwing during build', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final Key container = UniqueKey();
|
|
const String errorText = 'Oh no, there was a crash!!1';
|
|
|
|
await tester.pumpWidget(
|
|
Container(
|
|
key: container,
|
|
color: Colors.red,
|
|
padding: const EdgeInsets.all(10),
|
|
child: Builder(
|
|
builder: (BuildContext context) {
|
|
throw UnsupportedError(errorText);
|
|
},
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(
|
|
tester.takeException(),
|
|
isA<UnsupportedError>().having(
|
|
(UnsupportedError error) => error.message,
|
|
'message',
|
|
contains(errorText),
|
|
),
|
|
);
|
|
|
|
final ErrorWidget errorWidget = tester.widget(find.byType(ErrorWidget));
|
|
expect(errorWidget.message, contains(errorText));
|
|
|
|
// Failure in one widget shouldn't ripple through the entire tree and effect
|
|
// ancestors. Those should still be in the tree.
|
|
expect(find.byKey(container), findsOneWidget);
|
|
});
|
|
|
|
testWidgets(
|
|
'when constructing an ErrorWidget due to a build failure throws an error, fail gracefully',
|
|
experimentalLeakTesting: LeakTesting.settings
|
|
.withIgnoredAll(), // leaking by design because of exception
|
|
(WidgetTester tester) async {
|
|
final Key container = UniqueKey();
|
|
await tester.pumpWidget(
|
|
Container(
|
|
key: container,
|
|
color: Colors.red,
|
|
padding: const EdgeInsets.all(10),
|
|
// This widget throws during build, which causes the construction of an
|
|
// ErrorWidget with the build error. However, during construction of
|
|
// that ErrorWidget, another error is thrown.
|
|
child: const MyDoubleThrowingWidget(),
|
|
),
|
|
);
|
|
|
|
expect(
|
|
tester.takeException(),
|
|
isA<UnsupportedError>().having(
|
|
(UnsupportedError error) => error.message,
|
|
'message',
|
|
contains(MyThrowingElement.debugFillPropertiesErrorMessage),
|
|
),
|
|
);
|
|
|
|
final ErrorWidget errorWidget = tester.widget(find.byType(ErrorWidget));
|
|
expect(errorWidget.message, contains(MyThrowingElement.debugFillPropertiesErrorMessage));
|
|
|
|
// Failure in one widget shouldn't ripple through the entire tree and effect
|
|
// ancestors. Those should still be in the tree.
|
|
expect(find.byKey(container), findsOneWidget);
|
|
},
|
|
);
|
|
}
|
|
|
|
// This widget throws during its regular build and then again when the
|
|
// ErrorWidget is constructed, which calls MyThrowingElement.debugFillProperties.
|
|
class MyDoubleThrowingWidget extends StatelessWidget {
|
|
const MyDoubleThrowingWidget({super.key});
|
|
|
|
@override
|
|
StatelessElement createElement() => MyThrowingElement(this);
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
throw UnsupportedError('You cannot build me!');
|
|
}
|
|
}
|
|
|
|
class MyThrowingElement extends StatelessElement {
|
|
MyThrowingElement(super.widget);
|
|
|
|
static const String debugFillPropertiesErrorMessage = 'Crash during debugFillProperties';
|
|
|
|
@override
|
|
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
|
|
super.debugFillProperties(properties);
|
|
throw UnsupportedError(debugFillPropertiesErrorMessage);
|
|
}
|
|
}
|