mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
db38e71bfc
- Fix https://github.com/flutter/flutter/issues/171422 (and maybe also
https://github.com/flutter/flutter/issues/167180, and
https://github.com/flutter/flutter/issues/163477)
- Investigation: Per discussion in
https://github.com/flutter/flutter/issues/171422, the issue is probably
happening due to accessing inherited widgets via `context` in
`positionBuilder`(like `PopupMenuTheme`) when PopupMenu's State is
inactive. This PR proposed a fix by caching the necessary objects in
`didChangeDependencies` method. Some of `RenderBox` are also cached to
avoid another exception like _Cannot get renderObject of inactive
element._.This solution can also be seen at another widget like
`CalendarDatePicker`:
d6b2a95215/packages/flutter/lib/src/material/calendar_date_picker.dart (L225-L232)
<details open>
<summary>Demo</summary>
| before | after |
| --------------- | --------------- |
<video
src="https://github.com/user-attachments/assets/2af0a4cb-216c-4033-bdd6-d288338bdf6b"/>
| <video
src="https://github.com/user-attachments/assets/c3e46f9c-9ead-4060-9df7-208bee7be740"/>
</details>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Signed-off-by: huycozy <huy@nevercode.io>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>