mirror of
https://github.com/flutter/flutter.git
synced 2026-01-09 07:51:35 +08:00
9d96df2364
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
69 lines
2.3 KiB
Dart
69 lines
2.3 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter_devicelab/framework/runner.dart';
|
|
import 'package:vm_service/vm_service.dart';
|
|
|
|
import 'common.dart';
|
|
|
|
void main() {
|
|
final isolateParams = <String, String>{'runFlutterConfig': 'false', 'timeoutInMinutes': '1'};
|
|
late List<String> printLog;
|
|
void print(String s) => printLog.add(s);
|
|
|
|
group('run.dart script', () {
|
|
test('Reruns - Test passes the first time.', () async {
|
|
printLog = <String>[];
|
|
await runTasks(
|
|
<String>['smoke_test_success'],
|
|
isolateParams: isolateParams,
|
|
print: print,
|
|
logs: printLog,
|
|
);
|
|
expect(printLog.length, 2);
|
|
expect(printLog[0], 'Test passed on first attempt.');
|
|
expect(printLog[1], 'flaky: false');
|
|
});
|
|
|
|
test('Reruns - Test fails all reruns.', () async {
|
|
printLog = <String>[];
|
|
await runTasks(
|
|
<String>['smoke_test_failure'],
|
|
isolateParams: isolateParams,
|
|
print: print,
|
|
logs: printLog,
|
|
);
|
|
expect(printLog.length, 2);
|
|
expect(printLog[0], 'Consistently failed across all 3 executions.');
|
|
expect(printLog[1], 'flaky: false');
|
|
});
|
|
|
|
test(
|
|
'Ensures task results are received before task process shuts down.',
|
|
() async {
|
|
// Regression test for https://github.com/flutter/flutter/issues/155475
|
|
//
|
|
// Runs multiple concurrent instances of a short-lived task in an effort to
|
|
// trigger the race between the VM service processing the response from
|
|
// ext.cocoonRunTask and the VM shutting down, which will throw a RPCError
|
|
// with a "Service connection disposed" message.
|
|
//
|
|
// Obviously this isn't foolproof, but this test becoming flaky or failing
|
|
// consistently should signal that we're encountering a shutdown race
|
|
// somewhere.
|
|
const runs = 30;
|
|
try {
|
|
await Future.wait(<Future<void>>[
|
|
for (int i = 0; i < runs; ++i)
|
|
runTasks(<String>['smoke_test_success'], isolateParams: isolateParams),
|
|
], eagerError: true);
|
|
} on RPCError catch (e) {
|
|
fail('Unexpected RPCError: $e');
|
|
}
|
|
},
|
|
timeout: const Timeout.factor(2),
|
|
);
|
|
});
|
|
}
|