flutter_flutter/dev/devicelab/lib/tasks/flutter_tool_startup.dart
Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

167 lines
4.7 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:io';
import 'package:path/path.dart' as path;
import '../framework/task_result.dart';
import '../framework/utils.dart';
/// Run each benchmark this many times and compute average, min, max.
const int _kRunsPerBenchmark = 10;
Future<TaskResult> flutterToolStartupBenchmarkTask() async {
final Directory projectParentDirectory = Directory.systemTemp.createTempSync(
'flutter_tool_startup_benchmark',
);
final Directory projectDirectory = dir(path.join(projectParentDirectory.path, 'benchmark'));
await inDirectory<void>(flutterDirectory, () async {
await flutter('update-packages');
await flutter('create', options: <String>[projectDirectory.path]);
// Remove 'test' directory so we don't time the actual testing, but only the launching of the flutter tool
rmTree(dir(path.join(projectDirectory.path, 'test')));
});
final data = <String, dynamic>{
// `flutter test` in dir with no `test` folder.
...(await _Benchmark(
projectDirectory,
'test startup',
'test',
).run()).asMap('flutter_tool_startup_test'),
// `flutter test -d foo_device` in dir with no `test` folder.
...(await _Benchmark(
projectDirectory,
'test startup with specified device',
'test',
options: <String>['-d', 'foo_device'],
).run()).asMap('flutter_tool_startup_test_with_specified_device'),
// `flutter test -v` where no android sdk will be found (at least currently).
...(await _Benchmark(
projectDirectory,
'test startup no android sdk',
'test',
options: <String>['-v'],
environment: <String, String>{
'ANDROID_HOME': 'dummy value',
'ANDROID_SDK_ROOT': 'dummy value',
'PATH': pathWithoutWhereHits(<String>['adb', 'aapt']),
},
).run()).asMap('flutter_tool_startup_test_no_android_sdk'),
// `flutter -h`.
...(await _Benchmark(
projectDirectory,
'help startup',
'-h',
).run()).asMap('flutter_tool_startup_help'),
};
// Cleanup.
rmTree(projectParentDirectory);
return TaskResult.success(data, benchmarkScoreKeys: data.keys.toList());
}
String pathWithoutWhereHits(List<String> whats) {
final String pathEnvironment = Platform.environment['PATH'] ?? '';
List<String> paths;
if (Platform.isWindows) {
paths = pathEnvironment.split(';');
} else {
paths = pathEnvironment.split(':');
}
// This isn't great but will probably work for our purposes.
final extensions = <String>['', '.exe', '.bat', '.com'];
final notFound = <String>[];
for (final path in paths) {
var found = false;
for (final extension in extensions) {
for (final what in whats) {
final f = File('$path${Platform.pathSeparator}$what$extension');
if (f.existsSync()) {
found = true;
break;
}
}
if (found) {
break;
}
}
if (!found) {
notFound.add(path);
}
}
if (Platform.isWindows) {
return notFound.join(';');
} else {
return notFound.join(':');
}
}
class _BenchmarkResult {
const _BenchmarkResult(this.mean, this.min, this.max);
final int mean; // Milliseconds
final int min; // Milliseconds
final int max; // Milliseconds
Map<String, dynamic> asMap(String name) {
return <String, dynamic>{name: mean, '${name}_minimum': min, '${name}_maximum': max};
}
}
class _Benchmark {
_Benchmark(
this.directory,
this.title,
this.command, {
this.options = const <String>[],
this.environment,
});
final Directory directory;
final String title;
final String command;
final List<String> options;
final Map<String, String>? environment;
Future<int> execute(int iteration, int targetIterations) async {
section('Benchmark $title - ${iteration + 1} / $targetIterations');
final stopwatch = Stopwatch();
await inDirectory<void>(directory, () async {
stopwatch.start();
// canFail is set to true, as e.g. `flutter test` in a dir with no `test`
// directory sets a non-zero return value.
await flutter(command, options: options, canFail: true, environment: environment);
stopwatch.stop();
});
return stopwatch.elapsedMilliseconds;
}
/// Runs `benchmark` several times and reports the results.
Future<_BenchmarkResult> run() async {
final results = <int>[];
var sum = 0;
for (var i = 0; i < _kRunsPerBenchmark; i++) {
final int thisRuntime = await execute(i, _kRunsPerBenchmark);
results.add(thisRuntime);
sum += thisRuntime;
}
results.sort();
return _BenchmarkResult(sum ~/ results.length, results.first, results.last);
}
}