mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Relands https://github.com/flutter/flutter/pull/162464 Fixes https://github.com/flutter/flutter/issues/170664 The only test that failed last time was `Linux_pixel_7pro android_obfuscate_test`, and I ran it locally (`flutter test test/integration.shard/android_obfuscate_test.dart `) to both repro the failure and verify it passes on this branch with the additional changes. Also does some stuff in the FGP: The reason we failed the tests last time was we were bundling of the libapp.so code into a jar in the aar case, instead of simply including it as its own file in the source sets. I let gemini go on that part, modifying it to no longer pack as a jar, but it looks correct to me. Now that the `libapp.so` file is simply included in this case, AGP is able to strip it (it's not hidden inside a jar). Because this changes the FGP build process for add to app, I manually verified that the add to app flow isn't broken for including a flutter module both as source and as an aar. <details> <summary>Before and after logs from the gradle task output</summary> Before: ``` > Task :flutter:stripReleaseDebugSymbols NO-SOURCE Skipping task ':flutter:stripReleaseDebugSymbols' as it has no source files and no previous output files. ``` After: ``` Task ':flutter:stripReleaseDebugSymbols' is not up-to-date because: No history is available. The input changes require a full rebuild for incremental task ':flutter:stripReleaseDebugSymbols'. C/C++: android.ndkVersion from module build.gradle is [28.2.13676358] C/C++: android.ndkVersion from module build.gradle is [28.2.13676358] C/C++: android.ndkPath from module build.gradle is not set C/C++: android.ndkPath from module build.gradle is not set C/C++: ndk.dir in local.properties is not set C/C++: ndk.dir in local.properties is not set C/C++: Not considering ANDROID_NDK_HOME because support was removed after deprecation period. C/C++: Not considering ANDROID_NDK_HOME because support was removed after deprecation period. C/C++: android.ndkVersion from module build.gradle is [28.2.13676358] C/C++: android.ndkPath from module build.gradle is not set C/C++: sdkFolder is /Users/mackall/Library/Android/sdk C/C++: ndk.dir in local.properties is not set C/C++: Not considering ANDROID_NDK_HOME because support was removed after deprecation period. C/C++: sdkFolder is /Users/mackall/Library/Android/sdk C/C++: sdkFolder is /Users/mackall/Library/Android/sdk Starting process 'command '/Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip''. Working directory: /Users/mackall/development/BugTesting/mblahm/.android/Flutter Command: /Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip --strip-unneeded -o /Users/mackall/development/BugTesting/mblahm/.android/Flutter/build/intermediates/stripped_native_libs/release/stripReleaseDebugSymbols/out/lib/armeabi-v7a/libapp.so /Users/mackall/development/BugTesting/mblahm/.android/Flutter/build/intermediates/merged_native_libs/release/mergeReleaseNativeLibs/out/lib/armeabi-v7a/libapp.so Starting process 'command '/Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip''. Working directory: /Users/mackall/development/BugTesting/mblahm/.android/Flutter Command: /Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip --strip-unneeded -o /Users/mackall/development/BugTesting/mblahm/.android/Flutter/build/intermediates/stripped_native_libs/release/stripReleaseDebugSymbols/out/lib/x86_64/libapp.so /Users/mackall/development/BugTesting/mblahm/.android/Flutter/build/intermediates/merged_native_libs/release/mergeReleaseNativeLibs/out/lib/x86_64/libapp.so Starting process 'command '/Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip''. Working directory: /Users/mackall/development/BugTesting/mblahm/.android/Flutter Command: /Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip --strip-unneeded -o /Users/mackall/development/BugTesting/mblahm/.android/Flutter/build/intermediates/stripped_native_libs/release/stripReleaseDebugSymbols/out/lib/arm64-v8a/libapp.so /Users/mackall/development/BugTesting/mblahm/.android/Flutter/build/intermediates/merged_native_libs/release/mergeReleaseNativeLibs/out/lib/arm64-v8a/libapp.so Successfully started process 'command '/Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip'' Successfully started process 'command '/Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip'' Successfully started process 'command '/Users/mackall/Library/Android/sdk/ndk/28.2.13676358/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-strip'' ``` </details> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
189 lines
7.4 KiB
Dart
189 lines
7.4 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter_devicelab/framework/apk_utils.dart';
|
|
import 'package:flutter_devicelab/framework/framework.dart';
|
|
import 'package:flutter_devicelab/framework/task_result.dart';
|
|
import 'package:flutter_devicelab/framework/utils.dart';
|
|
import 'package:path/path.dart' as path;
|
|
|
|
Future<void> main() async {
|
|
final Iterable<String> baseAabFiles = <String>[
|
|
'base/dex/classes.dex',
|
|
'base/manifest/AndroidManifest.xml',
|
|
];
|
|
final Iterable<String> flutterAabAssets = flutterAssets.map((String file) => 'base/$file');
|
|
await task(() async {
|
|
try {
|
|
await runProjectTest((FlutterProject project) async {
|
|
section('App bundle content for task bundleRelease without explicit target platform');
|
|
|
|
await inDirectory(project.rootPath, () {
|
|
return flutter('build', options: <String>['appbundle']);
|
|
});
|
|
|
|
final String releaseBundle = path.join(
|
|
project.rootPath,
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'bundle',
|
|
'release',
|
|
'app-release.aab',
|
|
);
|
|
checkCollectionContains<String>(<String>[
|
|
...baseAabFiles,
|
|
...flutterAabAssets,
|
|
'base/lib/arm64-v8a/libapp.so',
|
|
'base/lib/arm64-v8a/libflutter.so',
|
|
'base/lib/armeabi-v7a/libapp.so',
|
|
'base/lib/armeabi-v7a/libflutter.so',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
|
|
], await getFilesInAppBundle(releaseBundle));
|
|
});
|
|
|
|
await runProjectTest((FlutterProject project) async {
|
|
section('App bundle content using flavors without explicit target platform');
|
|
// Add a few flavors.
|
|
await project.addProductFlavors(<String>[
|
|
'production',
|
|
'staging',
|
|
'development',
|
|
'flavor_underscore', // https://github.com/flutter/flutter/issues/36067
|
|
]);
|
|
// Build the production flavor in release mode.
|
|
await inDirectory(project.rootPath, () {
|
|
return flutter('build', options: <String>['appbundle', '--flavor', 'production']);
|
|
});
|
|
|
|
final String bundleFromGradlePath = path.join(
|
|
project.rootPath,
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'bundle',
|
|
'productionRelease',
|
|
'app-production-release.aab',
|
|
);
|
|
checkCollectionContains<String>(<String>[
|
|
...baseAabFiles,
|
|
...flutterAabAssets,
|
|
'base/lib/arm64-v8a/libapp.so',
|
|
'base/lib/arm64-v8a/libflutter.so',
|
|
'base/lib/armeabi-v7a/libapp.so',
|
|
'base/lib/armeabi-v7a/libflutter.so',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
|
|
], await getFilesInAppBundle(bundleFromGradlePath));
|
|
|
|
section('Build app bundle using the flutter tool - flavor: flavor_underscore');
|
|
|
|
int exitCode = await inDirectory(project.rootPath, () {
|
|
return flutter('build', options: <String>['appbundle', '--flavor=flavor_underscore']);
|
|
});
|
|
|
|
if (exitCode != 0) {
|
|
throw TaskResult.failure('flutter build appbundle command exited with code: $exitCode');
|
|
}
|
|
|
|
final String flavorUnderscoreBundlePath = path.join(
|
|
project.rootPath,
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'bundle',
|
|
'flavor_underscoreRelease',
|
|
'app-flavor_underscore-release.aab',
|
|
);
|
|
checkCollectionContains<String>(<String>[
|
|
...baseAabFiles,
|
|
...flutterAabAssets,
|
|
'base/lib/arm64-v8a/libapp.so',
|
|
'base/lib/arm64-v8a/libflutter.so',
|
|
'base/lib/armeabi-v7a/libapp.so',
|
|
'base/lib/armeabi-v7a/libflutter.so',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
|
|
], await getFilesInAppBundle(flavorUnderscoreBundlePath));
|
|
|
|
section('Build app bundle using the flutter tool - flavor: production');
|
|
|
|
exitCode = await inDirectory(project.rootPath, () {
|
|
return flutter('build', options: <String>['appbundle', '--flavor=production']);
|
|
});
|
|
|
|
if (exitCode != 0) {
|
|
throw TaskResult.failure('flutter build appbundle command exited with code: $exitCode');
|
|
}
|
|
|
|
final String productionBundlePath = path.join(
|
|
project.rootPath,
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'bundle',
|
|
'productionRelease',
|
|
'app-production-release.aab',
|
|
);
|
|
checkCollectionContains<String>(<String>[
|
|
...baseAabFiles,
|
|
...flutterAabAssets,
|
|
'base/lib/arm64-v8a/libapp.so',
|
|
'base/lib/arm64-v8a/libflutter.so',
|
|
'base/lib/armeabi-v7a/libapp.so',
|
|
'base/lib/armeabi-v7a/libflutter.so',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libapp.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/arm64-v8a/libflutter.so.sym',
|
|
'BUNDLE-METADATA/com.android.tools.build.debugsymbols/armeabi-v7a/libflutter.so.sym',
|
|
], await getFilesInAppBundle(productionBundlePath));
|
|
});
|
|
|
|
await runProjectTest((FlutterProject project) async {
|
|
section('App bundle content for task bundleRelease with target platform = android-arm');
|
|
|
|
await inDirectory(project.rootPath, () {
|
|
return flutter('build', options: <String>['appbundle', '--target-platform=android-arm']);
|
|
});
|
|
|
|
final String releaseBundle = path.join(
|
|
project.rootPath,
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'bundle',
|
|
'release',
|
|
'app-release.aab',
|
|
);
|
|
|
|
final Iterable<String> bundleFiles = await getFilesInAppBundle(releaseBundle);
|
|
checkCollectionContains<String>(<String>[
|
|
...baseAabFiles,
|
|
...flutterAabAssets,
|
|
'base/lib/armeabi-v7a/libapp.so',
|
|
'base/lib/armeabi-v7a/libflutter.so',
|
|
], bundleFiles);
|
|
|
|
checkCollectionDoesNotContain<String>(<String>[
|
|
'base/lib/arm64-v8a/libapp.so',
|
|
'base/lib/arm64-v8a/libflutter.so',
|
|
], bundleFiles);
|
|
});
|
|
return TaskResult.success(null);
|
|
} on TaskResult catch (taskResult) {
|
|
return taskResult;
|
|
} catch (e, stackTrace) {
|
|
print('Task exception stack trace:\n$stackTrace');
|
|
return TaskResult.failure(e.toString());
|
|
}
|
|
});
|
|
}
|