mirror of
https://github.com/flutter/flutter.git
synced 2026-01-09 07:51:35 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
291 lines
9.5 KiB
Dart
291 lines
9.5 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// To run this, from the root of the Flutter repository:
|
|
// bin/cache/dart-sdk/bin/dart --enable-asserts dev/bots/check_code_samples.dart
|
|
|
|
import 'dart:io';
|
|
|
|
import 'package:args/args.dart';
|
|
import 'package:file/file.dart';
|
|
import 'package:file/local.dart';
|
|
import 'package:path/path.dart' as path;
|
|
|
|
import 'utils.dart';
|
|
|
|
final String _scriptLocation = path.fromUri(Platform.script);
|
|
final String _flutterRoot = path.dirname(path.dirname(path.dirname(_scriptLocation)));
|
|
final String _exampleDirectoryPath = path.join(_flutterRoot, 'examples', 'api');
|
|
final String _packageDirectoryPath = path.join(_flutterRoot, 'packages');
|
|
final String _dartUIDirectoryPath = path.join(
|
|
_flutterRoot,
|
|
'bin',
|
|
'cache',
|
|
'pkg',
|
|
'sky_engine',
|
|
'lib',
|
|
);
|
|
|
|
final List<String> _knownUnlinkedExamples = <String>[
|
|
// These are template files that aren't expected to be linked.
|
|
'examples/api/lib/sample_templates/cupertino.0.dart',
|
|
'examples/api/lib/sample_templates/widgets.0.dart',
|
|
'examples/api/lib/sample_templates/material.0.dart',
|
|
];
|
|
|
|
void main(List<String> args) {
|
|
final argParser = ArgParser();
|
|
argParser.addFlag('help', negatable: false, help: 'Print help for this command.');
|
|
argParser.addOption(
|
|
'examples',
|
|
valueHelp: 'path',
|
|
defaultsTo: _exampleDirectoryPath,
|
|
help: 'A location where the API doc examples are found.',
|
|
);
|
|
argParser.addOption(
|
|
'packages',
|
|
valueHelp: 'path',
|
|
defaultsTo: _packageDirectoryPath,
|
|
help: 'A location where the source code that should link the API doc examples is found.',
|
|
);
|
|
argParser.addOption(
|
|
'dart-ui',
|
|
valueHelp: 'path',
|
|
defaultsTo: _dartUIDirectoryPath,
|
|
help: 'A location where the source code that should link the API doc examples is found.',
|
|
);
|
|
argParser.addOption(
|
|
'flutter-root',
|
|
valueHelp: 'path',
|
|
defaultsTo: _flutterRoot,
|
|
help: 'The path to the root of the Flutter repo.',
|
|
);
|
|
final ArgResults parsedArgs;
|
|
|
|
void usage() {
|
|
print('dart --enable-asserts ${path.basename(_scriptLocation)} [options]');
|
|
print(argParser.usage);
|
|
}
|
|
|
|
try {
|
|
parsedArgs = argParser.parse(args);
|
|
} on FormatException catch (e) {
|
|
print(e.message);
|
|
usage();
|
|
exit(1);
|
|
}
|
|
|
|
if (parsedArgs['help'] as bool) {
|
|
usage();
|
|
exit(0);
|
|
}
|
|
|
|
const FileSystem filesystem = LocalFileSystem();
|
|
final Directory examples = filesystem.directory(parsedArgs['examples']! as String);
|
|
final Directory packages = filesystem.directory(parsedArgs['packages']! as String);
|
|
final Directory dartUIPath = filesystem.directory(parsedArgs['dart-ui']! as String);
|
|
final Directory flutterRoot = filesystem.directory(parsedArgs['flutter-root']! as String);
|
|
|
|
final checker = SampleChecker(
|
|
examples: examples,
|
|
packages: packages,
|
|
dartUIPath: dartUIPath,
|
|
flutterRoot: flutterRoot,
|
|
);
|
|
|
|
if (!checker.checkCodeSamples()) {
|
|
reportErrorsAndExit('Some errors were found in the API docs code samples.');
|
|
}
|
|
reportSuccessAndExit('All examples are linked and have tests.');
|
|
}
|
|
|
|
class LinkInfo {
|
|
const LinkInfo(this.link, this.file, this.line);
|
|
|
|
final String link;
|
|
final File file;
|
|
final int line;
|
|
|
|
@override
|
|
String toString() {
|
|
return '${file.path}:$line: $link';
|
|
}
|
|
}
|
|
|
|
class SampleChecker {
|
|
SampleChecker({
|
|
required this.examples,
|
|
required this.packages,
|
|
required this.dartUIPath,
|
|
required this.flutterRoot,
|
|
this.filesystem = const LocalFileSystem(),
|
|
});
|
|
|
|
final Directory examples;
|
|
final Directory packages;
|
|
final Directory dartUIPath;
|
|
final Directory flutterRoot;
|
|
final FileSystem filesystem;
|
|
|
|
bool checkCodeSamples() {
|
|
filesystem.currentDirectory = flutterRoot;
|
|
|
|
// Get a list of all the filenames in the source directory that end in "[0-9]+.dart".
|
|
final List<File> exampleFilenames = getExampleFilenames(examples);
|
|
|
|
// Get a list of all the example link paths that appear in the source files.
|
|
final (Set<String> exampleLinks, Set<LinkInfo> malformedLinks) = getExampleLinks(packages);
|
|
// Also add in any that might be found in the dart:ui directory.
|
|
final (Set<String> uiExampleLinks, Set<LinkInfo> uiMalformedLinks) = getExampleLinks(
|
|
dartUIPath,
|
|
);
|
|
|
|
exampleLinks.addAll(uiExampleLinks);
|
|
malformedLinks.addAll(uiMalformedLinks);
|
|
|
|
// Get a list of the filenames that were not found in the source files.
|
|
final List<String> missingFilenames = checkForMissingLinks(exampleFilenames, exampleLinks);
|
|
|
|
// Get a list of any tests that are missing.
|
|
final List<File> missingTests = checkForMissingTests(exampleFilenames);
|
|
|
|
// Remove any that we know are exceptions (examples that aren't expected to be
|
|
// linked into any source files). These are typically template files used to
|
|
// generate new examples.
|
|
missingFilenames.removeWhere((String file) => _knownUnlinkedExamples.contains(file));
|
|
|
|
if (missingFilenames.isEmpty && missingTests.isEmpty && malformedLinks.isEmpty) {
|
|
return true;
|
|
}
|
|
|
|
if (missingTests.isNotEmpty) {
|
|
final buffer = StringBuffer('The following example test files are missing:\n');
|
|
for (final name in missingTests) {
|
|
buffer.writeln(' ${getRelativePath(name)}');
|
|
}
|
|
foundError(buffer.toString().trimRight().split('\n'));
|
|
}
|
|
|
|
if (missingFilenames.isNotEmpty) {
|
|
final buffer = StringBuffer(
|
|
'The following examples are not linked from any source file API doc comments:\n',
|
|
);
|
|
for (final name in missingFilenames) {
|
|
buffer.writeln(' $name');
|
|
}
|
|
buffer.write('Either link them to a source file API doc comment, or remove them.');
|
|
foundError(buffer.toString().split('\n'));
|
|
}
|
|
|
|
if (malformedLinks.isNotEmpty) {
|
|
final buffer = StringBuffer(
|
|
'The following malformed links were found in API doc comments:\n',
|
|
);
|
|
for (final link in malformedLinks) {
|
|
buffer.writeln(' $link');
|
|
}
|
|
buffer.write(
|
|
'Correct the formatting of these links so that they match the exact pattern:\n'
|
|
r" r'\*\* See code in (?<path>.+) \*\*'",
|
|
);
|
|
foundError(buffer.toString().split('\n'));
|
|
}
|
|
return false;
|
|
}
|
|
|
|
String getRelativePath(File file, [Directory? root]) {
|
|
root ??= flutterRoot;
|
|
return path.relative(file.absolute.path, from: root.absolute.path);
|
|
}
|
|
|
|
List<File> getFiles(Directory directory, [Pattern? filenamePattern]) {
|
|
final List<File> filenames = directory
|
|
.listSync(recursive: true)
|
|
.map((FileSystemEntity entity) {
|
|
if (entity is File) {
|
|
return entity;
|
|
} else {
|
|
return null;
|
|
}
|
|
})
|
|
.where(
|
|
(File? filename) =>
|
|
filename != null &&
|
|
(filenamePattern == null || filename.absolute.path.contains(filenamePattern)),
|
|
)
|
|
.map<File>((File? s) => s!)
|
|
.toList();
|
|
return filenames;
|
|
}
|
|
|
|
List<File> getExampleFilenames(Directory directory) {
|
|
return getFiles(directory.childDirectory('lib'), RegExp(r'\d+\.dart$'));
|
|
}
|
|
|
|
(Set<String>, Set<LinkInfo>) getExampleLinks(Directory searchDirectory) {
|
|
final List<File> files = getFiles(searchDirectory, RegExp(r'\.dart$'));
|
|
final searchStrings = <String>{};
|
|
final malformedStrings = <LinkInfo>{};
|
|
final validExampleRe = RegExp(r'\*\* See code in (?<path>.+) \*\*');
|
|
// Looks for some common broken versions of example links. This looks for
|
|
// something that is at minimum "///*seecode<something>*" to indicate that it
|
|
// looks like an example link. It should be narrowed if we start getting false
|
|
// positives.
|
|
final malformedLinkRe = RegExp(
|
|
r'^(?<malformed>\s*///\s*\*\*?\s*[sS][eE][eE]\s*[Cc][Oo][Dd][Ee].+\*\*?)',
|
|
);
|
|
for (final file in files) {
|
|
final String contents = file.readAsStringSync();
|
|
final List<String> lines = contents.split('\n');
|
|
var count = 0;
|
|
for (final line in lines) {
|
|
count += 1;
|
|
final RegExpMatch? validMatch = validExampleRe.firstMatch(line);
|
|
if (validMatch != null) {
|
|
searchStrings.add(validMatch.namedGroup('path')!);
|
|
}
|
|
final RegExpMatch? malformedMatch = malformedLinkRe.firstMatch(line);
|
|
// It's only malformed if it doesn't match the valid RegExp.
|
|
if (malformedMatch != null && validMatch == null) {
|
|
malformedStrings.add(LinkInfo(malformedMatch.namedGroup('malformed')!, file, count));
|
|
}
|
|
}
|
|
}
|
|
return (searchStrings, malformedStrings);
|
|
}
|
|
|
|
List<String> checkForMissingLinks(List<File> exampleFilenames, Set<String> searchStrings) {
|
|
final missingFilenames = <String>[];
|
|
for (final example in exampleFilenames) {
|
|
final String relativePath = getRelativePath(example);
|
|
if (!searchStrings.contains(relativePath)) {
|
|
missingFilenames.add(relativePath);
|
|
}
|
|
}
|
|
return missingFilenames;
|
|
}
|
|
|
|
String getTestNameForExample(File example, Directory examples) {
|
|
final String testPath = path.dirname(
|
|
path.join(
|
|
examples.absolute.path,
|
|
'test',
|
|
getRelativePath(example, examples.childDirectory('lib')),
|
|
),
|
|
);
|
|
return '${path.join(testPath, path.basenameWithoutExtension(example.path))}_test.dart';
|
|
}
|
|
|
|
List<File> checkForMissingTests(List<File> exampleFilenames) {
|
|
final missingTests = <File>[];
|
|
for (final example in exampleFilenames) {
|
|
final File testFile = filesystem.file(getTestNameForExample(example, examples));
|
|
if (!testFile.existsSync()) {
|
|
missingTests.add(testFile);
|
|
}
|
|
}
|
|
return missingTests;
|
|
}
|
|
}
|