mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Rebase ios-experimental branch onto main. This will make the PRs experimenting with newer versions of Xcode (like https://github.com/flutter/flutter/pull/173123) smaller and easier to reason about. Rebases #168860 and #170274 ``` $ git rebase main -Xtheirs ``` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Co-authored-by: Siva <a-siva@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jamil Saadeh <jssaadeh@outlook.com> Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com> Co-authored-by: Ricardo Dalarme <ricardodalarme@outlook.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Justin McCandless <jmccandless@google.com> Co-authored-by: Alex Talebi <31685655+SalehTZ@users.noreply.github.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: Mouad Debbar <mdebbar@google.com> Co-authored-by: Zuckjet <1083941774@qq.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: auto-submit[bot] <98614782+auto-submit[bot]@users.noreply.github.com> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: yim <ybz975218925@gmail.com> Co-authored-by: bufffun <chenmingding.cmd@alibaba-inc.com> Co-authored-by: Chinmay Garde <chinmaygarde@google.com> Co-authored-by: Hannah Jin <jhy03261997@gmail.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Valentin Vignal <32538273+ValentinVignal@users.noreply.github.com> Co-authored-by: Derek Xu <derekx@google.com> Co-authored-by: Yash Dhrangdhariya <72062416+Yash-Dhrangdhariya@users.noreply.github.com> Co-authored-by: bungeman <bungeman@chromium.org> Co-authored-by: Ahmed Mohamed Sameh <ahmedsameha1@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com> Co-authored-by: Dmitry Grand <dmgr@google.com> Co-authored-by: Kostia Sokolovskyi <sokolovskyi.konstantin@gmail.com> Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com> Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Jim Graham <flar@google.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Jon Ihlas <jon.i@hotmail.fr> Co-authored-by: Micael Cid <micaelcid10@gmail.com> Co-authored-by: Alexander Aprelev <aam@google.com> Co-authored-by: hellohuanlin <41930132+hellohuanlin@users.noreply.github.com> Co-authored-by: Luke Memet <1598289+lukemmtt@users.noreply.github.com> Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com> Co-authored-by: Mairramer <50643541+Mairramer@users.noreply.github.com> Co-authored-by: Florin Malita <fmalita@gmail.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Salem Iranloye <127918074+salemiranloye@users.noreply.github.com> Co-authored-by: Kevin Moore <kevmoo@google.com> Co-authored-by: Sydney Bao <sydneybao@google.com> Co-authored-by: Wdestroier <Wdestroier@gmail.com> Co-authored-by: Matt Boetger <matt.boetger@gmail.com> Co-authored-by: Reid Baker <reidbaker@google.com> Co-authored-by: Victor Sanni <victorsanniay@gmail.com> Co-authored-by: Jessy Yameogo <jessy.yameogo@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: romain.gyh <11901536+romaingyh@users.noreply.github.com> Co-authored-by: Robert Ancell <robert.ancell@canonical.com> Co-authored-by: TheLastFlame <131446187+TheLastFlame@users.noreply.github.com> Co-authored-by: masato <returnymgstokh@icloud.com> Co-authored-by: Albin PK <56157868+albinpk@users.noreply.github.com> Co-authored-by: Huy <huy@nevercode.io> Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com> Co-authored-by: Azat Chorekliyev <azat24680@gmail.com> Co-authored-by: EdwynZN <edwinzn9@gmail.com> Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com> Co-authored-by: Dev TtangKong <ttankkeo112@gmail.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Houssem Eddine Fadhli <houssemeddinefadhli81@gmail.com>
241 lines
8.0 KiB
Dart
241 lines
8.0 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:convert';
|
|
import 'dart:io' hide Platform;
|
|
|
|
import 'package:collection/collection.dart';
|
|
import 'package:file/file.dart' as fs;
|
|
import 'package:file/memory.dart';
|
|
import 'package:path/path.dart' as path;
|
|
import 'package:process/process.dart';
|
|
|
|
import '../suite_runners/run_flutter_packages_tests.dart';
|
|
import '../utils.dart';
|
|
import 'common.dart';
|
|
|
|
/// Fails a test if the exit code of `result` is not the expected value. This
|
|
/// is favored over `expect(result.exitCode, expectedExitCode)` because this
|
|
/// will include the process result's stdio in the failure message.
|
|
void expectExitCode(ProcessResult result, int expectedExitCode) {
|
|
if (result.exitCode != expectedExitCode) {
|
|
fail(
|
|
'Process ${result.pid} exited with the wrong exit code.\n'
|
|
'\n'
|
|
'EXPECTED: exit code $expectedExitCode\n'
|
|
'ACTUAL: exit code ${result.exitCode}\n'
|
|
'\n'
|
|
'STDOUT:\n'
|
|
'${result.stdout}\n'
|
|
'STDERR:\n'
|
|
'${result.stderr}',
|
|
);
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
group('verifyVersion()', () {
|
|
late MemoryFileSystem fileSystem;
|
|
|
|
setUp(() {
|
|
fileSystem = MemoryFileSystem.test();
|
|
});
|
|
|
|
test('passes for valid version strings', () async {
|
|
const List<String> valid_versions = <String>[
|
|
'1.2.3',
|
|
'12.34.56',
|
|
'1.2.3.pre.1',
|
|
'1.2.3-4.5.pre',
|
|
'1.2.3-5.0.pre.12',
|
|
];
|
|
for (final String version in valid_versions) {
|
|
final fs.File file = fileSystem.file('version');
|
|
file.writeAsStringSync(jsonEncode(<String, String>{'flutterVersion': version}));
|
|
|
|
await expectLater(
|
|
Version.resolveFile(file),
|
|
completion(isA<VersionOk>()),
|
|
reason: '$version is valid but verifyVersionFile said it was bad',
|
|
);
|
|
}
|
|
});
|
|
|
|
test('fails for invalid version strings', () async {
|
|
const List<String> invalid_versions = <String>[
|
|
'1.2.3.4',
|
|
'1.2.3.',
|
|
'1.2.pre.1',
|
|
'1.2.3-pre.1',
|
|
'1.2.3-pre.1+hotfix.1',
|
|
' 1.2.3',
|
|
'1.2.3-hotfix.1',
|
|
];
|
|
for (final String version in invalid_versions) {
|
|
final fs.File file = fileSystem.file('version');
|
|
file.writeAsStringSync(jsonEncode(<String, String>{'flutterVersion': version}));
|
|
|
|
await expectLater(
|
|
Version.resolveFile(file),
|
|
completion(
|
|
isA<VersionError>().having(
|
|
(VersionError e) => e.error,
|
|
'error',
|
|
'The version logic generated an invalid version string: "$version".',
|
|
),
|
|
),
|
|
reason: '$version is invalid but verifyVersionFile said it was fine',
|
|
);
|
|
}
|
|
});
|
|
});
|
|
|
|
group('flutter/packages version', () {
|
|
final MemoryFileSystem memoryFileSystem = MemoryFileSystem();
|
|
final fs.File packagesVersionFile = memoryFileSystem.file(
|
|
path.join('bin', 'internal', 'flutter_packages.version'),
|
|
);
|
|
const String kSampleHash = '592b5b27431689336fa4c721a099eedf787aeb56';
|
|
setUpAll(() {
|
|
packagesVersionFile.createSync(recursive: true);
|
|
});
|
|
|
|
test('commit hash', () async {
|
|
packagesVersionFile.writeAsStringSync(kSampleHash);
|
|
final String actualHash = await getFlutterPackagesVersion(
|
|
flutterRoot: flutterRoot,
|
|
fileSystem: memoryFileSystem,
|
|
packagesVersionFile: packagesVersionFile.path,
|
|
);
|
|
expect(actualHash, kSampleHash);
|
|
});
|
|
|
|
test('commit hash with newlines', () async {
|
|
packagesVersionFile.writeAsStringSync('\n$kSampleHash\n');
|
|
final String actualHash = await getFlutterPackagesVersion(
|
|
flutterRoot: flutterRoot,
|
|
fileSystem: memoryFileSystem,
|
|
packagesVersionFile: packagesVersionFile.path,
|
|
);
|
|
expect(actualHash, kSampleHash);
|
|
});
|
|
});
|
|
|
|
group('test.dart script', () {
|
|
const ProcessManager processManager = LocalProcessManager();
|
|
|
|
Future<ProcessResult> runScript([
|
|
Map<String, String>? environment,
|
|
List<String> otherArgs = const <String>[],
|
|
]) async {
|
|
final String dart = path.absolute(
|
|
path.join('..', '..', 'bin', 'cache', 'dart-sdk', 'bin', 'dart'),
|
|
);
|
|
final ProcessResult scriptProcess = processManager.runSync(<String>[
|
|
dart,
|
|
'test.dart',
|
|
...otherArgs,
|
|
], environment: environment);
|
|
return scriptProcess;
|
|
}
|
|
|
|
test('subshards tests correctly', () async {
|
|
// When updating this test, try to pick shard numbers that ensure we're checking
|
|
// that unequal test distributions don't miss tests.
|
|
ProcessResult result = await runScript(<String, String>{
|
|
'SHARD': kTestHarnessShardName,
|
|
'SUBSHARD': '1_3',
|
|
});
|
|
expectExitCode(result, 0);
|
|
expect(result.stdout, contains('Selecting subshard 1 of 3 (tests 1-3 of 9)'));
|
|
|
|
result = await runScript(<String, String>{'SHARD': kTestHarnessShardName, 'SUBSHARD': '3_3'});
|
|
expectExitCode(result, 0);
|
|
expect(result.stdout, contains('Selecting subshard 3 of 3 (tests 7-9 of 9)'));
|
|
});
|
|
|
|
test('exits with code 1 when SUBSHARD index greater than total', () async {
|
|
final ProcessResult result = await runScript(<String, String>{
|
|
'SHARD': kTestHarnessShardName,
|
|
'SUBSHARD': '100_99',
|
|
});
|
|
expectExitCode(result, 1);
|
|
expect(result.stdout, contains('Invalid subshard name'));
|
|
});
|
|
|
|
test('exits with code 255 when invalid SUBSHARD name', () async {
|
|
final ProcessResult result = await runScript(<String, String>{
|
|
'SHARD': kTestHarnessShardName,
|
|
'SUBSHARD': 'invalid_name',
|
|
});
|
|
expectExitCode(result, 255);
|
|
expect(result.stdout, contains('Invalid subshard name'));
|
|
});
|
|
|
|
test('--dry-run prints every test that would run', () async {
|
|
final ProcessResult result = await runScript(<String, String>{}, <String>['--dry-run']);
|
|
expectExitCode(result, 0);
|
|
expect(result.stdout, contains('|> bin/flutter'));
|
|
}, testOn: 'posix');
|
|
});
|
|
|
|
test('selectTestsForSubShard distributes tests amongst subshards correctly', () async {
|
|
List<int> makeTests(int count) => List<int>.generate(count, (int index) => index);
|
|
|
|
void testSubsharding(int testCount, int subshardCount) {
|
|
String failureReason(String reason) {
|
|
return 'Subsharding test failed for testCount=$testCount, subshardCount=$subshardCount.\n'
|
|
'$reason';
|
|
}
|
|
|
|
final List<int> tests = makeTests(testCount);
|
|
final List<List<int>> subshards = List<List<int>>.generate(subshardCount, (int index) {
|
|
final int subShardIndex = index + 1;
|
|
final (int start, int end) = selectTestsForSubShard(
|
|
testCount: tests.length,
|
|
subShardIndex: subShardIndex,
|
|
subShardCount: subshardCount,
|
|
);
|
|
return tests.sublist(start, end);
|
|
});
|
|
|
|
final List<int> testedTests = subshards.flattened.toList();
|
|
final Set<int> deduped = Set<int>.from(subshards.flattened);
|
|
expect(
|
|
testedTests,
|
|
hasLength(deduped.length),
|
|
reason: failureReason('Subshards may have had duplicate tests.'),
|
|
);
|
|
expect(
|
|
testedTests,
|
|
unorderedEquals(tests),
|
|
reason: failureReason('One or more tests were not assigned to a subshard.'),
|
|
);
|
|
|
|
final int minimumTestsPerShard = (testCount / subshardCount).floor();
|
|
for (int i = 0; i < subshards.length; i++) {
|
|
final int extraTestsInThisShard = subshards[i].length - minimumTestsPerShard;
|
|
expect(
|
|
extraTestsInThisShard,
|
|
isNonNegative,
|
|
reason: failureReason(
|
|
'Subsharding uneven. Subshard ${i + 1} had too few tests: ${subshards[i].length}',
|
|
),
|
|
);
|
|
expect(
|
|
extraTestsInThisShard,
|
|
lessThanOrEqualTo(1),
|
|
reason: failureReason(
|
|
'Subsharding uneven. Subshard ${i + 1} had too many tests: ${subshards[i].length}',
|
|
),
|
|
);
|
|
}
|
|
}
|
|
|
|
testSubsharding(9, 3);
|
|
testSubsharding(25, 8);
|
|
testSubsharding(30, 15);
|
|
});
|
|
}
|