mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
450 lines
13 KiB
Dart
450 lines
13 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:math' as math;
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
class MyPainter extends CustomPainter {
|
|
const MyPainter({required this.color});
|
|
|
|
final Color color;
|
|
|
|
@override
|
|
void paint(Canvas canvas, Size size) {
|
|
canvas.drawColor(color, BlendMode.color);
|
|
}
|
|
|
|
@override
|
|
bool shouldRepaint(MyPainter oldDelegate) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
@immutable
|
|
class MethodAndArguments {
|
|
const MethodAndArguments(this.method, this.arguments);
|
|
|
|
final Symbol method;
|
|
final List<dynamic> arguments;
|
|
|
|
@override
|
|
bool operator ==(Object other) {
|
|
if (!(other is MethodAndArguments && other.method == method)) {
|
|
return false;
|
|
}
|
|
for (var i = 0; i < arguments.length; i++) {
|
|
if (arguments[i] != other.arguments[i]) {
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
@override
|
|
int get hashCode => method.hashCode;
|
|
|
|
@override
|
|
String toString() => '$method, $arguments';
|
|
}
|
|
|
|
void main() {
|
|
group('something', () {
|
|
testWidgets('matches when the predicate returns true', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const CustomPaint(
|
|
painter: MyPainter(color: Colors.transparent),
|
|
child: SizedBox(width: 50, height: 50),
|
|
),
|
|
);
|
|
|
|
final methodsAndArguments = <MethodAndArguments>[];
|
|
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..something((Symbol method, List<dynamic> arguments) {
|
|
methodsAndArguments.add(MethodAndArguments(method, arguments));
|
|
return method == #drawColor;
|
|
}),
|
|
);
|
|
|
|
expect(methodsAndArguments, <MethodAndArguments>[
|
|
const MethodAndArguments(#save, <dynamic>[]),
|
|
const MethodAndArguments(#drawColor, <dynamic>[Colors.transparent, BlendMode.color]),
|
|
// The #restore call is never evaluated
|
|
]);
|
|
});
|
|
|
|
testWidgets('fails when the predicate always returns false', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const CustomPaint(
|
|
painter: MyPainter(color: Colors.transparent),
|
|
child: SizedBox(width: 50, height: 50),
|
|
),
|
|
);
|
|
|
|
final methodsAndArguments = <MethodAndArguments>[];
|
|
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
isNot(
|
|
paints..something((Symbol method, List<dynamic> arguments) {
|
|
methodsAndArguments.add(MethodAndArguments(method, arguments));
|
|
return false;
|
|
}),
|
|
),
|
|
);
|
|
|
|
expect(methodsAndArguments, <MethodAndArguments>[
|
|
const MethodAndArguments(#save, <dynamic>[]),
|
|
const MethodAndArguments(#drawColor, <dynamic>[Colors.transparent, BlendMode.color]),
|
|
const MethodAndArguments(#restore, <dynamic>[]),
|
|
]);
|
|
});
|
|
|
|
testWidgets('fails when the predicate throws', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const CustomPaint(
|
|
painter: MyPainter(color: Colors.transparent),
|
|
child: SizedBox(width: 50, height: 50),
|
|
),
|
|
);
|
|
|
|
final methodsAndArguments = <MethodAndArguments>[];
|
|
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
isNot(
|
|
paints..something((Symbol method, List<dynamic> arguments) {
|
|
methodsAndArguments.add(MethodAndArguments(method, arguments));
|
|
if (method == #save) {
|
|
return false;
|
|
}
|
|
if (method == #drawColor) {
|
|
fail('fail');
|
|
}
|
|
return true;
|
|
}),
|
|
),
|
|
);
|
|
|
|
expect(methodsAndArguments, <MethodAndArguments>[
|
|
const MethodAndArguments(#save, <dynamic>[]),
|
|
const MethodAndArguments(#drawColor, <dynamic>[Colors.transparent, BlendMode.color]),
|
|
// The #restore call is never evaluated
|
|
]);
|
|
});
|
|
});
|
|
|
|
group('everything', () {
|
|
testWidgets('matches when the predicate always returns true', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const CustomPaint(
|
|
painter: MyPainter(color: Colors.transparent),
|
|
child: SizedBox(width: 50, height: 50),
|
|
),
|
|
);
|
|
|
|
final methodsAndArguments = <MethodAndArguments>[];
|
|
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..everything((Symbol method, List<dynamic> arguments) {
|
|
methodsAndArguments.add(MethodAndArguments(method, arguments));
|
|
return true;
|
|
}),
|
|
);
|
|
|
|
expect(methodsAndArguments, <MethodAndArguments>[
|
|
const MethodAndArguments(#save, <dynamic>[]),
|
|
const MethodAndArguments(#drawColor, <dynamic>[Colors.transparent, BlendMode.color]),
|
|
const MethodAndArguments(#restore, <dynamic>[]),
|
|
]);
|
|
});
|
|
|
|
testWidgets('fails when the predicate returns false', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const CustomPaint(
|
|
painter: MyPainter(color: Colors.transparent),
|
|
child: SizedBox(width: 50, height: 50),
|
|
),
|
|
);
|
|
|
|
final methodsAndArguments = <MethodAndArguments>[];
|
|
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
isNot(
|
|
paints..everything((Symbol method, List<dynamic> arguments) {
|
|
methodsAndArguments.add(MethodAndArguments(method, arguments));
|
|
// returns false on #drawColor
|
|
return method == #restore || method == #save;
|
|
}),
|
|
),
|
|
);
|
|
|
|
expect(methodsAndArguments, <MethodAndArguments>[
|
|
const MethodAndArguments(#save, <dynamic>[]),
|
|
const MethodAndArguments(#drawColor, <dynamic>[Colors.transparent, BlendMode.color]),
|
|
// The #restore call is never evaluated
|
|
]);
|
|
});
|
|
|
|
testWidgets('fails if the predicate ever throws', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const CustomPaint(
|
|
painter: MyPainter(color: Colors.transparent),
|
|
child: SizedBox(width: 50, height: 50),
|
|
),
|
|
);
|
|
|
|
final methodsAndArguments = <MethodAndArguments>[];
|
|
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
isNot(
|
|
paints..everything((Symbol method, List<dynamic> arguments) {
|
|
methodsAndArguments.add(MethodAndArguments(method, arguments));
|
|
if (method == #drawColor) {
|
|
fail('failed ');
|
|
}
|
|
return true;
|
|
}),
|
|
),
|
|
);
|
|
|
|
expect(methodsAndArguments, <MethodAndArguments>[
|
|
const MethodAndArguments(#save, <dynamic>[]),
|
|
const MethodAndArguments(#drawColor, <dynamic>[Colors.transparent, BlendMode.color]),
|
|
// The #restore call is never evaluated
|
|
]);
|
|
});
|
|
});
|
|
|
|
group('arc', () {
|
|
final Rect rect = Offset.zero & const Size.square(50);
|
|
const double startAngle = math.pi / 4;
|
|
const double sweepAngle = math.pi / 2;
|
|
const useCenter = false;
|
|
final paint = Paint()..color = Colors.blue;
|
|
|
|
Future<void> pumpPainter(WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: CustomPaint(
|
|
painter: _ArcPainter(
|
|
startAngle: startAngle,
|
|
sweepAngle: sweepAngle,
|
|
useCenter: useCenter,
|
|
paint: paint,
|
|
),
|
|
size: rect.size,
|
|
),
|
|
),
|
|
);
|
|
}
|
|
|
|
testWidgets('matches when rect is correct', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
expect(tester.renderObject(find.byType(CustomPaint)), paints..arc(rect: rect));
|
|
});
|
|
|
|
testWidgets('does not match when rect is incorrect', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
|
|
expect(
|
|
() => expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..arc(rect: rect.deflate(10)),
|
|
),
|
|
throwsA(
|
|
isA<TestFailure>().having(
|
|
(TestFailure failure) => failure.message,
|
|
'message',
|
|
contains(
|
|
'It called drawArc with a paint whose rect, '
|
|
'Rect.fromLTRB(0.0, 0.0, 50.0, 50.0), was not exactly the '
|
|
'expected rect (Rect.fromLTRB(10.0, 10.0, 40.0, 40.0)).',
|
|
),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
|
|
testWidgets('matches when startAngle is correct', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
expect(tester.renderObject(find.byType(CustomPaint)), paints..arc(startAngle: startAngle));
|
|
});
|
|
|
|
testWidgets('does not match when startAngle is incorrect', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
|
|
expect(
|
|
() => expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..arc(startAngle: startAngle * 2),
|
|
),
|
|
throwsA(
|
|
isA<TestFailure>().having(
|
|
(TestFailure failure) => failure.message,
|
|
'message',
|
|
contains(
|
|
'It called drawArc with a start angle, 0.7853981633974483, which '
|
|
'was not exactly the expected start angle (1.5707963267948966).',
|
|
),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
|
|
testWidgets('matches when sweepAngle is correct', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
expect(tester.renderObject(find.byType(CustomPaint)), paints..arc(sweepAngle: sweepAngle));
|
|
});
|
|
|
|
testWidgets('does not match when sweepAngle is incorrect', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
|
|
expect(
|
|
() => expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..arc(sweepAngle: sweepAngle * 2),
|
|
),
|
|
throwsA(
|
|
isA<TestFailure>().having(
|
|
(TestFailure failure) => failure.message,
|
|
'message',
|
|
contains(
|
|
'It called drawArc with a sweep angle, 1.5707963267948966, which '
|
|
'was not exactly the expected sweep angle (3.141592653589793).',
|
|
),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
|
|
testWidgets('matches when useCenter is correct', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
expect(tester.renderObject(find.byType(CustomPaint)), paints..arc(useCenter: useCenter));
|
|
});
|
|
|
|
testWidgets('does not match when useCenter is incorrect', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
|
|
expect(
|
|
() => expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..arc(useCenter: !useCenter),
|
|
),
|
|
throwsA(
|
|
isA<TestFailure>().having(
|
|
(TestFailure failure) => failure.message,
|
|
'message',
|
|
contains(
|
|
'It called drawArc with a useCenter value, false, which was not '
|
|
'exactly the expected value (true)',
|
|
),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('rsuperellipse', () {
|
|
final rsuperellipse = RSuperellipse.fromRectAndRadius(
|
|
Offset.zero & const Size.square(50),
|
|
const Radius.circular(5),
|
|
);
|
|
final paint = Paint()..color = Colors.blue;
|
|
|
|
Future<void> pumpPainter(WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: CustomPaint(
|
|
painter: _RSuperellipsePainter(rsuperellipse: rsuperellipse, paint: paint),
|
|
size: rsuperellipse.outerRect.size,
|
|
),
|
|
),
|
|
);
|
|
}
|
|
|
|
testWidgets('matches when rsuperellipse is correct', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..rsuperellipse(rsuperellipse: rsuperellipse),
|
|
);
|
|
});
|
|
|
|
testWidgets('does not match when rsuperellipse is incorrect', (WidgetTester tester) async {
|
|
await pumpPainter(tester);
|
|
|
|
expect(
|
|
() => expect(
|
|
tester.renderObject(find.byType(CustomPaint)),
|
|
paints..rsuperellipse(rsuperellipse: rsuperellipse.deflate(10)),
|
|
),
|
|
throwsA(
|
|
isA<TestFailure>().having(
|
|
(TestFailure failure) => failure.message,
|
|
'message',
|
|
contains(
|
|
'It called drawRSuperellipse with a rounded superellipse, '
|
|
'RSuperellipse.fromLTRBR(0.0, 0.0, 50.0, 50.0, 5.0), which was '
|
|
'not exactly the expected rounded superellipse '
|
|
'(RSuperellipse.fromLTRBR(10.0, 10.0, 40.0, 40.0, 0.0))',
|
|
),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
});
|
|
}
|
|
|
|
class _ArcPainter extends CustomPainter {
|
|
const _ArcPainter({
|
|
required this.startAngle,
|
|
required this.sweepAngle,
|
|
required this.useCenter,
|
|
required Paint paint,
|
|
}) : _paint = paint;
|
|
|
|
final double startAngle;
|
|
|
|
final double sweepAngle;
|
|
|
|
final bool useCenter;
|
|
|
|
final Paint _paint;
|
|
|
|
@override
|
|
void paint(Canvas canvas, Size size) {
|
|
canvas.drawArc(Offset.zero & size, startAngle, sweepAngle, useCenter, _paint);
|
|
}
|
|
|
|
@override
|
|
bool shouldRepaint(MyPainter oldDelegate) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
class _RSuperellipsePainter extends CustomPainter {
|
|
const _RSuperellipsePainter({required this.rsuperellipse, required Paint paint}) : _paint = paint;
|
|
|
|
final RSuperellipse rsuperellipse;
|
|
|
|
final Paint _paint;
|
|
|
|
@override
|
|
void paint(Canvas canvas, Size size) {
|
|
canvas.drawRSuperellipse(rsuperellipse, _paint);
|
|
}
|
|
|
|
@override
|
|
bool shouldRepaint(MyPainter oldDelegate) {
|
|
return true;
|
|
}
|
|
}
|