mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
425 lines
12 KiB
Dart
425 lines
12 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// This file is run as part of a reduced test set in CI on Mac and Windows
|
|
// machines.
|
|
@Tags(<String>['reduced-test-set'])
|
|
library;
|
|
|
|
import 'dart:ui' as ui;
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
|
|
|
|
import '../impeller_test_helpers.dart';
|
|
|
|
void main() {
|
|
testWidgets('SnapshotWidget can rasterize child', (WidgetTester tester) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
final Key key = UniqueKey();
|
|
|
|
await tester.pumpWidget(
|
|
RepaintBoundary(
|
|
key: key,
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
child: Container(width: 100, height: 100, color: const Color(0xFFAABB11)),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
await expectLater(find.byKey(key), matchesGoldenFile('raster_widget.yellow.png'));
|
|
|
|
// Now change the color and assert the old snapshot still matches.
|
|
await tester.pumpWidget(
|
|
RepaintBoundary(
|
|
key: key,
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
child: Container(width: 100, height: 100, color: const Color(0xFFAA0000)),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
await expectLater(find.byKey(key), matchesGoldenFile('raster_widget.yellow.png'));
|
|
|
|
// Now invoke clear and the raster is re-generated.
|
|
controller.clear();
|
|
await tester.pump();
|
|
|
|
await expectLater(find.byKey(key), matchesGoldenFile('raster_widget.red.png'));
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('Changing devicePixelRatio does not repaint if snapshotting is not enabled', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final controller = SnapshotController();
|
|
addTearDown(controller.dispose);
|
|
final painter = TestPainter();
|
|
addTearDown(painter.dispose);
|
|
var devicePixelRatio = 1.0;
|
|
late StateSetter localSetState;
|
|
|
|
await tester.pumpWidget(
|
|
StatefulBuilder(
|
|
builder: (BuildContext context, StateSetter setState) {
|
|
localSetState = setState;
|
|
return Center(
|
|
child: TestDependencies(
|
|
devicePixelRatio: devicePixelRatio,
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
painter: painter,
|
|
child: const SizedBox(width: 100, height: 100),
|
|
),
|
|
),
|
|
);
|
|
},
|
|
),
|
|
);
|
|
|
|
expect(painter.count, 1);
|
|
|
|
localSetState(() {
|
|
devicePixelRatio = 2.0;
|
|
});
|
|
await tester.pump();
|
|
|
|
// Not repainted as dpr was not used.
|
|
expect(painter.count, 1);
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('Changing devicePixelRatio forces raster regeneration', (WidgetTester tester) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
final painter = TestPainter();
|
|
addTearDown(painter.dispose);
|
|
var devicePixelRatio = 1.0;
|
|
late StateSetter localSetState;
|
|
|
|
await tester.pumpWidget(
|
|
StatefulBuilder(
|
|
builder: (BuildContext context, StateSetter setState) {
|
|
localSetState = setState;
|
|
return Center(
|
|
child: TestDependencies(
|
|
devicePixelRatio: devicePixelRatio,
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
painter: painter,
|
|
child: const SizedBox(width: 100, height: 100),
|
|
),
|
|
),
|
|
);
|
|
},
|
|
),
|
|
);
|
|
final ui.Image? raster = painter.lastImage;
|
|
|
|
expect(raster, isNotNull);
|
|
expect(painter.count, 1);
|
|
|
|
localSetState(() {
|
|
devicePixelRatio = 2.0;
|
|
});
|
|
await tester.pump();
|
|
|
|
final ui.Image? newRaster = painter.lastImage;
|
|
|
|
expect(painter.count, 2);
|
|
expect(raster, isNot(newRaster));
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('SnapshotWidget paints its child as a single picture layer', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
RepaintBoundary(
|
|
child: Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
child: Container(width: 100, height: 100, color: const Color(0xFFAABB11)),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.layers, hasLength(3));
|
|
expect(tester.layers.last, isA<PictureLayer>());
|
|
|
|
controller.allowSnapshotting = false;
|
|
await tester.pump();
|
|
|
|
expect(tester.layers, hasLength(3));
|
|
expect(tester.layers.last, isA<PictureLayer>());
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('SnapshotWidget can update the painter type', (WidgetTester tester) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
final painter1 = TestPainter();
|
|
addTearDown(painter1.dispose);
|
|
final painter2 = TestPainter2();
|
|
addTearDown(painter2.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(controller: controller, painter: painter1, child: const SizedBox()),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(controller: controller, painter: painter2, child: const SizedBox()),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.takeException(), isNull);
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('RenderSnapshotWidget does not error on rasterization of child with empty size', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(controller: controller, child: const SizedBox()),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.takeException(), isNull);
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('RenderSnapshotWidget throws assertion if platform view is encountered', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
child: const SizedBox(width: 100, height: 100, child: TestPlatformView()),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(
|
|
tester.takeException(),
|
|
isA<FlutterError>().having(
|
|
(FlutterError error) => error.message,
|
|
'message',
|
|
contains('SnapshotWidget used with a child that contains a PlatformView'),
|
|
),
|
|
);
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets('RenderSnapshotWidget does not assert if SnapshotMode.forced', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
mode: SnapshotMode.forced,
|
|
child: const SizedBox(width: 100, height: 100, child: TestPlatformView()),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.takeException(), isNull);
|
|
}, skip: kIsWeb); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
|
|
testWidgets(
|
|
'RenderSnapshotWidget does not take a snapshot if a platform view is encountered with SnapshotMode.permissive',
|
|
(WidgetTester tester) async {
|
|
final controller = SnapshotController(allowSnapshotting: true);
|
|
addTearDown(controller.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
Center(
|
|
child: TestDependencies(
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
mode: SnapshotMode.permissive,
|
|
child: const SizedBox(width: 100, height: 100, child: TestPlatformView()),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.takeException(), isNull);
|
|
expect(tester.layers.last, isA<PlatformViewLayer>());
|
|
},
|
|
skip: kIsWeb, // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
);
|
|
|
|
testWidgets(
|
|
'SnapshotWidget should have same result when enabled',
|
|
(WidgetTester tester) async {
|
|
addTearDown(tester.view.reset);
|
|
|
|
tester.view
|
|
..physicalSize = const Size(10, 10)
|
|
..devicePixelRatio = 1;
|
|
|
|
const repaintBoundaryKey = ValueKey<String>('boundary');
|
|
final controller = SnapshotController();
|
|
addTearDown(controller.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
RepaintBoundary(
|
|
key: repaintBoundaryKey,
|
|
child: MaterialApp(
|
|
debugShowCheckedModeBanner: false,
|
|
home: Container(
|
|
color: Colors.black,
|
|
padding: const EdgeInsets.only(right: 0.6, bottom: 0.6),
|
|
child: SnapshotWidget(
|
|
controller: controller,
|
|
child: Container(
|
|
margin: const EdgeInsets.only(right: 0.4, bottom: 0.4),
|
|
color: Colors.blue,
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final ui.Image imageWhenDisabled =
|
|
(tester.renderObject(find.byKey(repaintBoundaryKey)) as RenderRepaintBoundary)
|
|
.toImageSync();
|
|
addTearDown(imageWhenDisabled.dispose);
|
|
|
|
controller.allowSnapshotting = true;
|
|
await tester.pump();
|
|
|
|
await expectLater(find.byKey(repaintBoundaryKey), matchesReferenceImage(imageWhenDisabled));
|
|
},
|
|
// TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
|
|
skip: kIsWeb || impellerEnabled,
|
|
);
|
|
|
|
test('SnapshotPainter dispatches memory events', () async {
|
|
await expectLater(
|
|
await memoryEvents(() => TestPainter().dispose(), TestPainter),
|
|
areCreateAndDispose,
|
|
);
|
|
});
|
|
}
|
|
|
|
class TestPlatformView extends SingleChildRenderObjectWidget {
|
|
const TestPlatformView({super.key});
|
|
|
|
@override
|
|
RenderObject createRenderObject(BuildContext context) {
|
|
return RenderTestPlatformView();
|
|
}
|
|
}
|
|
|
|
class RenderTestPlatformView extends RenderProxyBox {
|
|
@override
|
|
void paint(PaintingContext context, ui.Offset offset) {
|
|
context.addLayer(PlatformViewLayer(rect: offset & size, viewId: 1));
|
|
}
|
|
}
|
|
|
|
class TestPainter extends SnapshotPainter {
|
|
int count = 0;
|
|
bool shouldRepaintValue = false;
|
|
ui.Image? lastImage;
|
|
|
|
int addedListenerCount = 0;
|
|
int removedListenerCount = 0;
|
|
|
|
@override
|
|
void addListener(ui.VoidCallback listener) {
|
|
addedListenerCount += 1;
|
|
super.addListener(listener);
|
|
}
|
|
|
|
@override
|
|
void removeListener(ui.VoidCallback listener) {
|
|
removedListenerCount += 1;
|
|
super.removeListener(listener);
|
|
}
|
|
|
|
@override
|
|
void paintSnapshot(
|
|
PaintingContext context,
|
|
Offset offset,
|
|
Size size,
|
|
ui.Image image,
|
|
Size sourceSize,
|
|
double pixelRatio,
|
|
) {
|
|
count += 1;
|
|
lastImage = image;
|
|
}
|
|
|
|
@override
|
|
void paint(
|
|
PaintingContext context,
|
|
ui.Offset offset,
|
|
ui.Size size,
|
|
PaintingContextCallback painter,
|
|
) {
|
|
count += 1;
|
|
}
|
|
|
|
@override
|
|
bool shouldRepaint(covariant TestPainter oldDelegate) => shouldRepaintValue;
|
|
}
|
|
|
|
class TestPainter2 extends TestPainter {
|
|
@override
|
|
bool shouldRepaint(covariant TestPainter2 oldDelegate) => shouldRepaintValue;
|
|
}
|
|
|
|
class TestDependencies extends StatelessWidget {
|
|
const TestDependencies({required this.child, super.key, this.devicePixelRatio});
|
|
|
|
final Widget child;
|
|
final double? devicePixelRatio;
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
return Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: MediaQuery(
|
|
data: const MediaQueryData().copyWith(devicePixelRatio: devicePixelRatio),
|
|
child: child,
|
|
),
|
|
);
|
|
}
|
|
}
|