mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
329 lines
11 KiB
Dart
329 lines
11 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void verifyPaintPosition(GlobalKey key, Offset ideal) {
|
|
final RenderObject target = key.currentContext!.findRenderObject()!;
|
|
expect(target.parent, isA<RenderViewport>());
|
|
final parentData = target.parentData! as SliverPhysicalParentData;
|
|
final Offset actual = parentData.paintOffset;
|
|
expect(actual, ideal);
|
|
}
|
|
|
|
void main() {
|
|
testWidgets('Sliver appbars - scrolling', (WidgetTester tester) async {
|
|
GlobalKey key1, key2, key3, key4, key5;
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
slivers: <Widget>[
|
|
BigSliver(key: key1 = GlobalKey()),
|
|
SliverPersistentHeader(key: key2 = GlobalKey(), delegate: TestDelegate()),
|
|
SliverPersistentHeader(key: key3 = GlobalKey(), delegate: TestDelegate()),
|
|
BigSliver(key: key4 = GlobalKey()),
|
|
BigSliver(key: key5 = GlobalKey()),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
final ScrollPosition position = tester.state<ScrollableState>(find.byType(Scrollable)).position;
|
|
final double max =
|
|
RenderBigSliver.height * 3.0 +
|
|
TestDelegate().maxExtent * 2.0 -
|
|
600.0; // 600 is the height of the test viewport
|
|
assert(max < 10000.0);
|
|
expect(max, 1450.0);
|
|
expect(position.pixels, 0.0);
|
|
expect(position.minScrollExtent, 0.0);
|
|
expect(position.maxScrollExtent, max);
|
|
position.animateTo(10000.0, curve: Curves.linear, duration: const Duration(minutes: 1));
|
|
await tester.pumpAndSettle(const Duration(milliseconds: 10));
|
|
expect(position.pixels, max);
|
|
expect(position.minScrollExtent, 0.0);
|
|
expect(position.maxScrollExtent, max);
|
|
verifyPaintPosition(key1, Offset.zero);
|
|
verifyPaintPosition(key2, Offset.zero);
|
|
verifyPaintPosition(key3, Offset.zero);
|
|
verifyPaintPosition(key4, Offset.zero);
|
|
verifyPaintPosition(key5, const Offset(0.0, 50.0));
|
|
});
|
|
|
|
testWidgets('Sliver appbars - scrolling off screen', (WidgetTester tester) async {
|
|
final GlobalKey key = GlobalKey();
|
|
final delegate = TestDelegate();
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
slivers: <Widget>[
|
|
const BigSliver(),
|
|
SliverPersistentHeader(key: key, delegate: delegate),
|
|
const BigSliver(),
|
|
const BigSliver(),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
final ScrollPosition position = tester.state<ScrollableState>(find.byType(Scrollable)).position;
|
|
position.animateTo(
|
|
RenderBigSliver.height + delegate.maxExtent - 5.0,
|
|
curve: Curves.linear,
|
|
duration: const Duration(minutes: 1),
|
|
);
|
|
await tester.pumpAndSettle(const Duration(milliseconds: 1000));
|
|
final RenderBox box = tester.renderObject<RenderBox>(find.text('Sliver App Bar'));
|
|
final rect = Rect.fromPoints(
|
|
box.localToGlobal(Offset.zero),
|
|
box.localToGlobal(box.size.bottomRight(Offset.zero)),
|
|
);
|
|
expect(rect, equals(const Rect.fromLTWH(0.0, -195.0, 800.0, 200.0)));
|
|
});
|
|
|
|
testWidgets('Sliver appbars - scrolling - overscroll gap is below header', (
|
|
WidgetTester tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
physics: const BouncingScrollPhysics(),
|
|
slivers: <Widget>[
|
|
SliverPersistentHeader(delegate: TestDelegate()),
|
|
SliverList.list(children: const <Widget>[SizedBox(height: 300.0, child: Text('X'))]),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.getTopLeft(find.text('Sliver App Bar')), Offset.zero);
|
|
expect(tester.getTopLeft(find.text('X')), const Offset(0.0, 200.0));
|
|
|
|
final ScrollPosition position = tester.state<ScrollableState>(find.byType(Scrollable)).position;
|
|
position.jumpTo(-50.0);
|
|
await tester.pump();
|
|
|
|
expect(tester.getTopLeft(find.text('Sliver App Bar')), Offset.zero);
|
|
expect(tester.getTopLeft(find.text('X')), const Offset(0.0, 250.0));
|
|
});
|
|
|
|
testWidgets('Sliver appbars const child delegate - scrolling - overscroll gap is below header', (
|
|
WidgetTester tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
physics: const BouncingScrollPhysics(),
|
|
slivers: <Widget>[
|
|
SliverPersistentHeader(delegate: TestDelegate()),
|
|
const SliverList(
|
|
delegate: SliverChildListDelegate.fixed(<Widget>[
|
|
SizedBox(height: 300.0, child: Text('X')),
|
|
]),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.getTopLeft(find.text('Sliver App Bar')), Offset.zero);
|
|
expect(tester.getTopLeft(find.text('X')), const Offset(0.0, 200.0));
|
|
|
|
final ScrollPosition position = tester.state<ScrollableState>(find.byType(Scrollable)).position;
|
|
position.jumpTo(-50.0);
|
|
await tester.pump();
|
|
|
|
expect(tester.getTopLeft(find.text('Sliver App Bar')), Offset.zero);
|
|
expect(tester.getTopLeft(find.text('X')), const Offset(0.0, 250.0));
|
|
});
|
|
|
|
group('has correct semantics when', () {
|
|
testWidgets('within viewport', (WidgetTester tester) async {
|
|
const double cacheExtent = 250;
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
cacheExtent: cacheExtent,
|
|
physics: const BouncingScrollPhysics(),
|
|
slivers: <Widget>[
|
|
SliverPersistentHeader(delegate: TestDelegate()),
|
|
const SliverList(
|
|
delegate: SliverChildListDelegate.fixed(<Widget>[
|
|
SizedBox(height: 300.0, child: Text('X')),
|
|
]),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
|
|
final SemanticsFinder sliverAppBar = find.semantics.byLabel('Sliver App Bar');
|
|
|
|
expect(sliverAppBar, findsOne);
|
|
expect(sliverAppBar, containsSemantics(isHidden: false));
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('partially scrolling off screen', (WidgetTester tester) async {
|
|
final GlobalKey key = GlobalKey();
|
|
final delegate = TestDelegate();
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
const double cacheExtent = 250;
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
cacheExtent: cacheExtent,
|
|
slivers: <Widget>[
|
|
SliverPersistentHeader(key: key, delegate: delegate),
|
|
const BigSliver(),
|
|
const BigSliver(),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
final ScrollPosition position = tester
|
|
.state<ScrollableState>(find.byType(Scrollable))
|
|
.position;
|
|
position.animateTo(
|
|
delegate.maxExtent - 20.0,
|
|
curve: Curves.linear,
|
|
duration: const Duration(minutes: 1),
|
|
);
|
|
await tester.pumpAndSettle(const Duration(milliseconds: 1000));
|
|
final RenderBox box = tester.renderObject<RenderBox>(find.text('Sliver App Bar'));
|
|
final rect = Rect.fromPoints(
|
|
box.localToGlobal(Offset.zero),
|
|
box.localToGlobal(box.size.bottomRight(Offset.zero)),
|
|
);
|
|
expect(rect, equals(const Rect.fromLTWH(0.0, -180.0, 800.0, 200.0)));
|
|
|
|
final SemanticsFinder sliverAppBar = find.semantics.byLabel('Sliver App Bar');
|
|
|
|
expect(sliverAppBar, findsOne);
|
|
expect(sliverAppBar, containsSemantics(isHidden: false));
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('completely scrolling off screen but within cache extent', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final GlobalKey key = GlobalKey();
|
|
final delegate = TestDelegate();
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
const double cacheExtent = 250;
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
cacheExtent: cacheExtent,
|
|
slivers: <Widget>[
|
|
SliverPersistentHeader(key: key, delegate: delegate),
|
|
const BigSliver(),
|
|
const BigSliver(),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
final ScrollPosition position = tester
|
|
.state<ScrollableState>(find.byType(Scrollable))
|
|
.position;
|
|
position.animateTo(
|
|
delegate.maxExtent + 20.0,
|
|
curve: Curves.linear,
|
|
duration: const Duration(minutes: 1),
|
|
);
|
|
await tester.pumpAndSettle(const Duration(milliseconds: 1000));
|
|
|
|
final SemanticsFinder sliverAppBar = find.semantics.byLabel('Sliver App Bar');
|
|
|
|
expect(sliverAppBar, findsOne);
|
|
expect(sliverAppBar, containsSemantics(isHidden: true));
|
|
handle.dispose();
|
|
});
|
|
|
|
testWidgets('completely scrolling off screen and not within cache extent', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final GlobalKey key = GlobalKey();
|
|
final delegate = TestDelegate();
|
|
final SemanticsHandle handle = tester.ensureSemantics();
|
|
const double cacheExtent = 250;
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
cacheExtent: cacheExtent,
|
|
slivers: <Widget>[
|
|
SliverPersistentHeader(key: key, delegate: delegate),
|
|
const BigSliver(),
|
|
const BigSliver(),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
final ScrollPosition position = tester
|
|
.state<ScrollableState>(find.byType(Scrollable))
|
|
.position;
|
|
position.animateTo(
|
|
delegate.maxExtent + 300.0,
|
|
curve: Curves.linear,
|
|
duration: const Duration(minutes: 1),
|
|
);
|
|
await tester.pumpAndSettle(const Duration(milliseconds: 1000));
|
|
|
|
final SemanticsFinder sliverAppBar = find.semantics.byLabel('Sliver App Bar');
|
|
|
|
expect(sliverAppBar, findsNothing);
|
|
handle.dispose();
|
|
});
|
|
});
|
|
}
|
|
|
|
class TestDelegate extends SliverPersistentHeaderDelegate {
|
|
@override
|
|
double get maxExtent => 200.0;
|
|
|
|
@override
|
|
double get minExtent => 200.0;
|
|
|
|
@override
|
|
Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) {
|
|
return SizedBox(height: maxExtent, child: const Text('Sliver App Bar'));
|
|
}
|
|
|
|
@override
|
|
bool shouldRebuild(TestDelegate oldDelegate) => false;
|
|
}
|
|
|
|
class RenderBigSliver extends RenderSliver {
|
|
static const double height = 550.0;
|
|
double get paintExtent =>
|
|
(height - constraints.scrollOffset).clamp(0.0, constraints.remainingPaintExtent);
|
|
|
|
@override
|
|
void performLayout() {
|
|
geometry = SliverGeometry(
|
|
scrollExtent: height,
|
|
paintExtent: paintExtent,
|
|
maxPaintExtent: height,
|
|
);
|
|
}
|
|
}
|
|
|
|
class BigSliver extends LeafRenderObjectWidget {
|
|
const BigSliver({super.key});
|
|
@override
|
|
RenderBigSliver createRenderObject(BuildContext context) {
|
|
return RenderBigSliver();
|
|
}
|
|
}
|