mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
bef11d207f
There is a lot of cross-library importing in the framework unit tests that I'd like to clean up, see the design doc for more: https://docs.google.com/document/d/1UHxALQqCbmgjnM1RNV9xE2pK3IGyx-UktGX1D7hYCjs/edit?tab=t.0 This PR cleans up a few obvious instances and adds TODOs for others. I created this while doing an investigation for the design doc linked above. I hope that we'll be able to follow up with fixes for all of the problematic tests (tracked in the issue below). Part of https://github.com/flutter/flutter/issues/177028
101 lines
2.6 KiB
Dart
101 lines
2.6 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'semantics_tester.dart';
|
|
|
|
void main() {
|
|
testWidgets('markNeedsSemanticsUpdate() called on non-boundary with non-boundary parent', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final semantics = SemanticsTester(tester);
|
|
|
|
await tester.pumpWidget(
|
|
Semantics(
|
|
container: true,
|
|
onTap: dummyTapHandler,
|
|
child: Semantics(
|
|
onTap: dummyTapHandler,
|
|
child: Semantics(onTap: dummyTapHandler, textDirection: TextDirection.ltr, label: 'foo'),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(
|
|
semantics,
|
|
hasSemantics(
|
|
TestSemantics.root(
|
|
children: <TestSemantics>[
|
|
TestSemantics.rootChild(
|
|
id: 1,
|
|
actions: SemanticsAction.tap.index,
|
|
children: <TestSemantics>[
|
|
TestSemantics(
|
|
id: 2,
|
|
actions: SemanticsAction.tap.index,
|
|
children: <TestSemantics>[
|
|
TestSemantics(id: 3, actions: SemanticsAction.tap.index, label: 'foo'),
|
|
],
|
|
),
|
|
],
|
|
),
|
|
],
|
|
),
|
|
ignoreRect: true,
|
|
ignoreTransform: true,
|
|
),
|
|
);
|
|
|
|
// make a change causing call to markNeedsSemanticsUpdate()
|
|
|
|
// This should not throw an assert.
|
|
await tester.pumpWidget(
|
|
Semantics(
|
|
container: true,
|
|
onTap: dummyTapHandler,
|
|
child: Semantics(
|
|
onTap: dummyTapHandler,
|
|
child: Semantics(
|
|
onTap: dummyTapHandler,
|
|
textDirection: TextDirection.ltr,
|
|
label: 'bar', // <-- only change
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(
|
|
semantics,
|
|
hasSemantics(
|
|
TestSemantics.root(
|
|
children: <TestSemantics>[
|
|
TestSemantics.rootChild(
|
|
id: 1,
|
|
actions: SemanticsAction.tap.index,
|
|
children: <TestSemantics>[
|
|
TestSemantics(
|
|
id: 2,
|
|
actions: SemanticsAction.tap.index,
|
|
children: <TestSemantics>[
|
|
TestSemantics(id: 3, actions: SemanticsAction.tap.index, label: 'bar'),
|
|
],
|
|
),
|
|
],
|
|
),
|
|
],
|
|
),
|
|
ignoreRect: true,
|
|
ignoreTransform: true,
|
|
),
|
|
);
|
|
|
|
semantics.dispose();
|
|
});
|
|
}
|
|
|
|
void dummyTapHandler() {}
|