mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
157 lines
4.2 KiB
Dart
157 lines
4.2 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
|
|
|
|
int _creations = 0;
|
|
int _disposals = 0;
|
|
|
|
void main() {
|
|
// LeakTesting is turned off because it adds subscriptions to
|
|
// [FlutterMemoryAllocations], that may interfere with the tests.
|
|
LeakTesting.settings = LeakTesting.settings.withIgnoredAll();
|
|
|
|
final FlutterMemoryAllocations ma = FlutterMemoryAllocations.instance;
|
|
|
|
test('Publishers dispatch events in debug mode', () async {
|
|
void listener(ObjectEvent event) {
|
|
if (event is ObjectDisposed) {
|
|
_disposals++;
|
|
}
|
|
if (event is ObjectCreated) {
|
|
_creations++;
|
|
}
|
|
}
|
|
|
|
ma.addListener(listener);
|
|
|
|
final _EventStats actual = await _activateFlutterObjectsAndReturnCountOfEvents();
|
|
expect(actual.creations, _creations);
|
|
expect(actual.disposals, _disposals);
|
|
|
|
ma.removeListener(listener);
|
|
expect(ma.hasListeners, isFalse);
|
|
});
|
|
|
|
testWidgets('State dispatches events in debug mode', (WidgetTester tester) async {
|
|
var stateCreated = false;
|
|
var stateDisposed = false;
|
|
|
|
expect(ma.hasListeners, false);
|
|
|
|
void listener(ObjectEvent event) {
|
|
if (event is ObjectCreated && event.object is State) {
|
|
stateCreated = true;
|
|
}
|
|
if (event is ObjectDisposed && event.object is State) {
|
|
stateDisposed = true;
|
|
}
|
|
}
|
|
|
|
ma.addListener(listener);
|
|
|
|
await tester.pumpWidget(const _TestStatefulWidget());
|
|
expect(stateCreated, isTrue);
|
|
expect(stateDisposed, isFalse);
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
|
|
expect(stateCreated, isTrue);
|
|
expect(stateDisposed, isTrue);
|
|
ma.removeListener(listener);
|
|
expect(ma.hasListeners, false);
|
|
});
|
|
}
|
|
|
|
class _TestLeafRenderObjectWidget extends LeafRenderObjectWidget {
|
|
@override
|
|
RenderObject createRenderObject(BuildContext context) {
|
|
return _TestRenderObject();
|
|
}
|
|
}
|
|
|
|
class _TestElement extends RenderObjectElement with RootElementMixin {
|
|
_TestElement() : super(_TestLeafRenderObjectWidget());
|
|
|
|
void makeInactive() {
|
|
final newFocusManager = FocusManager();
|
|
assignOwner(BuildOwner(focusManager: newFocusManager));
|
|
mount(null, null);
|
|
// ignore: invalid_use_of_visible_for_overriding_member
|
|
deactivate();
|
|
}
|
|
|
|
@override
|
|
void insertRenderObjectChild(covariant RenderObject child, covariant Object? slot) {}
|
|
|
|
@override
|
|
void moveRenderObjectChild(
|
|
covariant RenderObject child,
|
|
covariant Object? oldSlot,
|
|
covariant Object? newSlot,
|
|
) {}
|
|
|
|
@override
|
|
void removeRenderObjectChild(covariant RenderObject child, covariant Object? slot) {}
|
|
}
|
|
|
|
class _TestRenderObject extends RenderObject {
|
|
@override
|
|
void debugAssertDoesMeetConstraints() {}
|
|
|
|
@override
|
|
Rect get paintBounds => throw UnimplementedError();
|
|
|
|
@override
|
|
void performLayout() {}
|
|
|
|
@override
|
|
void performResize() {}
|
|
|
|
@override
|
|
Rect get semanticBounds => throw UnimplementedError();
|
|
}
|
|
|
|
class _TestStatefulWidget extends StatefulWidget {
|
|
const _TestStatefulWidget();
|
|
|
|
@override
|
|
State<_TestStatefulWidget> createState() => _TestStatefulWidgetState();
|
|
}
|
|
|
|
class _TestStatefulWidgetState extends State<_TestStatefulWidget> {
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
return Container();
|
|
}
|
|
}
|
|
|
|
class _EventStats {
|
|
int creations = 0;
|
|
int disposals = 0;
|
|
}
|
|
|
|
/// Create and dispose Flutter objects to fire memory allocation events.
|
|
Future<_EventStats> _activateFlutterObjectsAndReturnCountOfEvents() async {
|
|
final result = _EventStats();
|
|
|
|
final element = _TestElement();
|
|
result.creations++;
|
|
final RenderObject renderObject = _TestRenderObject();
|
|
result.creations++;
|
|
|
|
element.makeInactive();
|
|
result.creations +=
|
|
4; // 1 for the new BuildOwner, 1 for the new FocusManager, 1 for the new FocusScopeNode, 1 for the new _HighlightModeManager
|
|
// ignore: invalid_use_of_visible_for_overriding_member
|
|
element.unmount();
|
|
result.disposals += 2; // 1 for the old BuildOwner, 1 for the element
|
|
renderObject.dispose();
|
|
result.disposals += 1;
|
|
|
|
return result;
|
|
}
|