flutter_flutter/packages/flutter/test/widgets/layout_builder_mutations_test.dart
Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

231 lines
6.7 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';
import 'package:flutter/src/widgets/basic.dart';
import 'package:flutter/src/widgets/framework.dart';
import 'package:flutter/src/widgets/layout_builder.dart';
import 'package:flutter/src/widgets/media_query.dart';
import 'package:flutter/src/widgets/scroll_view.dart';
import 'package:flutter/src/widgets/sliver_layout_builder.dart';
import 'package:flutter_test/flutter_test.dart';
class Wrapper extends StatelessWidget {
const Wrapper({super.key, required this.child});
final Widget child;
@override
Widget build(BuildContext context) => child;
}
void main() {
testWidgets('Moving a global key from another LayoutBuilder at layout time', (
WidgetTester tester,
) async {
final GlobalKey victimKey = GlobalKey();
await tester.pumpWidget(
Row(
textDirection: TextDirection.ltr,
children: <Widget>[
Wrapper(
child: LayoutBuilder(
builder: (BuildContext context, BoxConstraints constraints) {
return const SizedBox();
},
),
),
Wrapper(
child: Wrapper(
child: LayoutBuilder(
builder: (BuildContext context, BoxConstraints constraints) {
return Wrapper(child: SizedBox(key: victimKey));
},
),
),
),
],
),
);
await tester.pumpWidget(
Row(
textDirection: TextDirection.ltr,
children: <Widget>[
Wrapper(
child: LayoutBuilder(
builder: (BuildContext context, BoxConstraints constraints) {
return Wrapper(child: SizedBox(key: victimKey));
},
),
),
Wrapper(
child: Wrapper(
child: LayoutBuilder(
builder: (BuildContext context, BoxConstraints constraints) {
return const SizedBox();
},
),
),
),
],
),
);
expect(tester.takeException(), null);
});
testWidgets('Moving a global key from another SliverLayoutBuilder at layout time', (
WidgetTester tester,
) async {
final GlobalKey victimKey1 = GlobalKey();
final GlobalKey victimKey2 = GlobalKey();
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: CustomScrollView(
slivers: <Widget>[
SliverLayoutBuilder(
builder: (BuildContext context, SliverConstraints constraint) {
return SliverPadding(
key: victimKey1,
padding: const EdgeInsets.fromLTRB(1, 2, 3, 4),
);
},
),
SliverLayoutBuilder(
builder: (BuildContext context, SliverConstraints constraint) {
return SliverPadding(
key: victimKey2,
padding: const EdgeInsets.fromLTRB(5, 7, 11, 13),
);
},
),
SliverLayoutBuilder(
builder: (BuildContext context, SliverConstraints constraint) {
return const SliverPadding(padding: EdgeInsets.fromLTRB(5, 7, 11, 13));
},
),
],
),
),
);
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: CustomScrollView(
slivers: <Widget>[
SliverLayoutBuilder(
builder: (BuildContext context, SliverConstraints constraint) {
return SliverPadding(
key: victimKey2,
padding: const EdgeInsets.fromLTRB(1, 2, 3, 4),
);
},
),
SliverLayoutBuilder(
builder: (BuildContext context, SliverConstraints constraint) {
return const SliverPadding(padding: EdgeInsets.fromLTRB(5, 7, 11, 13));
},
),
SliverLayoutBuilder(
builder: (BuildContext context, SliverConstraints constraint) {
return SliverPadding(
key: victimKey1,
padding: const EdgeInsets.fromLTRB(5, 7, 11, 13),
);
},
),
],
),
),
);
expect(tester.takeException(), null);
});
testWidgets('LayoutBuilder does not layout twice', (WidgetTester tester) async {
// This widget marks itself dirty when the closest MediaQuery changes.
final widget = _LayoutCount();
late StateSetter setState;
var updated = false;
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: StatefulBuilder(
builder: (BuildContext context, StateSetter setter) {
setState = setter;
return MediaQuery(
data: updated
? const MediaQueryData(platformBrightness: Brightness.dark)
: const MediaQueryData(),
child: LayoutBuilder(
builder: (BuildContext context, BoxConstraints constraints) {
return Center(
child: SizedBox.square(
dimension: 20,
child: Center(
child: SizedBox.square(dimension: updated ? 10 : 20, child: widget),
),
),
);
},
),
);
},
),
),
);
assert(widget._renderObject.layoutCount == 1);
setState(() {
updated = true;
});
await tester.pump();
expect(widget._renderObject.layoutCount, 2);
});
}
class _LayoutCount extends LeafRenderObjectWidget {
late final _RenderLayoutCount _renderObject;
@override
RenderObject createRenderObject(BuildContext context) {
return _renderObject = _RenderLayoutCount(MediaQuery.of(context));
}
@override
void updateRenderObject(BuildContext context, _RenderLayoutCount renderObject) {
renderObject.mediaQuery = MediaQuery.of(context);
}
}
class _RenderLayoutCount extends RenderProxyBox {
_RenderLayoutCount(this._mediaQuery);
int layoutCount = 0;
MediaQueryData get mediaQuery => _mediaQuery;
MediaQueryData _mediaQuery;
set mediaQuery(MediaQueryData newValue) {
if (newValue != _mediaQuery) {
_mediaQuery = newValue;
markNeedsLayout();
}
}
@override
bool get sizedByParent => true;
@override
void performLayout() {
layoutCount += 1;
}
}