mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
253 lines
9.0 KiB
Dart
253 lines
9.0 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
class TestRoute extends PageRouteBuilder<void> {
|
|
TestRoute(Widget child)
|
|
: super(pageBuilder: (BuildContext _, Animation<double> _, Animation<double> _) => child);
|
|
}
|
|
|
|
class IconTextBox extends StatelessWidget {
|
|
const IconTextBox(this.text, {super.key});
|
|
final String text;
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
return Container(
|
|
alignment: Alignment.center,
|
|
child: Row(
|
|
children: <Widget>[
|
|
const Icon(IconData(0x41, fontFamily: 'Roboto')),
|
|
Text(text),
|
|
],
|
|
),
|
|
);
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
testWidgets('InheritedTheme.captureAll()', (WidgetTester tester) async {
|
|
const double fontSize = 32;
|
|
const double iconSize = 48;
|
|
const textColor = Color(0xFF00FF00);
|
|
const iconColor = Color(0xFF0000FF);
|
|
var useCaptureAll = false;
|
|
late BuildContext navigatorContext;
|
|
|
|
Widget buildFrame() {
|
|
return WidgetsApp(
|
|
color: const Color(0xFFFFFFFF),
|
|
onGenerateRoute: (RouteSettings settings) {
|
|
return TestRoute(
|
|
// The outer DefaultTextStyle and IconTheme widgets must have
|
|
// no effect on the test because InheritedTheme.captureAll()
|
|
// is required to only save the closest InheritedTheme ancestors.
|
|
DefaultTextStyle(
|
|
style: const TextStyle(fontSize: iconSize, color: iconColor),
|
|
child: IconTheme(
|
|
data: const IconThemeData(size: fontSize, color: textColor),
|
|
// The inner DefaultTextStyle and IconTheme widgets define
|
|
// InheritedThemes that captureAll() will wrap() around
|
|
// TestRoute's IconTextBox child.
|
|
child: DefaultTextStyle(
|
|
style: const TextStyle(fontSize: fontSize, color: textColor),
|
|
child: IconTheme(
|
|
data: const IconThemeData(size: iconSize, color: iconColor),
|
|
child: Builder(
|
|
builder: (BuildContext context) {
|
|
return GestureDetector(
|
|
behavior: HitTestBehavior.opaque,
|
|
onTap: () {
|
|
navigatorContext = context;
|
|
Navigator.of(context).push(
|
|
TestRoute(
|
|
useCaptureAll
|
|
? InheritedTheme.captureAll(context, const IconTextBox('Hello'))
|
|
: const IconTextBox('Hello'),
|
|
),
|
|
);
|
|
},
|
|
child: const IconTextBox('Tap'),
|
|
);
|
|
},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
},
|
|
);
|
|
}
|
|
|
|
TextStyle getIconStyle() {
|
|
return tester
|
|
.widget<RichText>(find.descendant(of: find.byType(Icon), matching: find.byType(RichText)))
|
|
.text
|
|
.style!;
|
|
}
|
|
|
|
TextStyle getTextStyle(String text) {
|
|
return tester
|
|
.widget<RichText>(find.descendant(of: find.text(text), matching: find.byType(RichText)))
|
|
.text
|
|
.style!;
|
|
}
|
|
|
|
useCaptureAll = false;
|
|
await tester.pumpWidget(buildFrame());
|
|
expect(find.text('Tap'), findsOneWidget);
|
|
expect(find.text('Hello'), findsNothing);
|
|
expect(getTextStyle('Tap').color, textColor);
|
|
expect(getTextStyle('Tap').fontSize, fontSize);
|
|
expect(getIconStyle().color, iconColor);
|
|
expect(getIconStyle().fontSize, iconSize);
|
|
|
|
// Tap to show the TestRoute
|
|
await tester.tap(find.text('Tap'));
|
|
await tester.pumpAndSettle(); // route transition
|
|
expect(find.text('Tap'), findsNothing);
|
|
expect(find.text('Hello'), findsOneWidget);
|
|
// The new route's text and icons will NOT inherit the DefaultTextStyle or
|
|
// IconTheme values.
|
|
expect(getTextStyle('Hello').color, isNot(textColor));
|
|
expect(getTextStyle('Hello').fontSize, isNot(fontSize));
|
|
expect(getIconStyle().color, isNot(iconColor));
|
|
expect(getIconStyle().fontSize, isNot(iconSize));
|
|
|
|
// Return to the home route
|
|
useCaptureAll = true;
|
|
Navigator.of(navigatorContext).pop();
|
|
await tester.pumpAndSettle(); // route transition
|
|
|
|
// Verify that all is the same as it was when the test started
|
|
expect(find.text('Tap'), findsOneWidget);
|
|
expect(find.text('Hello'), findsNothing);
|
|
expect(getTextStyle('Tap').color, textColor);
|
|
expect(getTextStyle('Tap').fontSize, fontSize);
|
|
expect(getIconStyle().color, iconColor);
|
|
expect(getIconStyle().fontSize, iconSize);
|
|
|
|
// Tap to show the TestRoute. The test route's IconTextBox will have been
|
|
// wrapped with InheritedTheme.captureAll().
|
|
await tester.tap(find.text('Tap'));
|
|
await tester.pumpAndSettle(); // route transition
|
|
expect(find.text('Tap'), findsNothing);
|
|
expect(find.text('Hello'), findsOneWidget);
|
|
// The new route's text and icons will inherit the DefaultTextStyle or
|
|
// IconTheme values because captureAll.
|
|
expect(getTextStyle('Hello').color, textColor);
|
|
expect(getTextStyle('Hello').fontSize, fontSize);
|
|
expect(getIconStyle().color, iconColor);
|
|
expect(getIconStyle().fontSize, iconSize);
|
|
});
|
|
|
|
testWidgets('InheritedTheme.captureAll() multiple IconTheme ancestors', (
|
|
WidgetTester tester,
|
|
) async {
|
|
// This is a regression test for https://github.com/flutter/flutter/issues/39087
|
|
|
|
const outerColor = Color(0xFF0000FF);
|
|
const innerColor = Color(0xFF00FF00);
|
|
const double iconSize = 48;
|
|
final Key icon1 = UniqueKey();
|
|
final Key icon2 = UniqueKey();
|
|
|
|
await tester.pumpWidget(
|
|
WidgetsApp(
|
|
color: const Color(0xFFFFFFFF),
|
|
onGenerateRoute: (RouteSettings settings) {
|
|
return TestRoute(
|
|
IconTheme(
|
|
data: const IconThemeData(color: outerColor),
|
|
child: IconTheme(
|
|
data: const IconThemeData(size: iconSize, color: innerColor),
|
|
child: Center(
|
|
child: Row(
|
|
mainAxisSize: MainAxisSize.min,
|
|
children: <Widget>[
|
|
Icon(const IconData(0x41, fontFamily: 'Roboto'), key: icon1),
|
|
Builder(
|
|
builder: (BuildContext context) {
|
|
// The same IconThemes are visible from this context
|
|
// and the context that the widget returned by captureAll()
|
|
// is built in. So only the inner green IconTheme should
|
|
// apply to the icon, i.e. both icons will be big and green.
|
|
return InheritedTheme.captureAll(
|
|
context,
|
|
Icon(const IconData(0x41, fontFamily: 'Roboto'), key: icon2),
|
|
);
|
|
},
|
|
),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
},
|
|
),
|
|
);
|
|
|
|
TextStyle getIconStyle(Key key) {
|
|
return tester
|
|
.widget<RichText>(find.descendant(of: find.byKey(key), matching: find.byType(RichText)))
|
|
.text
|
|
.style!;
|
|
}
|
|
|
|
expect(getIconStyle(icon1).color, innerColor);
|
|
expect(getIconStyle(icon1).fontSize, iconSize);
|
|
expect(getIconStyle(icon2).color, innerColor);
|
|
expect(getIconStyle(icon2).fontSize, iconSize);
|
|
});
|
|
|
|
testWidgets('InheritedTheme.captureAll() multiple DefaultTextStyle ancestors', (
|
|
WidgetTester tester,
|
|
) async {
|
|
// This is a regression test for https://github.com/flutter/flutter/issues/39087
|
|
|
|
const textColor = Color(0xFF00FF00);
|
|
|
|
await tester.pumpWidget(
|
|
WidgetsApp(
|
|
color: const Color(0xFFFFFFFF),
|
|
onGenerateRoute: (RouteSettings settings) {
|
|
return TestRoute(
|
|
DefaultTextStyle(
|
|
style: const TextStyle(fontSize: 48),
|
|
child: DefaultTextStyle(
|
|
style: const TextStyle(color: textColor),
|
|
child: Row(
|
|
children: <Widget>[
|
|
const Text('Hello'),
|
|
Builder(
|
|
builder: (BuildContext context) {
|
|
return InheritedTheme.captureAll(context, const Text('World'));
|
|
},
|
|
),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
);
|
|
},
|
|
),
|
|
);
|
|
|
|
TextStyle getTextStyle(String text) {
|
|
return tester
|
|
.widget<RichText>(find.descendant(of: find.text(text), matching: find.byType(RichText)))
|
|
.text
|
|
.style!;
|
|
}
|
|
|
|
expect(getTextStyle('Hello').fontSize, null);
|
|
expect(getTextStyle('Hello').color, textColor);
|
|
expect(getTextStyle('World').fontSize, null);
|
|
expect(getTextStyle('World').color, textColor);
|
|
});
|
|
}
|