mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
293 lines
9.9 KiB
Dart
293 lines
9.9 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:convert';
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/painting.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
class TestAssetBundle extends CachingAssetBundle {
|
|
Map<String, int> loadCallCount = <String, int>{};
|
|
|
|
@override
|
|
Future<ByteData> load(String key) async {
|
|
loadCallCount[key] = (loadCallCount[key] ?? 0) + 1;
|
|
if (key == 'AssetManifest.json') {
|
|
return ByteData.sublistView(utf8.encode('{"one": ["one"]}'));
|
|
}
|
|
|
|
if (key == 'AssetManifest.bin') {
|
|
return const StandardMessageCodec().encodeMessage(<String, Object>{'one': <Object>[]})!;
|
|
}
|
|
|
|
if (key == 'AssetManifest.bin.json') {
|
|
// Encode the manifest data that will be used by the app
|
|
final ByteData data = const StandardMessageCodec().encodeMessage(<String, Object>{
|
|
'one': <Object>[],
|
|
})!;
|
|
// Simulate the behavior of NetworkAssetBundle.load here, for web tests
|
|
return ByteData.sublistView(
|
|
utf8.encode(
|
|
json.encode(
|
|
base64.encode(
|
|
// Encode only the actual bytes of the buffer, and no more...
|
|
data.buffer.asUint8List(data.offsetInBytes, data.lengthInBytes),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
}
|
|
|
|
if (key == 'counter') {
|
|
return ByteData.sublistView(utf8.encode(loadCallCount[key]!.toString()));
|
|
}
|
|
|
|
if (key == 'one') {
|
|
return ByteData(1)..setInt8(0, 49);
|
|
}
|
|
|
|
throw FlutterError('key not found');
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
TestWidgetsFlutterBinding.ensureInitialized();
|
|
|
|
test('Caching asset bundle test', () async {
|
|
final bundle = TestAssetBundle();
|
|
|
|
final ByteData assetData = await bundle.load('one');
|
|
expect(assetData.getInt8(0), equals(49));
|
|
|
|
expect(bundle.loadCallCount['one'], 1);
|
|
|
|
final String assetString = await bundle.loadString('one');
|
|
expect(assetString, equals('1'));
|
|
|
|
expect(bundle.loadCallCount['one'], 2);
|
|
|
|
late Object loadException;
|
|
try {
|
|
await bundle.loadString('foo');
|
|
} catch (e) {
|
|
loadException = e;
|
|
}
|
|
expect(loadException, isFlutterError);
|
|
});
|
|
|
|
group('CachingAssetBundle caching behavior', () {
|
|
test(
|
|
'caches results for loadString, loadStructuredData, and loadBinaryStructuredData',
|
|
() async {
|
|
final bundle = TestAssetBundle();
|
|
|
|
final String firstLoadStringResult = await bundle.loadString('counter');
|
|
final String secondLoadStringResult = await bundle.loadString('counter');
|
|
expect(firstLoadStringResult, '1');
|
|
expect(secondLoadStringResult, '1');
|
|
|
|
final String firstLoadStructuredDataResult = await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.value('one'),
|
|
);
|
|
final String secondLoadStructuredDataResult = await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.value('two'),
|
|
);
|
|
expect(firstLoadStructuredDataResult, 'one');
|
|
expect(secondLoadStructuredDataResult, 'one');
|
|
|
|
final String firstLoadStructuredBinaryDataResult = await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.value('one'),
|
|
);
|
|
final String secondLoadStructuredBinaryDataResult = await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.value('two'),
|
|
);
|
|
expect(firstLoadStructuredBinaryDataResult, 'one');
|
|
expect(secondLoadStructuredBinaryDataResult, 'one');
|
|
},
|
|
);
|
|
|
|
test("clear clears all cached values'", () async {
|
|
final bundle = TestAssetBundle();
|
|
|
|
await bundle.loadString('counter');
|
|
bundle.clear();
|
|
final String secondLoadStringResult = await bundle.loadString('counter');
|
|
expect(secondLoadStringResult, '2');
|
|
|
|
await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.value('one'),
|
|
);
|
|
bundle.clear();
|
|
final String secondLoadStructuredDataResult = await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.value('two'),
|
|
);
|
|
expect(secondLoadStructuredDataResult, 'two');
|
|
|
|
await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.value('one'),
|
|
);
|
|
bundle.clear();
|
|
final String secondLoadStructuredBinaryDataResult = await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.value('two'),
|
|
);
|
|
expect(secondLoadStructuredBinaryDataResult, 'two');
|
|
});
|
|
|
|
test('evict evicts a particular key from the cache', () async {
|
|
final bundle = TestAssetBundle();
|
|
|
|
await bundle.loadString('counter');
|
|
bundle.evict('counter');
|
|
final String secondLoadStringResult = await bundle.loadString('counter');
|
|
expect(secondLoadStringResult, '2');
|
|
|
|
await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.value('one'),
|
|
);
|
|
bundle.evict('AssetManifest.json');
|
|
final String secondLoadStructuredDataResult = await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.value('two'),
|
|
);
|
|
expect(secondLoadStructuredDataResult, 'two');
|
|
|
|
await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.value('one'),
|
|
);
|
|
bundle.evict('AssetManifest.bin');
|
|
final String secondLoadStructuredBinaryDataResult = await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.value('two'),
|
|
);
|
|
expect(secondLoadStructuredBinaryDataResult, 'two');
|
|
});
|
|
|
|
test(
|
|
'for a given key, subsequent loadStructuredData calls are synchronous after the first call resolves',
|
|
() async {
|
|
final bundle = TestAssetBundle();
|
|
await bundle.loadStructuredData('one', (String data) => SynchronousFuture<int>(1));
|
|
final Future<int> data = bundle.loadStructuredData(
|
|
'one',
|
|
(String data) => SynchronousFuture<int>(2),
|
|
);
|
|
expect(data, isA<SynchronousFuture<int>>());
|
|
expect(await data, 1);
|
|
},
|
|
);
|
|
|
|
test(
|
|
'for a given key, subsequent loadStructuredBinaryData calls are synchronous after the first call resolves',
|
|
() async {
|
|
final bundle = TestAssetBundle();
|
|
await bundle.loadStructuredBinaryData('one', (ByteData data) => 1);
|
|
final Future<int> data = bundle.loadStructuredBinaryData('one', (ByteData data) => 2);
|
|
expect(data, isA<SynchronousFuture<int>>());
|
|
expect(await data, 1);
|
|
},
|
|
);
|
|
|
|
testWidgets('loadStructuredData handles exceptions correctly', (WidgetTester tester) async {
|
|
final bundle = TestAssetBundle();
|
|
try {
|
|
await bundle.loadStructuredData(
|
|
'AssetManifest.json',
|
|
(String value) => Future<String>.error('what do they say?'),
|
|
);
|
|
fail('expected exception did not happen');
|
|
} catch (e) {
|
|
expect(e.toString(), contains('what do they say?'));
|
|
}
|
|
});
|
|
|
|
testWidgets('loadStructuredBinaryData handles exceptions correctly', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final bundle = TestAssetBundle();
|
|
try {
|
|
await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData value) => Future<String>.error('buy more crystals'),
|
|
);
|
|
fail('expected exception did not happen');
|
|
} catch (e) {
|
|
expect(e.toString(), contains('buy more crystals'));
|
|
}
|
|
});
|
|
});
|
|
|
|
test('AssetImage.obtainKey succeeds with ImageConfiguration.empty', () async {
|
|
// This is a regression test for https://github.com/flutter/flutter/issues/12392
|
|
final assetImage = AssetImage('one', bundle: TestAssetBundle());
|
|
final AssetBundleImageKey key = await assetImage.obtainKey(ImageConfiguration.empty);
|
|
expect(key.name, 'one');
|
|
expect(key.scale, 1.0);
|
|
});
|
|
|
|
test('NetworkAssetBundle control test', () async {
|
|
final uri = Uri.http('example.org', '/path');
|
|
final bundle = NetworkAssetBundle(uri);
|
|
late FlutterError error;
|
|
try {
|
|
await bundle.load('key');
|
|
} on FlutterError catch (e) {
|
|
error = e;
|
|
}
|
|
expect(error, isNotNull);
|
|
expect(error.diagnostics.length, 2);
|
|
expect(error.diagnostics.last, isA<IntProperty>());
|
|
expect(
|
|
error.toStringDeep(),
|
|
'FlutterError\n'
|
|
' Unable to load asset: "key".\n'
|
|
' HTTP status code: 400\n',
|
|
);
|
|
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/39998
|
|
|
|
test('toString works as intended', () {
|
|
final uri = Uri.http('example.org', '/path');
|
|
final bundle = NetworkAssetBundle(uri);
|
|
|
|
expect(bundle.toString(), 'NetworkAssetBundle#${shortHash(bundle)}($uri)');
|
|
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/39998
|
|
|
|
test('Throws expected exceptions when loading not exists asset', () async {
|
|
late final FlutterError error;
|
|
try {
|
|
await rootBundle.load('not-exists');
|
|
} on FlutterError catch (e) {
|
|
error = e;
|
|
}
|
|
expect(
|
|
error.message,
|
|
equals(
|
|
'Unable to load asset: "not-exists".\n'
|
|
'The asset does not exist or has empty data.',
|
|
),
|
|
);
|
|
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/56314
|
|
|
|
test('loadStructuredBinaryData correctly loads ByteData', () async {
|
|
final bundle = TestAssetBundle();
|
|
final Map<Object?, Object?> assetManifest = await bundle.loadStructuredBinaryData(
|
|
'AssetManifest.bin',
|
|
(ByteData data) => const StandardMessageCodec().decodeMessage(data) as Map<Object?, Object?>,
|
|
);
|
|
expect(assetManifest.keys.toList(), equals(<String>['one']));
|
|
expect(assetManifest['one'], <Object>[]);
|
|
});
|
|
}
|