mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
138 lines
3.8 KiB
Dart
138 lines
3.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'rendering_tester.dart';
|
|
|
|
class RenderFixedSize extends RenderBox {
|
|
double dimension = 100.0;
|
|
|
|
void grow() {
|
|
dimension *= 2.0;
|
|
markNeedsLayout();
|
|
}
|
|
|
|
@override
|
|
double computeMinIntrinsicWidth(double height) => dimension;
|
|
@override
|
|
double computeMaxIntrinsicWidth(double height) => dimension;
|
|
@override
|
|
double computeMinIntrinsicHeight(double width) => dimension;
|
|
@override
|
|
double computeMaxIntrinsicHeight(double width) => dimension;
|
|
|
|
@override
|
|
void performLayout() {
|
|
size = Size.square(dimension);
|
|
}
|
|
}
|
|
|
|
class RenderParentSize extends RenderProxyBox {
|
|
RenderParentSize({required RenderBox child}) : super(child);
|
|
|
|
@override
|
|
bool get sizedByParent => true;
|
|
|
|
@override
|
|
void performResize() {
|
|
size = constraints.biggest;
|
|
}
|
|
|
|
@override
|
|
void performLayout() {
|
|
child!.layout(constraints);
|
|
}
|
|
}
|
|
|
|
class RenderIntrinsicSize extends RenderProxyBox {
|
|
RenderIntrinsicSize({required RenderBox child}) : super(child);
|
|
|
|
@override
|
|
void performLayout() {
|
|
child!.layout(constraints);
|
|
size = Size(
|
|
child!.getMinIntrinsicWidth(double.infinity),
|
|
child!.getMinIntrinsicHeight(double.infinity),
|
|
);
|
|
}
|
|
}
|
|
|
|
class RenderInvalidIntrinsics extends RenderBox {
|
|
@override
|
|
bool get sizedByParent => true;
|
|
@override
|
|
double computeMinIntrinsicWidth(double height) => -1;
|
|
@override
|
|
double computeMaxIntrinsicWidth(double height) => -1;
|
|
@override
|
|
double computeMinIntrinsicHeight(double width) => -1;
|
|
@override
|
|
double computeMaxIntrinsicHeight(double width) => -1;
|
|
@override
|
|
Size computeDryLayout(BoxConstraints constraints) => Size.zero;
|
|
}
|
|
|
|
void main() {
|
|
TestRenderingFlutterBinding.ensureInitialized();
|
|
|
|
test('Whether using intrinsics means you get hooked into layout', () {
|
|
RenderBox root;
|
|
RenderFixedSize inner;
|
|
layout(
|
|
root = RenderIntrinsicSize(child: RenderParentSize(child: inner = RenderFixedSize())),
|
|
constraints: const BoxConstraints(maxWidth: 1000.0, maxHeight: 1000.0),
|
|
);
|
|
expect(root.size, equals(inner.size));
|
|
|
|
inner.grow();
|
|
pumpFrame();
|
|
expect(root.size, equals(inner.size));
|
|
});
|
|
|
|
test('Parent returns correct intrinsics', () {
|
|
RenderParentSize parent;
|
|
RenderFixedSize inner;
|
|
|
|
layout(
|
|
RenderIntrinsicSize(child: parent = RenderParentSize(child: inner = RenderFixedSize())),
|
|
constraints: const BoxConstraints(maxWidth: 1000.0, maxHeight: 1000.0),
|
|
);
|
|
|
|
_expectIntrinsicDimensions(parent, 100);
|
|
|
|
inner.grow();
|
|
pumpFrame();
|
|
|
|
_expectIntrinsicDimensions(parent, 200);
|
|
});
|
|
|
|
test('Intrinsic checks are turned on', () async {
|
|
final errorDetails = <FlutterErrorDetails>[];
|
|
layout(
|
|
RenderInvalidIntrinsics(),
|
|
constraints: const BoxConstraints(maxWidth: 1000.0, maxHeight: 1000.0),
|
|
onErrors: () {
|
|
errorDetails.addAll(TestRenderingFlutterBinding.instance.takeAllFlutterErrorDetails());
|
|
},
|
|
);
|
|
|
|
expect(errorDetails, isNotEmpty);
|
|
expect(
|
|
errorDetails.map((FlutterErrorDetails details) => details.toString()),
|
|
everyElement(contains('violate the intrinsic protocol')),
|
|
);
|
|
});
|
|
}
|
|
|
|
/// Asserts that all unbounded intrinsic dimensions for [object] match
|
|
/// [dimension].
|
|
void _expectIntrinsicDimensions(RenderBox object, double dimension) {
|
|
expect(object.getMinIntrinsicWidth(double.infinity), equals(dimension));
|
|
expect(object.getMaxIntrinsicWidth(double.infinity), equals(dimension));
|
|
expect(object.getMinIntrinsicHeight(double.infinity), equals(dimension));
|
|
expect(object.getMaxIntrinsicHeight(double.infinity), equals(dimension));
|
|
}
|