mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Bumps the Dart version to 3.8 across the repo (excluding engine/src/flutter/third_party) and applies formatting updates from Dart 3.8. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
171 lines
4.8 KiB
Dart
171 lines
4.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/gestures.dart' show kPressTimeout;
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
bool confirmCalled = false;
|
|
bool cancelCalled = false;
|
|
|
|
class TestInkSplash extends InkSplash {
|
|
TestInkSplash({
|
|
required super.controller,
|
|
required super.referenceBox,
|
|
super.position,
|
|
required super.color,
|
|
super.containedInkWell,
|
|
super.rectCallback,
|
|
super.borderRadius,
|
|
super.customBorder,
|
|
super.radius,
|
|
super.onRemoved,
|
|
required super.textDirection,
|
|
});
|
|
|
|
@override
|
|
void confirm() {
|
|
confirmCalled = true;
|
|
super.confirm();
|
|
}
|
|
|
|
@override
|
|
void cancel() {
|
|
cancelCalled = true;
|
|
super.cancel();
|
|
}
|
|
}
|
|
|
|
class TestInkSplashFactory extends InteractiveInkFeatureFactory {
|
|
const TestInkSplashFactory();
|
|
|
|
@override
|
|
InteractiveInkFeature create({
|
|
required MaterialInkController controller,
|
|
required RenderBox referenceBox,
|
|
Offset? position,
|
|
required Color color,
|
|
bool containedInkWell = false,
|
|
RectCallback? rectCallback,
|
|
BorderRadius? borderRadius,
|
|
ShapeBorder? customBorder,
|
|
double? radius,
|
|
VoidCallback? onRemoved,
|
|
required TextDirection textDirection,
|
|
}) {
|
|
return TestInkSplash(
|
|
controller: controller,
|
|
referenceBox: referenceBox,
|
|
position: position,
|
|
color: color,
|
|
containedInkWell: containedInkWell,
|
|
rectCallback: rectCallback,
|
|
borderRadius: borderRadius,
|
|
customBorder: customBorder,
|
|
radius: radius,
|
|
onRemoved: onRemoved,
|
|
textDirection: textDirection,
|
|
);
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
setUp(() {
|
|
confirmCalled = false;
|
|
cancelCalled = false;
|
|
});
|
|
|
|
testWidgets('Tapping should never cause a splash', (WidgetTester tester) async {
|
|
final Key textField1 = UniqueKey();
|
|
final Key textField2 = UniqueKey();
|
|
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Theme(
|
|
data: ThemeData(splashFactory: const TestInkSplashFactory()),
|
|
child: Material(
|
|
child: Container(
|
|
alignment: Alignment.topLeft,
|
|
child: Column(
|
|
children: <Widget>[
|
|
TextField(
|
|
key: textField1,
|
|
decoration: const InputDecoration(labelText: 'label'),
|
|
),
|
|
TextField(
|
|
key: textField2,
|
|
decoration: const InputDecoration(labelText: 'label'),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.tap(find.byKey(textField1));
|
|
await tester.pumpAndSettle();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
|
|
await tester.tap(find.byKey(textField1));
|
|
await tester.pumpAndSettle();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
|
|
await tester.tap(find.byKey(textField2));
|
|
await tester.pumpAndSettle();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
|
|
await tester.tapAt(tester.getTopLeft(find.byKey(textField1)));
|
|
await tester.pumpAndSettle();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
|
|
await tester.tap(find.byKey(textField2));
|
|
await tester.pumpAndSettle();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
});
|
|
|
|
testWidgets('Splash should never be created or canceled', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Theme(
|
|
data: ThemeData(splashFactory: const TestInkSplashFactory()),
|
|
child: Material(
|
|
child: ListView(
|
|
children: <Widget>[
|
|
const TextField(decoration: InputDecoration(labelText: 'label1')),
|
|
const TextField(decoration: InputDecoration(labelText: 'label2')),
|
|
Container(height: 1000.0, color: const Color(0xFF00FF00)),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
// If there were a splash, this would cancel the splash.
|
|
final TestGesture gesture1 = await tester.startGesture(tester.getCenter(find.text('label1')));
|
|
|
|
await tester.pump(kPressTimeout);
|
|
|
|
await gesture1.moveTo(const Offset(400.0, 300.0));
|
|
await gesture1.up();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
|
|
// Pointer is dragged upwards causing a scroll, splash would be canceled.
|
|
final TestGesture gesture2 = await tester.startGesture(tester.getCenter(find.text('label2')));
|
|
await tester.pump(kPressTimeout);
|
|
await gesture2.moveBy(const Offset(0.0, -200.0));
|
|
await gesture2.up();
|
|
expect(confirmCalled, isFalse);
|
|
expect(cancelCalled, isFalse);
|
|
});
|
|
}
|