mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
322 lines
13 KiB
Dart
322 lines
13 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
test('SearchBarThemeData copyWith, ==, hashCode basics', () {
|
|
expect(const SearchBarThemeData(), const SearchBarThemeData().copyWith());
|
|
expect(const SearchBarThemeData().hashCode, const SearchBarThemeData().copyWith().hashCode);
|
|
});
|
|
|
|
test('SearchBarThemeData lerp special cases', () {
|
|
expect(SearchBarThemeData.lerp(null, null, 0), null);
|
|
const data = SearchBarThemeData();
|
|
expect(identical(SearchBarThemeData.lerp(data, data, 0.5), data), true);
|
|
});
|
|
|
|
test('SearchBarThemeData defaults', () {
|
|
const themeData = SearchBarThemeData();
|
|
expect(themeData.elevation, null);
|
|
expect(themeData.backgroundColor, null);
|
|
expect(themeData.shadowColor, null);
|
|
expect(themeData.surfaceTintColor, null);
|
|
expect(themeData.overlayColor, null);
|
|
expect(themeData.side, null);
|
|
expect(themeData.shape, null);
|
|
expect(themeData.padding, null);
|
|
expect(themeData.textStyle, null);
|
|
expect(themeData.hintStyle, null);
|
|
expect(themeData.constraints, null);
|
|
expect(themeData.textCapitalization, null);
|
|
|
|
const theme = SearchBarTheme(data: SearchBarThemeData(), child: SizedBox());
|
|
expect(theme.data.elevation, null);
|
|
expect(theme.data.backgroundColor, null);
|
|
expect(theme.data.shadowColor, null);
|
|
expect(theme.data.surfaceTintColor, null);
|
|
expect(theme.data.overlayColor, null);
|
|
expect(theme.data.side, null);
|
|
expect(theme.data.shape, null);
|
|
expect(theme.data.padding, null);
|
|
expect(theme.data.textStyle, null);
|
|
expect(theme.data.hintStyle, null);
|
|
expect(theme.data.constraints, null);
|
|
expect(theme.data.textCapitalization, null);
|
|
});
|
|
|
|
testWidgets('Default SearchBarThemeData debugFillProperties', (WidgetTester tester) async {
|
|
final builder = DiagnosticPropertiesBuilder();
|
|
const SearchBarThemeData().debugFillProperties(builder);
|
|
|
|
final List<String> description = builder.properties
|
|
.where((DiagnosticsNode node) => !node.isFiltered(DiagnosticLevel.info))
|
|
.map((DiagnosticsNode node) => node.toString())
|
|
.toList();
|
|
|
|
expect(description, <String>[]);
|
|
});
|
|
|
|
testWidgets('SearchBarThemeData implements debugFillProperties', (WidgetTester tester) async {
|
|
final builder = DiagnosticPropertiesBuilder();
|
|
const SearchBarThemeData(
|
|
elevation: MaterialStatePropertyAll<double>(3.0),
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Color(0xfffffff1)),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Color(0xfffffff2)),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Color(0xfffffff3)),
|
|
overlayColor: MaterialStatePropertyAll<Color>(Color(0xfffffff4)),
|
|
side: MaterialStatePropertyAll<BorderSide>(BorderSide(width: 2.0, color: Color(0xfffffff5))),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(StadiumBorder()),
|
|
padding: MaterialStatePropertyAll<EdgeInsets>(EdgeInsets.all(16.0)),
|
|
textStyle: MaterialStatePropertyAll<TextStyle>(TextStyle(fontSize: 24.0)),
|
|
hintStyle: MaterialStatePropertyAll<TextStyle>(TextStyle(fontSize: 16.0)),
|
|
constraints: BoxConstraints(minWidth: 350, maxWidth: 850),
|
|
textCapitalization: TextCapitalization.characters,
|
|
).debugFillProperties(builder);
|
|
|
|
final List<String> description = builder.properties
|
|
.where((DiagnosticsNode node) => !node.isFiltered(DiagnosticLevel.info))
|
|
.map((DiagnosticsNode node) => node.toString())
|
|
.toList();
|
|
|
|
expect(description[0], 'elevation: WidgetStatePropertyAll(3.0)');
|
|
expect(description[1], 'backgroundColor: WidgetStatePropertyAll(${const Color(0xfffffff1)})');
|
|
expect(description[2], 'shadowColor: WidgetStatePropertyAll(${const Color(0xfffffff2)})');
|
|
expect(description[3], 'surfaceTintColor: WidgetStatePropertyAll(${const Color(0xfffffff3)})');
|
|
expect(description[4], 'overlayColor: WidgetStatePropertyAll(${const Color(0xfffffff4)})');
|
|
expect(
|
|
description[5],
|
|
'side: WidgetStatePropertyAll(BorderSide(color: ${const Color(0xfffffff5)}, width: 2.0))',
|
|
);
|
|
expect(
|
|
description[6],
|
|
'shape: WidgetStatePropertyAll(StadiumBorder(BorderSide(width: 0.0, style: none)))',
|
|
);
|
|
expect(description[7], 'padding: WidgetStatePropertyAll(EdgeInsets.all(16.0))');
|
|
expect(
|
|
description[8],
|
|
'textStyle: WidgetStatePropertyAll(TextStyle(inherit: true, size: 24.0))',
|
|
);
|
|
expect(
|
|
description[9],
|
|
'hintStyle: WidgetStatePropertyAll(TextStyle(inherit: true, size: 16.0))',
|
|
);
|
|
expect(description[10], 'constraints: BoxConstraints(350.0<=w<=850.0, 0.0<=h<=Infinity)');
|
|
expect(description[11], 'textCapitalization: TextCapitalization.characters');
|
|
});
|
|
|
|
group('[Theme, SearchBarTheme, SearchBar properties overrides]', () {
|
|
const elevationValue = 5.0;
|
|
const backgroundColorValue = Color(0xff000001);
|
|
const shadowColorValue = Color(0xff000001);
|
|
const surfaceTintColorValue = Color(0xff000001);
|
|
const overlayColorValue = Color(0xff000001);
|
|
const sideValue = BorderSide(color: Color(0xff000004), width: 2.0);
|
|
const OutlinedBorder shapeValue = RoundedRectangleBorder(
|
|
side: sideValue,
|
|
borderRadius: BorderRadius.all(Radius.circular(2.0)),
|
|
);
|
|
const paddingValue = EdgeInsets.symmetric(horizontal: 16.0);
|
|
const textStyleValue = TextStyle(color: Color(0xff000005), fontSize: 20.0);
|
|
const hintStyleValue = TextStyle(color: Color(0xff000006), fontSize: 18.0);
|
|
|
|
const WidgetStateProperty<double?> elevation = MaterialStatePropertyAll<double>(elevationValue);
|
|
const WidgetStateProperty<Color?> backgroundColor = MaterialStatePropertyAll<Color>(
|
|
backgroundColorValue,
|
|
);
|
|
const WidgetStateProperty<Color?> shadowColor = MaterialStatePropertyAll<Color>(
|
|
shadowColorValue,
|
|
);
|
|
const WidgetStateProperty<Color?> surfaceTintColor = MaterialStatePropertyAll<Color>(
|
|
surfaceTintColorValue,
|
|
);
|
|
const WidgetStateProperty<Color?> overlayColor = MaterialStatePropertyAll<Color>(
|
|
overlayColorValue,
|
|
);
|
|
const WidgetStateProperty<BorderSide?> side = MaterialStatePropertyAll<BorderSide>(sideValue);
|
|
const WidgetStateProperty<OutlinedBorder?> shape = MaterialStatePropertyAll<OutlinedBorder>(
|
|
shapeValue,
|
|
);
|
|
const WidgetStateProperty<EdgeInsetsGeometry?> padding = MaterialStatePropertyAll<EdgeInsets>(
|
|
paddingValue,
|
|
);
|
|
const WidgetStateProperty<TextStyle?> textStyle = MaterialStatePropertyAll<TextStyle>(
|
|
textStyleValue,
|
|
);
|
|
const WidgetStateProperty<TextStyle?> hintStyle = MaterialStatePropertyAll<TextStyle>(
|
|
hintStyleValue,
|
|
);
|
|
const constraints = BoxConstraints(minWidth: 250.0, maxWidth: 300.0, minHeight: 80.0);
|
|
const TextCapitalization textCapitalization = TextCapitalization.words;
|
|
|
|
const searchBarTheme = SearchBarThemeData(
|
|
elevation: elevation,
|
|
backgroundColor: backgroundColor,
|
|
shadowColor: shadowColor,
|
|
surfaceTintColor: surfaceTintColor,
|
|
overlayColor: overlayColor,
|
|
side: side,
|
|
shape: shape,
|
|
padding: padding,
|
|
textStyle: textStyle,
|
|
hintStyle: hintStyle,
|
|
constraints: constraints,
|
|
textCapitalization: textCapitalization,
|
|
);
|
|
|
|
Widget buildFrame({
|
|
bool useSearchBarProperties = false,
|
|
SearchBarThemeData? searchBarThemeData,
|
|
SearchBarThemeData? overallTheme,
|
|
}) {
|
|
final Widget child = Builder(
|
|
builder: (BuildContext context) {
|
|
if (!useSearchBarProperties) {
|
|
return const SearchBar(
|
|
hintText: 'hint',
|
|
leading: Icon(Icons.search),
|
|
trailing: <Widget>[Icon(Icons.menu)],
|
|
);
|
|
}
|
|
return const SearchBar(
|
|
hintText: 'hint',
|
|
leading: Icon(Icons.search),
|
|
trailing: <Widget>[Icon(Icons.menu)],
|
|
elevation: elevation,
|
|
backgroundColor: backgroundColor,
|
|
shadowColor: shadowColor,
|
|
surfaceTintColor: surfaceTintColor,
|
|
overlayColor: overlayColor,
|
|
side: side,
|
|
shape: shape,
|
|
padding: padding,
|
|
textStyle: textStyle,
|
|
hintStyle: hintStyle,
|
|
constraints: constraints,
|
|
textCapitalization: textCapitalization,
|
|
);
|
|
},
|
|
);
|
|
return MaterialApp(
|
|
theme: ThemeData.from(
|
|
colorScheme: const ColorScheme.light(),
|
|
).copyWith(searchBarTheme: overallTheme),
|
|
home: Scaffold(
|
|
body: Center(
|
|
// If the SearchBarThemeData widget is present, it's used
|
|
// instead of the Theme's ThemeData.searchBarTheme.
|
|
child: searchBarThemeData == null
|
|
? child
|
|
: SearchBarTheme(data: searchBarThemeData, child: child),
|
|
),
|
|
),
|
|
);
|
|
}
|
|
|
|
final Finder findMaterial = find.descendant(
|
|
of: find.byType(SearchBar),
|
|
matching: find.byType(Material),
|
|
);
|
|
|
|
final Finder findInkWell = find.descendant(
|
|
of: find.byType(SearchBar),
|
|
matching: find.byType(InkWell),
|
|
);
|
|
|
|
const hovered = <WidgetState>{WidgetState.hovered};
|
|
const focused = <WidgetState>{WidgetState.focused};
|
|
const pressed = <WidgetState>{WidgetState.pressed};
|
|
|
|
Future<void> checkSearchBar(WidgetTester tester) async {
|
|
final Material material = tester.widget<Material>(findMaterial);
|
|
final InkWell inkWell = tester.widget<InkWell>(findInkWell);
|
|
expect(material.elevation, elevationValue);
|
|
expect(material.color, backgroundColorValue);
|
|
expect(material.shadowColor, shadowColorValue);
|
|
expect(material.surfaceTintColor, surfaceTintColorValue);
|
|
expect(material.shape, shapeValue);
|
|
expect(inkWell.overlayColor!.resolve(hovered), overlayColor.resolve(hovered));
|
|
expect(inkWell.overlayColor!.resolve(focused), overlayColor.resolve(focused));
|
|
expect(inkWell.overlayColor!.resolve(pressed), overlayColor.resolve(pressed));
|
|
expect(inkWell.customBorder, shapeValue);
|
|
|
|
expect(tester.getSize(find.byType(SearchBar)), const Size(300.0, 80.0));
|
|
|
|
final Text hintText = tester.widget(find.text('hint'));
|
|
expect(hintText.style?.color, hintStyleValue.color);
|
|
expect(hintText.style?.fontSize, hintStyleValue.fontSize);
|
|
|
|
await tester.enterText(find.byType(TextField), 'input');
|
|
final EditableText inputText = tester.widget(find.text('input'));
|
|
expect(inputText.style.color, textStyleValue.color);
|
|
expect(inputText.style.fontSize, textStyleValue.fontSize);
|
|
expect(inputText.textCapitalization, textCapitalization);
|
|
|
|
final Rect barRect = tester.getRect(find.byType(SearchBar));
|
|
final Rect leadingRect = tester.getRect(find.byIcon(Icons.search));
|
|
final Rect textFieldRect = tester.getRect(find.byType(TextField));
|
|
final Rect trailingRect = tester.getRect(find.byIcon(Icons.menu));
|
|
|
|
expect(barRect.left, leadingRect.left - 16.0);
|
|
expect(leadingRect.right, textFieldRect.left - 16.0);
|
|
expect(textFieldRect.right, trailingRect.left - 16.0);
|
|
expect(trailingRect.right, barRect.right - 16.0);
|
|
}
|
|
|
|
testWidgets('SearchBar properties overrides defaults', (WidgetTester tester) async {
|
|
await tester.pumpWidget(buildFrame(useSearchBarProperties: true));
|
|
await tester.pumpAndSettle(); // allow the animations to finish
|
|
checkSearchBar(tester);
|
|
});
|
|
|
|
testWidgets('SearchBar theme data overrides defaults', (WidgetTester tester) async {
|
|
await tester.pumpWidget(buildFrame(searchBarThemeData: searchBarTheme));
|
|
await tester.pumpAndSettle();
|
|
checkSearchBar(tester);
|
|
});
|
|
|
|
testWidgets('Overall Theme SearchBar theme overrides defaults', (WidgetTester tester) async {
|
|
await tester.pumpWidget(buildFrame(overallTheme: searchBarTheme));
|
|
await tester.pumpAndSettle();
|
|
checkSearchBar(tester);
|
|
});
|
|
|
|
// Same as the previous tests with empty SearchBarThemeData's instead of null.
|
|
|
|
testWidgets('SearchBar properties overrides defaults, empty theme and overall theme', (
|
|
WidgetTester tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
buildFrame(
|
|
useSearchBarProperties: true,
|
|
searchBarThemeData: const SearchBarThemeData(),
|
|
overallTheme: const SearchBarThemeData(),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle(); // allow the animations to finish
|
|
checkSearchBar(tester);
|
|
});
|
|
|
|
testWidgets('SearchBar theme overrides defaults and overall theme', (
|
|
WidgetTester tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
buildFrame(searchBarThemeData: searchBarTheme, overallTheme: const SearchBarThemeData()),
|
|
);
|
|
await tester.pumpAndSettle(); // allow the animations to finish
|
|
checkSearchBar(tester);
|
|
});
|
|
|
|
testWidgets('Overall Theme SearchBar theme overrides defaults and null theme', (
|
|
WidgetTester tester,
|
|
) async {
|
|
await tester.pumpWidget(buildFrame(overallTheme: searchBarTheme));
|
|
await tester.pumpAndSettle(); // allow the animations to finish
|
|
checkSearchBar(tester);
|
|
});
|
|
});
|
|
}
|