mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
240 lines
7.4 KiB
Dart
240 lines
7.4 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// This file is run as part of a reduced test set in CI on Mac and Windows
|
|
// machines.
|
|
@Tags(<String>['reduced-test-set'])
|
|
library;
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/src/foundation/constants.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
testWidgets(
|
|
'InkSparkle in a Button compiles and does not crash',
|
|
(WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Scaffold(
|
|
body: Center(
|
|
child: ElevatedButton(
|
|
style: ElevatedButton.styleFrom(splashFactory: InkSparkle.splashFactory),
|
|
child: const Text('Sparkle!'),
|
|
onPressed: () {},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final Finder buttonFinder = find.text('Sparkle!');
|
|
await tester.tap(buttonFinder);
|
|
await tester.pump();
|
|
await tester.pumpAndSettle();
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'InkSparkle default splashFactory paints with drawRect when bounded',
|
|
(WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Scaffold(
|
|
body: Center(
|
|
child: InkWell(
|
|
splashFactory: InkSparkle.splashFactory,
|
|
child: const Text('Sparkle!'),
|
|
onTap: () {},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final Finder buttonFinder = find.text('Sparkle!');
|
|
await tester.tap(buttonFinder);
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 200));
|
|
|
|
final MaterialInkController material = Material.of(tester.element(buttonFinder));
|
|
expect(material, paintsExactlyCountTimes(#drawRect, 1));
|
|
|
|
expect((material as dynamic).debugInkFeatures, hasLength(1));
|
|
|
|
await tester.pumpAndSettle();
|
|
// ink feature is disposed.
|
|
expect((material as dynamic).debugInkFeatures, isEmpty);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'InkSparkle default splashFactory paints with drawPaint when unbounded',
|
|
(WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Scaffold(
|
|
body: Center(
|
|
child: InkResponse(
|
|
splashFactory: InkSparkle.splashFactory,
|
|
child: const Text('Sparkle!'),
|
|
onTap: () {},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
final Finder buttonFinder = find.text('Sparkle!');
|
|
await tester.tap(buttonFinder);
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 200));
|
|
|
|
final MaterialInkController material = Material.of(tester.element(buttonFinder));
|
|
expect(material, paintsExactlyCountTimes(#drawPaint, 1));
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
/////////////
|
|
// Goldens //
|
|
/////////////
|
|
|
|
testWidgets(
|
|
'Material2 - InkSparkle renders with sparkles when top left of button is tapped',
|
|
(WidgetTester tester) async {
|
|
await _runTest(tester, 'top_left', 0.2);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'Material3 - InkSparkle renders with sparkles when top left of button is tapped',
|
|
(WidgetTester tester) async {
|
|
await _runM3Test(tester, 'top_left', 0.2);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'Material2 - InkSparkle renders with sparkles when center of button is tapped',
|
|
(WidgetTester tester) async {
|
|
await _runTest(tester, 'center', 0.5);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'Material3 - InkSparkle renders with sparkles when center of button is tapped',
|
|
(WidgetTester tester) async {
|
|
await _runM3Test(tester, 'center', 0.5);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'Material2 - InkSparkle renders with sparkles when bottom right of button is tapped',
|
|
(WidgetTester tester) async {
|
|
await _runTest(tester, 'bottom_right', 0.8);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
|
|
testWidgets(
|
|
'Material3 - InkSparkle renders with sparkles when bottom right of button is tapped',
|
|
(WidgetTester tester) async {
|
|
await _runM3Test(tester, 'bottom_right', 0.8);
|
|
},
|
|
skip: kIsWeb, // [intended] shaders are not yet supported for web.
|
|
);
|
|
}
|
|
|
|
Future<void> _runTest(WidgetTester tester, String positionName, double distanceFromTopLeft) async {
|
|
final Key repaintKey = UniqueKey();
|
|
final Key buttonKey = UniqueKey();
|
|
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: ThemeData(useMaterial3: false),
|
|
home: Scaffold(
|
|
body: Center(
|
|
child: RepaintBoundary(
|
|
key: repaintKey,
|
|
child: ElevatedButton(
|
|
key: buttonKey,
|
|
style: ElevatedButton.styleFrom(
|
|
splashFactory: InkSparkle.constantTurbulenceSeedSplashFactory,
|
|
),
|
|
child: const Text('Sparkle!'),
|
|
onPressed: () {},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final Finder buttonFinder = find.byKey(buttonKey);
|
|
final Finder repaintFinder = find.byKey(repaintKey);
|
|
final Offset topLeft = tester.getTopLeft(buttonFinder);
|
|
final Offset bottomRight = tester.getBottomRight(buttonFinder);
|
|
|
|
await _warmUpShader(tester, buttonFinder);
|
|
|
|
final Offset target = topLeft + (bottomRight - topLeft) * distanceFromTopLeft;
|
|
await tester.tapAt(target);
|
|
for (var i = 0; i <= 5; i++) {
|
|
await tester.pump(const Duration(milliseconds: 50));
|
|
await expectLater(repaintFinder, matchesGoldenFile('m2_ink_sparkle.$positionName.$i.png'));
|
|
}
|
|
}
|
|
|
|
Future<void> _runM3Test(
|
|
WidgetTester tester,
|
|
String positionName,
|
|
double distanceFromTopLeft,
|
|
) async {
|
|
final Key repaintKey = UniqueKey();
|
|
final Key buttonKey = UniqueKey();
|
|
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Scaffold(
|
|
body: Center(
|
|
child: RepaintBoundary(
|
|
key: repaintKey,
|
|
child: ElevatedButton(
|
|
key: buttonKey,
|
|
style: ElevatedButton.styleFrom(),
|
|
child: const Text('Sparkle!'),
|
|
onPressed: () {},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final Finder buttonFinder = find.byKey(buttonKey);
|
|
final Finder repaintFinder = find.byKey(repaintKey);
|
|
final Offset topLeft = tester.getTopLeft(buttonFinder);
|
|
final Offset bottomRight = tester.getBottomRight(buttonFinder);
|
|
|
|
await _warmUpShader(tester, buttonFinder);
|
|
|
|
final Offset target = topLeft + (bottomRight - topLeft) * distanceFromTopLeft;
|
|
await tester.tapAt(target);
|
|
for (var i = 0; i <= 5; i++) {
|
|
await tester.pump(const Duration(milliseconds: 50));
|
|
await expectLater(repaintFinder, matchesGoldenFile('m3_ink_sparkle.$positionName.$i.png'));
|
|
}
|
|
}
|
|
|
|
// Warm up shader. Compilation is of the order of 10 milliseconds and
|
|
// Animation is < 1000 milliseconds. Use 2000 milliseconds as a safety
|
|
// net to prevent flakiness.
|
|
Future<void> _warmUpShader(WidgetTester tester, Finder buttonFinder) async {
|
|
await tester.tap(buttonFinder);
|
|
await tester.pumpAndSettle(const Duration(milliseconds: 2000));
|
|
}
|