mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
9d96df2364
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
446 lines
17 KiB
Dart
446 lines
17 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
Finder findMenuItemButton(String label) {
|
|
// For each menu items there are two MenuItemButton widgets.
|
|
// The last one is the real button item in the menu.
|
|
// The first one is not visible, it is part of _DropdownMenuBody
|
|
// which is used to compute the dropdown width.
|
|
return find.widgetWithText(MenuItemButton, label).last;
|
|
}
|
|
|
|
Material getButtonMaterial(WidgetTester tester, String itemLabel) {
|
|
return tester.widget<Material>(
|
|
find.descendant(of: findMenuItemButton(itemLabel), matching: find.byType(Material)),
|
|
);
|
|
}
|
|
|
|
Finder findMenuPanel() {
|
|
return find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_MenuPanel');
|
|
}
|
|
|
|
Material getMenuMaterial(WidgetTester tester) {
|
|
return tester.widget<Material>(
|
|
find.descendant(of: findMenuPanel(), matching: find.byType(Material)).first,
|
|
);
|
|
}
|
|
|
|
test('DropdownMenuThemeData copyWith, ==, hashCode basics', () {
|
|
expect(const DropdownMenuThemeData(), const DropdownMenuThemeData().copyWith());
|
|
expect(
|
|
const DropdownMenuThemeData().hashCode,
|
|
const DropdownMenuThemeData().copyWith().hashCode,
|
|
);
|
|
|
|
const custom = DropdownMenuThemeData(
|
|
menuStyle: MenuStyle(backgroundColor: MaterialStatePropertyAll<Color>(Colors.green)),
|
|
inputDecorationTheme: InputDecorationTheme(filled: true),
|
|
textStyle: TextStyle(fontSize: 25.0),
|
|
);
|
|
final DropdownMenuThemeData copy = const DropdownMenuThemeData().copyWith(
|
|
menuStyle: custom.menuStyle,
|
|
inputDecorationTheme: custom.inputDecorationTheme,
|
|
textStyle: custom.textStyle,
|
|
);
|
|
expect(copy, custom);
|
|
});
|
|
|
|
test('DropdownMenuThemeData lerp special cases', () {
|
|
expect(DropdownMenuThemeData.lerp(null, null, 0), const DropdownMenuThemeData());
|
|
const data = DropdownMenuThemeData();
|
|
expect(identical(DropdownMenuThemeData.lerp(data, data, 0.5), data), true);
|
|
});
|
|
|
|
testWidgets('Default DropdownMenuThemeData debugFillProperties', (WidgetTester tester) async {
|
|
final builder = DiagnosticPropertiesBuilder();
|
|
const DropdownMenuThemeData().debugFillProperties(builder);
|
|
|
|
final List<String> description = builder.properties
|
|
.where((DiagnosticsNode node) => !node.isFiltered(DiagnosticLevel.info))
|
|
.map((DiagnosticsNode node) => node.toString())
|
|
.toList();
|
|
|
|
expect(description, <String>[]);
|
|
});
|
|
|
|
testWidgets('With no other configuration, defaults are used', (WidgetTester tester) async {
|
|
final themeData = ThemeData();
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: themeData,
|
|
home: const Scaffold(
|
|
body: Center(
|
|
child: DropdownMenu<int>(
|
|
dropdownMenuEntries: <DropdownMenuEntry<int>>[
|
|
DropdownMenuEntry<int>(value: 0, label: 'Item 0'),
|
|
DropdownMenuEntry<int>(value: 1, label: 'Item 1'),
|
|
DropdownMenuEntry<int>(value: 2, label: 'Item 2'),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final EditableText editableText = tester.widget(find.byType(EditableText));
|
|
expect(editableText.style.color, themeData.textTheme.labelLarge!.color);
|
|
expect(editableText.style.background, themeData.textTheme.labelLarge!.background);
|
|
expect(editableText.style.shadows, themeData.textTheme.labelLarge!.shadows);
|
|
expect(editableText.style.decoration, themeData.textTheme.labelLarge!.decoration);
|
|
expect(editableText.style.locale, themeData.textTheme.labelLarge!.locale);
|
|
expect(editableText.style.wordSpacing, themeData.textTheme.labelLarge!.wordSpacing);
|
|
|
|
final TextField textField = tester.widget(find.byType(TextField));
|
|
expect(textField.decoration?.border, const OutlineInputBorder());
|
|
|
|
await tester.tap(find.widgetWithIcon(IconButton, Icons.arrow_drop_down).first);
|
|
await tester.pump();
|
|
expect(find.byType(MenuAnchor), findsOneWidget);
|
|
|
|
Material material = getMenuMaterial(tester);
|
|
expect(material.color, themeData.colorScheme.surfaceContainer);
|
|
expect(material.shadowColor, themeData.colorScheme.shadow);
|
|
expect(material.surfaceTintColor, Colors.transparent);
|
|
expect(material.elevation, 3.0);
|
|
expect(
|
|
material.shape,
|
|
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(4.0))),
|
|
);
|
|
|
|
material = getButtonMaterial(tester, 'Item 0');
|
|
expect(material.color, Colors.transparent);
|
|
expect(material.elevation, 0.0);
|
|
expect(material.shape, const RoundedRectangleBorder());
|
|
expect(material.textStyle?.color, themeData.colorScheme.onSurface);
|
|
});
|
|
|
|
testWidgets('ThemeData.dropdownMenuTheme overrides defaults', (WidgetTester tester) async {
|
|
final theme = ThemeData(
|
|
dropdownMenuTheme: DropdownMenuThemeData(
|
|
textStyle: TextStyle(
|
|
color: Colors.orange,
|
|
backgroundColor: Colors.indigo,
|
|
fontSize: 30.0,
|
|
shadows: kElevationToShadow[1],
|
|
decoration: TextDecoration.underline,
|
|
wordSpacing: 2.0,
|
|
),
|
|
menuStyle: const MenuStyle(
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Colors.grey),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Colors.brown),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Colors.amberAccent),
|
|
elevation: MaterialStatePropertyAll<double>(10.0),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(
|
|
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(10.0))),
|
|
),
|
|
),
|
|
inputDecorationTheme: const InputDecorationTheme(
|
|
filled: true,
|
|
fillColor: Colors.lightGreen,
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: theme,
|
|
home: const Scaffold(
|
|
body: Center(
|
|
child: DropdownMenu<int>(
|
|
dropdownMenuEntries: <DropdownMenuEntry<int>>[
|
|
DropdownMenuEntry<int>(value: 0, label: 'Item 0'),
|
|
DropdownMenuEntry<int>(value: 1, label: 'Item 1'),
|
|
DropdownMenuEntry<int>(value: 2, label: 'Item 2'),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final EditableText editableText = tester.widget(find.byType(EditableText));
|
|
expect(editableText.style.color, Colors.orange);
|
|
expect(editableText.style.backgroundColor, Colors.indigo);
|
|
expect(editableText.style.shadows, kElevationToShadow[1]);
|
|
expect(editableText.style.decoration, TextDecoration.underline);
|
|
expect(editableText.style.wordSpacing, 2.0);
|
|
|
|
final TextField textField = tester.widget(find.byType(TextField));
|
|
expect(textField.decoration?.filled, isTrue);
|
|
expect(textField.decoration?.fillColor, Colors.lightGreen);
|
|
|
|
await tester.tap(find.widgetWithIcon(IconButton, Icons.arrow_drop_down).first);
|
|
await tester.pump();
|
|
expect(find.byType(MenuAnchor), findsOneWidget);
|
|
|
|
Material material = getMenuMaterial(tester);
|
|
expect(material.color, Colors.grey);
|
|
expect(material.shadowColor, Colors.brown);
|
|
expect(material.surfaceTintColor, Colors.amberAccent);
|
|
expect(material.elevation, 10.0);
|
|
expect(
|
|
material.shape,
|
|
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(10.0))),
|
|
);
|
|
|
|
material = getButtonMaterial(tester, 'Item 0');
|
|
expect(material.color, Colors.transparent);
|
|
expect(material.elevation, 0.0);
|
|
expect(material.shape, const RoundedRectangleBorder());
|
|
expect(material.textStyle?.color, theme.colorScheme.onSurface);
|
|
});
|
|
|
|
testWidgets('DropdownMenuTheme overrides ThemeData and defaults', (WidgetTester tester) async {
|
|
final global = DropdownMenuThemeData(
|
|
textStyle: TextStyle(
|
|
color: Colors.orange,
|
|
backgroundColor: Colors.indigo,
|
|
fontSize: 30.0,
|
|
shadows: kElevationToShadow[1],
|
|
decoration: TextDecoration.underline,
|
|
wordSpacing: 2.0,
|
|
),
|
|
menuStyle: const MenuStyle(
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Colors.grey),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Colors.brown),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Colors.amberAccent),
|
|
elevation: MaterialStatePropertyAll<double>(10.0),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(
|
|
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(10.0))),
|
|
),
|
|
),
|
|
inputDecorationTheme: const InputDecorationTheme(filled: true, fillColor: Colors.lightGreen),
|
|
);
|
|
|
|
final dropdownMenuTheme = DropdownMenuThemeData(
|
|
textStyle: TextStyle(
|
|
color: Colors.red,
|
|
backgroundColor: Colors.orange,
|
|
fontSize: 27.0,
|
|
shadows: kElevationToShadow[2],
|
|
decoration: TextDecoration.lineThrough,
|
|
wordSpacing: 5.0,
|
|
),
|
|
menuStyle: const MenuStyle(
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Colors.yellow),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Colors.green),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Colors.teal),
|
|
elevation: MaterialStatePropertyAll<double>(15.0),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(
|
|
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(8.0))),
|
|
),
|
|
),
|
|
inputDecorationTheme: const InputDecorationTheme(filled: true, fillColor: Colors.blue),
|
|
);
|
|
|
|
final theme = ThemeData(dropdownMenuTheme: global);
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: theme,
|
|
home: DropdownMenuTheme(
|
|
data: dropdownMenuTheme,
|
|
child: const Scaffold(
|
|
body: Center(
|
|
child: DropdownMenu<int>(
|
|
dropdownMenuEntries: <DropdownMenuEntry<int>>[
|
|
DropdownMenuEntry<int>(value: 0, label: 'Item 0'),
|
|
DropdownMenuEntry<int>(value: 1, label: 'Item 1'),
|
|
DropdownMenuEntry<int>(value: 2, label: 'Item 2'),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final EditableText editableText = tester.widget(find.byType(EditableText));
|
|
expect(editableText.style.color, Colors.red);
|
|
expect(editableText.style.backgroundColor, Colors.orange);
|
|
expect(editableText.style.fontSize, 27.0);
|
|
expect(editableText.style.shadows, kElevationToShadow[2]);
|
|
expect(editableText.style.decoration, TextDecoration.lineThrough);
|
|
expect(editableText.style.wordSpacing, 5.0);
|
|
|
|
final TextField textField = tester.widget(find.byType(TextField));
|
|
expect(textField.decoration?.filled, isTrue);
|
|
expect(textField.decoration?.fillColor, Colors.blue);
|
|
|
|
await tester.tap(find.widgetWithIcon(IconButton, Icons.arrow_drop_down).first);
|
|
await tester.pump();
|
|
expect(find.byType(MenuAnchor), findsOneWidget);
|
|
|
|
Material material = getMenuMaterial(tester);
|
|
expect(material.color, Colors.yellow);
|
|
expect(material.shadowColor, Colors.green);
|
|
expect(material.surfaceTintColor, Colors.teal);
|
|
expect(material.elevation, 15.0);
|
|
expect(
|
|
material.shape,
|
|
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(8.0))),
|
|
);
|
|
|
|
material = getButtonMaterial(tester, 'Item 0');
|
|
expect(material.color, Colors.transparent);
|
|
expect(material.elevation, 0.0);
|
|
expect(material.shape, const RoundedRectangleBorder());
|
|
expect(material.textStyle?.color, theme.colorScheme.onSurface);
|
|
});
|
|
|
|
testWidgets('Widget parameters overrides DropdownMenuTheme, ThemeData and defaults', (
|
|
WidgetTester tester,
|
|
) async {
|
|
final global = DropdownMenuThemeData(
|
|
textStyle: TextStyle(
|
|
color: Colors.orange,
|
|
backgroundColor: Colors.indigo,
|
|
fontSize: 30.0,
|
|
shadows: kElevationToShadow[1],
|
|
decoration: TextDecoration.underline,
|
|
wordSpacing: 2.0,
|
|
),
|
|
menuStyle: const MenuStyle(
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Colors.grey),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Colors.brown),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Colors.amberAccent),
|
|
elevation: MaterialStatePropertyAll<double>(10.0),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(
|
|
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(10.0))),
|
|
),
|
|
),
|
|
inputDecorationTheme: const InputDecorationTheme(filled: true, fillColor: Colors.lightGreen),
|
|
);
|
|
|
|
final dropdownMenuTheme = DropdownMenuThemeData(
|
|
textStyle: TextStyle(
|
|
color: Colors.red,
|
|
backgroundColor: Colors.orange,
|
|
fontSize: 27.0,
|
|
shadows: kElevationToShadow[2],
|
|
decoration: TextDecoration.lineThrough,
|
|
wordSpacing: 5.0,
|
|
),
|
|
menuStyle: const MenuStyle(
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Colors.yellow),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Colors.green),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Colors.teal),
|
|
elevation: MaterialStatePropertyAll<double>(15.0),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(
|
|
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(8.0))),
|
|
),
|
|
),
|
|
inputDecorationTheme: const InputDecorationTheme(filled: true, fillColor: Colors.blue),
|
|
);
|
|
|
|
final theme = ThemeData(dropdownMenuTheme: global);
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: theme,
|
|
home: DropdownMenuTheme(
|
|
data: dropdownMenuTheme,
|
|
child: Scaffold(
|
|
body: Center(
|
|
child: DropdownMenu<int>(
|
|
textStyle: TextStyle(
|
|
color: Colors.pink,
|
|
backgroundColor: Colors.cyan,
|
|
fontSize: 32.0,
|
|
shadows: kElevationToShadow[3],
|
|
decoration: TextDecoration.overline,
|
|
wordSpacing: 3.0,
|
|
),
|
|
menuStyle: const MenuStyle(
|
|
backgroundColor: MaterialStatePropertyAll<Color>(Colors.limeAccent),
|
|
shadowColor: MaterialStatePropertyAll<Color>(Colors.deepOrangeAccent),
|
|
surfaceTintColor: MaterialStatePropertyAll<Color>(Colors.lightBlue),
|
|
elevation: MaterialStatePropertyAll<double>(21.0),
|
|
shape: MaterialStatePropertyAll<OutlinedBorder>(
|
|
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(15.0))),
|
|
),
|
|
),
|
|
inputDecorationTheme: const InputDecorationTheme(
|
|
filled: true,
|
|
fillColor: Colors.deepPurple,
|
|
),
|
|
dropdownMenuEntries: const <DropdownMenuEntry<int>>[
|
|
DropdownMenuEntry<int>(value: 0, label: 'Item 0'),
|
|
DropdownMenuEntry<int>(value: 1, label: 'Item 1'),
|
|
DropdownMenuEntry<int>(value: 2, label: 'Item 2'),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final EditableText editableText = tester.widget(find.byType(EditableText));
|
|
expect(editableText.style.color, Colors.pink);
|
|
expect(editableText.style.backgroundColor, Colors.cyan);
|
|
expect(editableText.style.fontSize, 32.0);
|
|
expect(editableText.style.shadows, kElevationToShadow[3]);
|
|
expect(editableText.style.decoration, TextDecoration.overline);
|
|
expect(editableText.style.wordSpacing, 3.0);
|
|
|
|
final TextField textField = tester.widget(find.byType(TextField));
|
|
expect(textField.decoration?.filled, isTrue);
|
|
expect(textField.decoration?.fillColor, Colors.deepPurple);
|
|
|
|
await tester.tap(find.widgetWithIcon(IconButton, Icons.arrow_drop_down).first);
|
|
await tester.pump();
|
|
expect(find.byType(MenuAnchor), findsOneWidget);
|
|
|
|
Material material = getMenuMaterial(tester);
|
|
expect(material.color, Colors.limeAccent);
|
|
expect(material.shadowColor, Colors.deepOrangeAccent);
|
|
expect(material.surfaceTintColor, Colors.lightBlue);
|
|
expect(material.elevation, 21.0);
|
|
expect(
|
|
material.shape,
|
|
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(15.0))),
|
|
);
|
|
|
|
material = getButtonMaterial(tester, 'Item 0');
|
|
expect(material.color, Colors.transparent);
|
|
expect(material.elevation, 0.0);
|
|
expect(material.shape, const RoundedRectangleBorder());
|
|
expect(material.textStyle?.color, theme.colorScheme.onSurface);
|
|
});
|
|
|
|
testWidgets(
|
|
'DropdownMenuThemeData.menuStyle.disabledColor is being applied when the menu is disabled',
|
|
(WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: ThemeData(
|
|
dropdownMenuTheme: const DropdownMenuThemeData(disabledColor: Colors.grey),
|
|
),
|
|
home: const Scaffold(
|
|
body: Center(
|
|
child: DropdownMenu<int>(
|
|
enabled: false,
|
|
initialSelection: 0,
|
|
dropdownMenuEntries: <DropdownMenuEntry<int>>[
|
|
DropdownMenuEntry<int>(value: 0, label: 'Item 0'),
|
|
DropdownMenuEntry<int>(value: 1, label: 'Item 1'),
|
|
DropdownMenuEntry<int>(value: 2, label: 'Item 2'),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
// make sure the displaying text has grey color
|
|
final EditableText editableText = tester.widget(find.byType(EditableText));
|
|
expect(editableText.style.color, Colors.grey);
|
|
},
|
|
);
|
|
}
|