mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
255 lines
9.1 KiB
Dart
255 lines
9.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
test('CarouselViewThemeData copyWith, ==, hashCode basics', () {
|
|
expect(const CarouselViewThemeData(), const CarouselViewThemeData().copyWith());
|
|
expect(
|
|
const CarouselViewThemeData().hashCode,
|
|
const CarouselViewThemeData().copyWith().hashCode,
|
|
);
|
|
});
|
|
|
|
test('CarouselViewThemeData null fields by default', () {
|
|
const carouselViewTheme = CarouselViewThemeData();
|
|
expect(carouselViewTheme.backgroundColor, null);
|
|
expect(carouselViewTheme.elevation, null);
|
|
expect(carouselViewTheme.overlayColor, null);
|
|
expect(carouselViewTheme.padding, null);
|
|
expect(carouselViewTheme.shape, null);
|
|
expect(carouselViewTheme.itemClipBehavior, null);
|
|
});
|
|
|
|
testWidgets('Default CarouselViewThemeData debugFillProperties', (WidgetTester tester) async {
|
|
final builder = DiagnosticPropertiesBuilder();
|
|
const CarouselViewThemeData().debugFillProperties(builder);
|
|
|
|
final List<String> description = builder.properties
|
|
.where((DiagnosticsNode node) => !node.isFiltered(DiagnosticLevel.info))
|
|
.map((DiagnosticsNode node) => node.toString())
|
|
.toList();
|
|
|
|
expect(description, <String>[]);
|
|
});
|
|
|
|
testWidgets('CarouselViewThemeData implements debugFillProperties', (WidgetTester tester) async {
|
|
final builder = DiagnosticPropertiesBuilder();
|
|
const CarouselViewThemeData(
|
|
backgroundColor: Color(0xFFFFFFFF),
|
|
elevation: 5.0,
|
|
padding: EdgeInsets.zero,
|
|
shape: RoundedRectangleBorder(),
|
|
overlayColor: MaterialStatePropertyAll<Color>(Colors.red),
|
|
itemClipBehavior: Clip.hardEdge,
|
|
).debugFillProperties(builder);
|
|
|
|
final List<String> description = builder.properties
|
|
.where((DiagnosticsNode node) => !node.isFiltered(DiagnosticLevel.info))
|
|
.map((DiagnosticsNode node) => node.toString())
|
|
.toList();
|
|
|
|
expect(description, <String>[
|
|
'backgroundColor: ${const Color(0xffffffff)}',
|
|
'elevation: 5.0',
|
|
'shape: RoundedRectangleBorder(BorderSide(width: 0.0, style: none), BorderRadius.zero)',
|
|
'overlayColor: WidgetStatePropertyAll(${Colors.red})',
|
|
'padding: EdgeInsets.zero',
|
|
'itemClipBehavior: hardEdge',
|
|
]);
|
|
});
|
|
|
|
testWidgets('Uses value from CarouselViewThemeData', (WidgetTester tester) async {
|
|
final CarouselViewThemeData carouselViewTheme = _carouselViewThemeData();
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: ThemeData(carouselViewTheme: carouselViewTheme),
|
|
home: const Scaffold(
|
|
body: Center(
|
|
child: CarouselView(
|
|
itemExtent: 100,
|
|
children: <Widget>[SizedBox(width: 100, height: 100)],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
expect(find.byType(CarouselView), findsOneWidget);
|
|
|
|
final Finder padding = find.descendant(
|
|
of: find.byType(CarouselView),
|
|
matching: find.byWidgetPredicate(
|
|
(Widget widget) => widget is Padding && widget.child is Material,
|
|
),
|
|
);
|
|
|
|
expect(padding, findsOneWidget);
|
|
final Padding paddingWidget = tester.widget<Padding>(padding);
|
|
final material = paddingWidget.child! as Material;
|
|
|
|
final InkWell inkWell = tester.widget<InkWell>(
|
|
find.descendant(of: find.byType(CarouselView), matching: find.byType(InkWell)),
|
|
);
|
|
|
|
expect(paddingWidget.padding, carouselViewTheme.padding);
|
|
expect(material.color, carouselViewTheme.backgroundColor);
|
|
expect(material.elevation, carouselViewTheme.elevation);
|
|
expect(material.shape, carouselViewTheme.shape);
|
|
expect(material.borderRadius, null);
|
|
expect(inkWell.overlayColor, carouselViewTheme.overlayColor);
|
|
expect(material.clipBehavior, carouselViewTheme.itemClipBehavior);
|
|
});
|
|
|
|
testWidgets('Widgets properties override theme', (WidgetTester tester) async {
|
|
final CarouselViewThemeData carouselViewTheme = _carouselViewThemeData();
|
|
const backgroundColor = Color(0xFFFF0000);
|
|
const elevation = 10.0;
|
|
const padding = EdgeInsets.all(15.0);
|
|
const OutlinedBorder shape = RoundedRectangleBorder(
|
|
borderRadius: BorderRadius.all(Radius.circular(10)),
|
|
);
|
|
const WidgetStateProperty<Color?> overlayColor = MaterialStatePropertyAll<Color>(Colors.green);
|
|
const Clip itemClipBehavior = Clip.hardEdge;
|
|
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: ThemeData(carouselViewTheme: carouselViewTheme),
|
|
home: const Scaffold(
|
|
body: Center(
|
|
child: CarouselView(
|
|
backgroundColor: backgroundColor,
|
|
elevation: elevation,
|
|
padding: padding,
|
|
shape: shape,
|
|
overlayColor: overlayColor,
|
|
itemExtent: 100,
|
|
itemClipBehavior: itemClipBehavior,
|
|
children: <Widget>[SizedBox(width: 100, height: 100)],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
expect(find.byType(CarouselView), findsOneWidget);
|
|
|
|
final Finder paddingFinder = find.descendant(
|
|
of: find.byType(CarouselView),
|
|
matching: find.byWidgetPredicate(
|
|
(Widget widget) => widget is Padding && widget.child is Material,
|
|
),
|
|
);
|
|
|
|
expect(paddingFinder, findsOneWidget);
|
|
final Padding paddingWidget = tester.widget<Padding>(paddingFinder);
|
|
final material = paddingWidget.child! as Material;
|
|
|
|
final InkWell inkWell = tester.widget<InkWell>(
|
|
find.descendant(of: find.byType(CarouselView), matching: find.byType(InkWell)),
|
|
);
|
|
|
|
expect(paddingWidget.padding, padding);
|
|
expect(material.color, backgroundColor);
|
|
expect(material.elevation, elevation);
|
|
expect(material.shape, shape);
|
|
expect(inkWell.overlayColor, overlayColor);
|
|
expect(material.clipBehavior, Clip.hardEdge);
|
|
});
|
|
|
|
testWidgets('CarouselViewTheme can override Theme.carouselViewTheme', (
|
|
WidgetTester tester,
|
|
) async {
|
|
const globalBackgroundColor = Color(0xfffffff1);
|
|
const globalOverlayColor = Color(0xff000000);
|
|
const globalElevation = 5.0;
|
|
const globalPadding = EdgeInsets.all(10.0);
|
|
const OutlinedBorder globalShape = RoundedRectangleBorder();
|
|
const Clip globalItemClipBehavior = Clip.hardEdge;
|
|
|
|
const localBackgroundColor = Color(0xffff0000);
|
|
const localOverlayColor = Color(0xffffffff);
|
|
const localElevation = 10.0;
|
|
const localPadding = EdgeInsets.all(15.0);
|
|
const OutlinedBorder localShape = RoundedRectangleBorder(
|
|
borderRadius: BorderRadius.all(Radius.circular(10)),
|
|
);
|
|
const Clip localItemClipBehavior = Clip.antiAlias;
|
|
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: ThemeData(
|
|
carouselViewTheme: const CarouselViewThemeData(
|
|
backgroundColor: globalBackgroundColor,
|
|
overlayColor: MaterialStatePropertyAll<Color>(globalOverlayColor),
|
|
elevation: globalElevation,
|
|
padding: globalPadding,
|
|
shape: globalShape,
|
|
itemClipBehavior: globalItemClipBehavior,
|
|
),
|
|
),
|
|
home: const Scaffold(
|
|
body: Center(
|
|
child: CarouselViewTheme(
|
|
data: CarouselViewThemeData(
|
|
backgroundColor: localBackgroundColor,
|
|
overlayColor: MaterialStatePropertyAll<Color>(localOverlayColor),
|
|
elevation: localElevation,
|
|
padding: localPadding,
|
|
shape: localShape,
|
|
itemClipBehavior: localItemClipBehavior,
|
|
),
|
|
child: CarouselView(
|
|
itemExtent: 100,
|
|
children: <Widget>[SizedBox(width: 100, height: 100)],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
final Finder padding = find.descendant(
|
|
of: find.byType(CarouselView),
|
|
matching: find.byWidgetPredicate(
|
|
(Widget widget) => widget is Padding && widget.child is Material,
|
|
),
|
|
);
|
|
|
|
expect(padding, findsOneWidget);
|
|
final Padding paddingWidget = tester.widget<Padding>(padding);
|
|
final material = paddingWidget.child! as Material;
|
|
|
|
final InkWell inkWell = tester.widget<InkWell>(
|
|
find.descendant(of: find.byType(CarouselView), matching: find.byType(InkWell)),
|
|
);
|
|
|
|
expect(paddingWidget.padding, localPadding);
|
|
expect(material.color, localBackgroundColor);
|
|
expect(material.elevation, localElevation);
|
|
expect(material.shape, localShape);
|
|
expect(inkWell.overlayColor?.resolve(<WidgetState>{}), localOverlayColor);
|
|
expect(material.clipBehavior, localItemClipBehavior);
|
|
});
|
|
}
|
|
|
|
CarouselViewThemeData _carouselViewThemeData() {
|
|
const backgroundColor = Color(0xFF0000FF);
|
|
const elevation = 5.0;
|
|
const padding = EdgeInsets.all(10.0);
|
|
const OutlinedBorder shape = RoundedRectangleBorder();
|
|
const WidgetStateProperty<Color?> overlayColor = MaterialStatePropertyAll<Color>(Colors.red);
|
|
const Clip itemClipBehavior = Clip.hardEdge;
|
|
|
|
return const CarouselViewThemeData(
|
|
backgroundColor: backgroundColor,
|
|
elevation: elevation,
|
|
padding: padding,
|
|
shape: shape,
|
|
overlayColor: overlayColor,
|
|
itemClipBehavior: itemClipBehavior,
|
|
);
|
|
}
|