Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

305 lines
9.2 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';
import '../widgets/semantics_tester.dart';
void main() {
testWidgets('Material3 - Card defaults (Elevated card)', (WidgetTester tester) async {
final theme = ThemeData();
final ColorScheme colors = theme.colorScheme;
await tester.pumpWidget(
MaterialApp(
theme: theme,
home: const Scaffold(body: Card()),
),
);
final Padding padding = _getCardPadding(tester);
final Material material = _getCardMaterial(tester);
expect(material.clipBehavior, Clip.none);
expect(material.elevation, 1.0);
expect(padding.padding, const EdgeInsets.all(4.0));
expect(material.color, colors.surfaceContainerLow);
expect(material.shadowColor, colors.shadow);
expect(
material.surfaceTintColor,
Colors.transparent,
); // Don't use surface tint. Toned surface container is used instead.
expect(
material.shape,
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(12.0))),
);
});
testWidgets('Material3 - Card.filled defaults', (WidgetTester tester) async {
final theme = ThemeData();
final ColorScheme colors = theme.colorScheme;
await tester.pumpWidget(
MaterialApp(
theme: theme,
home: const Scaffold(body: Card.filled()),
),
);
final Padding padding = _getCardPadding(tester);
final Material material = _getCardMaterial(tester);
expect(material.clipBehavior, Clip.none);
expect(material.elevation, 0.0);
expect(padding.padding, const EdgeInsets.all(4.0));
expect(material.color, colors.surfaceContainerHighest);
expect(material.shadowColor, colors.shadow);
expect(material.surfaceTintColor, Colors.transparent);
expect(
material.shape,
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(12.0))),
);
});
testWidgets('Material3 - Card.outlined defaults', (WidgetTester tester) async {
final theme = ThemeData();
final ColorScheme colors = theme.colorScheme;
await tester.pumpWidget(
MaterialApp(
theme: theme,
home: const Scaffold(body: Card.outlined()),
),
);
final Padding padding = _getCardPadding(tester);
final Material material = _getCardMaterial(tester);
expect(material.clipBehavior, Clip.none);
expect(material.elevation, 0.0);
expect(padding.padding, const EdgeInsets.all(4.0));
expect(material.color, colors.surface);
expect(material.shadowColor, colors.shadow);
expect(material.surfaceTintColor, Colors.transparent);
expect(
material.shape,
RoundedRectangleBorder(
side: BorderSide(color: colors.outlineVariant),
borderRadius: const BorderRadius.all(Radius.circular(12.0)),
),
);
});
testWidgets('Card can take semantic text from multiple children', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: Material(
child: Center(
child: Card(
semanticContainer: false,
child: Column(
children: <Widget>[
const Text('I am text!'),
const Text('Moar text!!1'),
ElevatedButton(onPressed: () {}, child: const Text('Button')),
],
),
),
),
),
),
);
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics(id: 1, label: 'I am text!', textDirection: TextDirection.ltr),
TestSemantics(id: 2, label: 'Moar text!!1', textDirection: TextDirection.ltr),
TestSemantics(
id: 3,
label: 'Button',
textDirection: TextDirection.ltr,
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
SemanticsFlag.isButton,
SemanticsFlag.isEnabled,
SemanticsFlag.isFocusable,
],
),
],
),
ignoreTransform: true,
ignoreRect: true,
),
);
semantics.dispose();
});
testWidgets('Card merges children when it is a semanticContainer', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
debugResetSemanticsIdCounter();
await tester.pumpWidget(
const Directionality(
textDirection: TextDirection.ltr,
child: Material(
child: Center(
child: Card(
child: Column(children: <Widget>[Text('First child'), Text('Second child')]),
),
),
),
),
);
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics(
id: 1,
label: 'First child\nSecond child',
textDirection: TextDirection.ltr,
),
],
),
ignoreTransform: true,
ignoreRect: true,
),
);
semantics.dispose();
});
testWidgets('Card margin', (WidgetTester tester) async {
const Key contentsKey = ValueKey<String>('contents');
await tester.pumpWidget(
Container(
alignment: Alignment.topLeft,
child: Card(
child: Container(
key: contentsKey,
color: const Color(0xFF00FF00),
width: 100.0,
height: 100.0,
),
),
),
);
// Default margin is 4
expect(tester.getTopLeft(find.byType(Card)), Offset.zero);
expect(tester.getSize(find.byType(Card)), const Size(108.0, 108.0));
expect(tester.getTopLeft(find.byKey(contentsKey)), const Offset(4.0, 4.0));
expect(tester.getSize(find.byKey(contentsKey)), const Size(100.0, 100.0));
await tester.pumpWidget(
Container(
alignment: Alignment.topLeft,
child: Card(
margin: EdgeInsets.zero,
child: Container(
key: contentsKey,
color: const Color(0xFF00FF00),
width: 100.0,
height: 100.0,
),
),
),
);
// Specified margin is zero
expect(tester.getTopLeft(find.byType(Card)), Offset.zero);
expect(tester.getSize(find.byType(Card)), const Size(100.0, 100.0));
expect(tester.getTopLeft(find.byKey(contentsKey)), Offset.zero);
expect(tester.getSize(find.byKey(contentsKey)), const Size(100.0, 100.0));
});
testWidgets('Card clipBehavior property passes through to the Material', (
WidgetTester tester,
) async {
await tester.pumpWidget(const Card());
expect(tester.widget<Material>(find.byType(Material)).clipBehavior, Clip.none);
await tester.pumpWidget(const Card(clipBehavior: Clip.antiAlias));
expect(tester.widget<Material>(find.byType(Material)).clipBehavior, Clip.antiAlias);
});
testWidgets('Card clipBehavior property defers to theme when null', (WidgetTester tester) async {
await tester.pumpWidget(
Builder(
builder: (BuildContext context) {
final ThemeData themeData = Theme.of(context);
return Theme(
data: themeData.copyWith(
cardTheme: themeData.cardTheme.copyWith(clipBehavior: Clip.antiAliasWithSaveLayer),
),
child: const Card(),
);
},
),
);
expect(
tester.widget<Material>(find.byType(Material)).clipBehavior,
Clip.antiAliasWithSaveLayer,
);
});
testWidgets('Card shadowColor', (WidgetTester tester) async {
Material getCardMaterial(WidgetTester tester) {
return tester.widget<Material>(
find.descendant(of: find.byType(Card), matching: find.byType(Material)),
);
}
Card getCard(WidgetTester tester) {
return tester.widget<Card>(find.byType(Card));
}
await tester.pumpWidget(const Card());
expect(getCard(tester).shadowColor, null);
expect(getCardMaterial(tester).shadowColor, const Color(0xFF000000));
await tester.pumpWidget(const Card(shadowColor: Colors.red));
expect(getCardMaterial(tester).shadowColor, getCard(tester).shadowColor);
expect(getCardMaterial(tester).shadowColor, Colors.red);
});
testWidgets('Card renders at zero size', (WidgetTester tester) async {
await tester.pumpWidget(
const MaterialApp(
home: Center(
child: SizedBox.shrink(
child: Scaffold(body: Card(child: Text('X'))),
),
),
),
);
final Finder xText = find.text('X');
expect(tester.getSize(xText).isEmpty, isTrue);
});
}
Material _getCardMaterial(WidgetTester tester) {
return tester.widget<Material>(
find.descendant(of: find.byType(Card), matching: find.byType(Material)),
);
}
Padding _getCardPadding(WidgetTester tester) {
return tester.widget<Padding>(
find.descendant(of: find.byType(Card), matching: find.byType(Padding)),
);
}