mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
246 lines
6.7 KiB
Dart
246 lines
6.7 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:ui';
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
|
|
|
|
class PrintOverrideTestBinding extends AutomatedTestWidgetsFlutterBinding {
|
|
@override
|
|
DebugPrintCallback get debugPrintOverride => _enablePrint ? debugPrint : _emptyPrint;
|
|
|
|
static void _emptyPrint(String? message, {int? wrapWidth}) {}
|
|
|
|
static bool _enablePrint = true;
|
|
|
|
static void runWithDebugPrintDisabled(void Function() f) {
|
|
try {
|
|
_enablePrint = false;
|
|
f();
|
|
} finally {
|
|
_enablePrint = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
// LeakTesting is turned off because it adds subscriptions to
|
|
// [FlutterMemoryAllocations], that may interfere with the tests.
|
|
LeakTesting.settings = LeakTesting.settings.withIgnoredAll();
|
|
final FlutterMemoryAllocations ma = FlutterMemoryAllocations.instance;
|
|
|
|
PrintOverrideTestBinding();
|
|
|
|
setUp(() {
|
|
assert(!ma.hasListeners);
|
|
_checkSdkHandlersNotSet();
|
|
});
|
|
|
|
test('addListener and removeListener add and remove listeners.', () {
|
|
final ObjectEvent event = ObjectDisposed(object: 'object');
|
|
ObjectEvent? receivedEvent;
|
|
void listener(ObjectEvent event) => receivedEvent = event;
|
|
expect(ma.hasListeners, isFalse);
|
|
|
|
ma.addListener(listener);
|
|
_checkSdkHandlersSet();
|
|
ma.dispatchObjectEvent(event);
|
|
expect(receivedEvent, equals(event));
|
|
expect(ma.hasListeners, isTrue);
|
|
receivedEvent = null;
|
|
|
|
ma.removeListener(listener);
|
|
ma.dispatchObjectEvent(event);
|
|
expect(receivedEvent, isNull);
|
|
expect(ma.hasListeners, isFalse);
|
|
_checkSdkHandlersNotSet();
|
|
});
|
|
|
|
testWidgets('dispatchObjectEvent handles bad listeners', (WidgetTester tester) async {
|
|
final ObjectEvent event = ObjectDisposed(object: 'object');
|
|
final log = <String>[];
|
|
void badListener1(ObjectEvent event) {
|
|
log.add('badListener1');
|
|
throw ArgumentError();
|
|
}
|
|
|
|
void listener1(ObjectEvent event) => log.add('listener1');
|
|
void badListener2(ObjectEvent event) {
|
|
log.add('badListener2');
|
|
throw ArgumentError();
|
|
}
|
|
|
|
void listener2(ObjectEvent event) => log.add('listener2');
|
|
|
|
ma.addListener(badListener1);
|
|
_checkSdkHandlersSet();
|
|
ma.addListener(listener1);
|
|
ma.addListener(badListener2);
|
|
ma.addListener(listener2);
|
|
|
|
PrintOverrideTestBinding.runWithDebugPrintDisabled(() => ma.dispatchObjectEvent(event));
|
|
expect(log, <String>['badListener1', 'listener1', 'badListener2', 'listener2']);
|
|
expect(tester.takeException(), contains('Multiple exceptions (2)'));
|
|
|
|
ma.removeListener(badListener1);
|
|
_checkSdkHandlersSet();
|
|
ma.removeListener(listener1);
|
|
ma.removeListener(badListener2);
|
|
ma.removeListener(listener2);
|
|
_checkSdkHandlersNotSet();
|
|
|
|
log.clear();
|
|
expect(ma.hasListeners, isFalse);
|
|
ma.dispatchObjectEvent(event);
|
|
expect(log, <String>[]);
|
|
});
|
|
|
|
test('dispatchObjectEvent does not invoke concurrently added listeners', () {
|
|
final ObjectEvent event = ObjectDisposed(object: 'object');
|
|
final log = <String>[];
|
|
|
|
void listener2(ObjectEvent event) => log.add('listener2');
|
|
void listener1(ObjectEvent event) {
|
|
log.add('listener1');
|
|
ma.addListener(listener2);
|
|
}
|
|
|
|
ma.addListener(listener1);
|
|
_checkSdkHandlersSet();
|
|
|
|
ma.dispatchObjectEvent(event);
|
|
expect(log, <String>['listener1']);
|
|
log.clear();
|
|
|
|
ma.dispatchObjectEvent(event);
|
|
expect(log, <String>['listener1', 'listener2']);
|
|
log.clear();
|
|
|
|
ma.removeListener(listener1);
|
|
ma.removeListener(listener2);
|
|
_checkSdkHandlersNotSet();
|
|
|
|
expect(ma.hasListeners, isFalse);
|
|
ma.dispatchObjectEvent(event);
|
|
expect(log, <String>[]);
|
|
});
|
|
|
|
test('dispatchObjectEvent does not invoke concurrently removed listeners', () {
|
|
final ObjectEvent event = ObjectDisposed(object: 'object');
|
|
final log = <String>[];
|
|
|
|
void listener2(ObjectEvent event) => log.add('listener2');
|
|
void listener1(ObjectEvent event) {
|
|
log.add('listener1');
|
|
ma.removeListener(listener2);
|
|
expect(ma.hasListeners, isFalse);
|
|
}
|
|
|
|
ma.addListener(listener1);
|
|
ma.addListener(listener2);
|
|
|
|
ma.dispatchObjectEvent(event);
|
|
expect(log, <String>['listener1']);
|
|
log.clear();
|
|
|
|
ma.removeListener(listener1);
|
|
_checkSdkHandlersNotSet();
|
|
|
|
expect(ma.hasListeners, isFalse);
|
|
});
|
|
|
|
test('last removeListener unsubscribes from Flutter SDK events', () {
|
|
void listener1(ObjectEvent event) {}
|
|
void listener2(ObjectEvent event) {}
|
|
|
|
ma.addListener(listener1);
|
|
_checkSdkHandlersSet();
|
|
|
|
ma.addListener(listener2);
|
|
_checkSdkHandlersSet();
|
|
|
|
ma.removeListener(listener1);
|
|
_checkSdkHandlersSet();
|
|
|
|
ma.removeListener(listener2);
|
|
_checkSdkHandlersNotSet();
|
|
});
|
|
|
|
test('kFlutterMemoryAllocationsEnabled is true in debug mode.', () {
|
|
expect(kFlutterMemoryAllocationsEnabled, isTrue);
|
|
});
|
|
|
|
test('publishers in Flutter dispatch events in debug mode', () async {
|
|
var eventCount = 0;
|
|
void listener(ObjectEvent event) => eventCount++;
|
|
ma.addListener(listener);
|
|
|
|
final int expectedEventCount = await _activateFlutterObjectsAndReturnCountOfEvents();
|
|
expect(eventCount, expectedEventCount);
|
|
|
|
ma.removeListener(listener);
|
|
_checkSdkHandlersNotSet();
|
|
expect(ma.hasListeners, isFalse);
|
|
});
|
|
}
|
|
|
|
void _checkSdkHandlersSet() {
|
|
expect(Image.onCreate, isNotNull);
|
|
expect(Picture.onCreate, isNotNull);
|
|
expect(Image.onDispose, isNotNull);
|
|
expect(Picture.onDispose, isNotNull);
|
|
}
|
|
|
|
void _checkSdkHandlersNotSet() {
|
|
expect(Image.onCreate, isNull);
|
|
expect(Picture.onCreate, isNull);
|
|
expect(Image.onDispose, isNull);
|
|
expect(Picture.onDispose, isNull);
|
|
}
|
|
|
|
/// Create and dispose Flutter objects to fire memory allocation events.
|
|
Future<int> _activateFlutterObjectsAndReturnCountOfEvents() async {
|
|
var count = 0;
|
|
|
|
final valueNotifier = ValueNotifier<bool>(true);
|
|
count++;
|
|
final changeNotifier = ChangeNotifier()..addListener(() {});
|
|
count++;
|
|
final Picture picture = _createPicture();
|
|
count++;
|
|
|
|
valueNotifier.dispose();
|
|
count++;
|
|
changeNotifier.dispose();
|
|
count++;
|
|
picture.dispose();
|
|
count++;
|
|
|
|
final Image image = await _createImage();
|
|
count++;
|
|
count++;
|
|
count++;
|
|
image.dispose();
|
|
count++;
|
|
|
|
return count;
|
|
}
|
|
|
|
Future<Image> _createImage() async {
|
|
final Picture picture = _createPicture();
|
|
final Image result = await picture.toImage(10, 10);
|
|
picture.dispose();
|
|
return result;
|
|
}
|
|
|
|
Picture _createPicture() {
|
|
final recorder = PictureRecorder();
|
|
final canvas = Canvas(recorder);
|
|
const rect = Rect.fromLTWH(0.0, 0.0, 100.0, 100.0);
|
|
canvas.clipRect(rect);
|
|
return recorder.endRecording();
|
|
}
|