mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
231 lines
8.2 KiB
Dart
231 lines
8.2 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:math' as math;
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_gallery/gallery/app.dart' show GalleryApp;
|
|
import 'package:flutter_gallery/gallery/demos.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
// This title is visible on the home and demo category pages. It's
|
|
// not visible when the demos are running.
|
|
const String kGalleryTitle = 'Flutter gallery';
|
|
|
|
// All of the classes printed by debugDump etc, must have toString()
|
|
// values approved by verityToStringOutput().
|
|
int toStringErrors = 0;
|
|
|
|
// There are 3 places where the Gallery demos are traversed.
|
|
// 1- In widget tests such as dev/integration_tests/flutter_gallery/test/smoke_test.dart
|
|
// 2- In driver tests such as dev/integration_tests/flutter_gallery/test_driver/transitions_perf_test.dart
|
|
// 3- In on-device instrumentation tests such as dev/integration_tests/flutter_gallery/test/live_smoketest.dart
|
|
//
|
|
// If you change navigation behavior in the Gallery or in the framework, make
|
|
// sure all 3 are covered.
|
|
|
|
void reportToStringError(
|
|
String name,
|
|
String route,
|
|
int lineNumber,
|
|
List<String> lines,
|
|
String message,
|
|
) {
|
|
// If you're on line 12, then it has index 11.
|
|
// If you want 1 line before and 1 line after, then you want lines with index 10, 11, and 12.
|
|
// That's (lineNumber-1)-margin .. (lineNumber-1)+margin, or lineNumber-(margin+1) .. lineNumber+(margin-1)
|
|
const margin = 5;
|
|
final int firstLine = math.max(0, lineNumber - margin);
|
|
final int lastLine = math.min(lines.length, lineNumber + margin);
|
|
print(
|
|
'$name : $route : line $lineNumber of ${lines.length} : $message; nearby lines were:\n ${lines.sublist(firstLine, lastLine).join("\n ")}',
|
|
);
|
|
toStringErrors += 1;
|
|
}
|
|
|
|
void verifyToStringOutput(String name, String route, String testString) {
|
|
var lineNumber = 0;
|
|
final List<String> lines = testString.split('\n');
|
|
if (!testString.endsWith('\n')) {
|
|
reportToStringError(name, route, lines.length, lines, 'does not end with a line feed');
|
|
}
|
|
for (final line in lines) {
|
|
lineNumber += 1;
|
|
if (line == '' && lineNumber != lines.length) {
|
|
reportToStringError(name, route, lineNumber, lines, 'found empty line');
|
|
} else if (line.contains('Instance of ')) {
|
|
reportToStringError(
|
|
name,
|
|
route,
|
|
lineNumber,
|
|
lines,
|
|
'found a class that does not have its own toString',
|
|
);
|
|
} else if (line.endsWith(' ')) {
|
|
reportToStringError(name, route, lineNumber, lines, 'found a line with trailing whitespace');
|
|
}
|
|
}
|
|
}
|
|
|
|
Future<void> smokeDemo(WidgetTester tester, GalleryDemo demo) async {
|
|
// Don't use pumpUntilNoTransientCallbacks in this function, because some of
|
|
// the smoketests have infinitely-running animations (e.g. the progress
|
|
// indicators demo).
|
|
|
|
await tester.tap(find.text(demo.title));
|
|
await tester.pump(); // Launch the demo.
|
|
await tester.pump(const Duration(milliseconds: 400)); // Wait until the demo has opened.
|
|
expect(find.text(kGalleryTitle), findsNothing);
|
|
|
|
// Leave the demo on the screen briefly for manual testing.
|
|
await tester.pump(const Duration(milliseconds: 400));
|
|
|
|
// Scroll the demo around a bit.
|
|
await tester.flingFrom(const Offset(400.0, 300.0), const Offset(-100.0, 0.0), 500.0);
|
|
await tester.flingFrom(const Offset(400.0, 300.0), const Offset(0.0, -100.0), 500.0);
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 50));
|
|
await tester.pump(const Duration(milliseconds: 200));
|
|
await tester.pump(const Duration(milliseconds: 400));
|
|
|
|
// Verify that the dumps are pretty.
|
|
final String routeName = demo.routeName;
|
|
verifyToStringOutput(
|
|
'debugDumpApp',
|
|
routeName,
|
|
WidgetsBinding.instance.rootElement!.toStringDeep(),
|
|
);
|
|
verifyToStringOutput(
|
|
'debugDumpRenderTree',
|
|
routeName,
|
|
RendererBinding.instance.renderViews.single.toStringDeep(),
|
|
);
|
|
verifyToStringOutput(
|
|
'debugDumpLayerTree',
|
|
routeName,
|
|
RendererBinding.instance.renderViews.single.debugLayer?.toStringDeep() ?? '',
|
|
);
|
|
verifyToStringOutput(
|
|
'debugDumpFocusTree',
|
|
routeName,
|
|
WidgetsBinding.instance.focusManager.toStringDeep(),
|
|
);
|
|
|
|
// Scroll the demo around a bit more.
|
|
await tester.flingFrom(const Offset(400.0, 300.0), const Offset(0.0, 400.0), 1000.0);
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 400));
|
|
await tester.flingFrom(const Offset(400.0, 300.0), const Offset(-200.0, 0.0), 500.0);
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 50));
|
|
await tester.pump(const Duration(milliseconds: 200));
|
|
await tester.pump(const Duration(milliseconds: 400));
|
|
await tester.flingFrom(const Offset(400.0, 300.0), const Offset(100.0, 0.0), 500.0);
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 400));
|
|
|
|
// Go back
|
|
await tester.pageBack();
|
|
await tester.pumpAndSettle();
|
|
await tester.pump(); // Start the pop "back" operation.
|
|
await tester.pump(); // Complete the willPop() Future.
|
|
await tester.pump(const Duration(milliseconds: 400)); // Wait until it has finished.
|
|
}
|
|
|
|
Future<void> smokeOptionsPage(WidgetTester tester) async {
|
|
final Finder showOptionsPageButton = find.byTooltip('Toggle options page');
|
|
|
|
// Show the options page
|
|
await tester.tap(showOptionsPageButton);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Switch to the dark theme: first menu button, choose 'Dark'
|
|
await tester.tap(find.byIcon(Icons.arrow_drop_down).first);
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Dark'));
|
|
await tester.pumpAndSettle();
|
|
|
|
// Switch back to system theme setting: first menu button, choose 'System Default'
|
|
await tester.tap(find.byIcon(Icons.arrow_drop_down).first);
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(
|
|
find.text('System Default').at(1),
|
|
warnIfMissed: false,
|
|
); // https://github.com/flutter/flutter/issues/82908
|
|
await tester.pumpAndSettle();
|
|
|
|
// Switch text direction: first switch
|
|
await tester.tap(find.byType(Switch).first);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Switch back to system text direction: first switch control again
|
|
await tester.tap(find.byType(Switch).first);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Scroll the 'Send feedback' item into view
|
|
await tester.drag(find.text('Theme'), const Offset(0.0, -1000.0));
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Send feedback'));
|
|
await tester.pumpAndSettle();
|
|
|
|
// Close the options page
|
|
expect(showOptionsPageButton, findsOneWidget);
|
|
await tester.tap(showOptionsPageButton);
|
|
await tester.pumpAndSettle();
|
|
}
|
|
|
|
Future<void> smokeGallery(WidgetTester tester) async {
|
|
var sendFeedbackButtonPressed = false;
|
|
|
|
await tester.pumpWidget(
|
|
GalleryApp(
|
|
testMode: true,
|
|
onSendFeedback: () {
|
|
sendFeedbackButtonPressed = true; // see smokeOptionsPage()
|
|
},
|
|
),
|
|
);
|
|
await tester.pump(); // see https://github.com/flutter/flutter/issues/1865
|
|
await tester.pump(); // triggers a frame
|
|
|
|
expect(find.text(kGalleryTitle), findsOneWidget);
|
|
|
|
for (final GalleryDemoCategory category in kAllGalleryDemoCategories) {
|
|
await Scrollable.ensureVisible(tester.element(find.text(category.name)), alignment: 0.5);
|
|
await tester.tap(find.text(category.name));
|
|
await tester.pumpAndSettle();
|
|
for (final GalleryDemo demo in kGalleryCategoryToDemos[category]!) {
|
|
await Scrollable.ensureVisible(tester.element(find.text(demo.title)));
|
|
await smokeDemo(tester, demo);
|
|
tester.binding.debugAssertNoTransientCallbacks(
|
|
'A transient callback was still active after running $demo',
|
|
);
|
|
}
|
|
await tester.pageBack();
|
|
await tester.pumpAndSettle();
|
|
}
|
|
expect(toStringErrors, 0);
|
|
|
|
await smokeOptionsPage(tester);
|
|
expect(sendFeedbackButtonPressed, true);
|
|
}
|
|
|
|
void main() {
|
|
testWidgets(
|
|
'Flutter Gallery app smoke test',
|
|
smokeGallery,
|
|
variant: const TargetPlatformVariant(<TargetPlatform>{
|
|
TargetPlatform.android,
|
|
TargetPlatform.macOS,
|
|
}),
|
|
);
|
|
|
|
testWidgets('Flutter Gallery app smoke test with semantics', (WidgetTester tester) async {
|
|
final SemanticsHandle handle = SemanticsBinding.instance.ensureSemantics();
|
|
await smokeGallery(tester);
|
|
handle.dispose();
|
|
});
|
|
}
|