Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

157 lines
5.1 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:convert';
import 'dart:io';
import 'package:args/args.dart';
import 'package:file/file.dart';
import 'package:file/local.dart';
import 'package:package_config/package_config.dart';
import 'package:path/path.dart' as path;
import 'package:vm_snapshot_analysis/program_info.dart';
import 'package:vm_snapshot_analysis/v8_profile.dart';
const FileSystem fs = LocalFileSystem();
Future<void> main(List<String> args) async {
final options = Options.fromArgs(args);
final String json = options.snapshot.readAsStringSync();
final snapshot = Snapshot.fromJson(jsonDecode(json) as Map<String, dynamic>);
final ProgramInfo programInfo = toProgramInfo(snapshot);
final foundForbiddenTypes = <String>[];
var fail = false;
for (final String forbiddenType in options.forbiddenTypes) {
final int slash = forbiddenType.indexOf('/');
final int doubleColons = forbiddenType.indexOf('::');
if (slash == -1 || doubleColons < 2) {
print(
'Invalid forbidden type "$forbiddenType". The format must be <package_uri>::<type_name>, e.g. package:flutter/src/widgets/framework.dart::Widget',
);
fail = true;
continue;
}
if (!await validateType(forbiddenType, options.packageConfig)) {
foundForbiddenTypes.add('Forbidden type "$forbiddenType" does not seem to exist.');
continue;
}
final lookupPath = <String>[
forbiddenType.substring(0, slash),
forbiddenType.substring(0, doubleColons),
forbiddenType.substring(doubleColons + 2),
];
if (programInfo.lookup(lookupPath) != null) {
foundForbiddenTypes.add(forbiddenType);
}
}
if (fail) {
print('Invalid forbidden type formats. Exiting.');
exit(-1);
}
if (foundForbiddenTypes.isNotEmpty) {
print('The output contained the following forbidden types:');
print(foundForbiddenTypes.join('\n'));
exit(-1);
}
print('No forbidden types found.');
}
Future<bool> validateType(String forbiddenType, File packageConfigFile) async {
if (!forbiddenType.startsWith('package:')) {
print('Warning: Unable to validate $forbiddenType. Continuing.');
return true;
}
final Uri packageUri = Uri.parse(forbiddenType.substring(0, forbiddenType.indexOf('::')));
final String typeName = forbiddenType.substring(forbiddenType.indexOf('::') + 2);
final PackageConfig packageConfig = PackageConfig.parseString(
packageConfigFile.readAsStringSync(),
packageConfigFile.uri,
);
final Uri? packageFileUri = packageConfig.resolve(packageUri);
final File packageFile = fs.file(packageFileUri);
if (!packageFile.existsSync()) {
print('File $packageFile does not exist - forbidden type has moved or been removed.');
return false;
}
// This logic is imperfect. It will not detect mixed in types the way that
// the snapshot has them, e.g. TypeName&MixedIn&Whatever. It also assumes
// there is at least one space before and after the type name, which is not
// strictly required by the language.
final List<String> contents = packageFile.readAsStringSync().split('\n');
for (final line in contents) {
// Ignore comments.
// This will fail for multi- and intra-line comments (i.e. /* */).
if (line.trim().startsWith('//')) {
continue;
}
if (line.contains(' $typeName ')) {
return true;
}
}
return false;
}
class Options {
const Options({
required this.snapshot,
required this.packageConfig,
required this.forbiddenTypes,
});
factory Options.fromArgs(List<String> args) {
final argParser = ArgParser();
argParser.addOption(
'snapshot',
help: 'The path V8 snapshot file.',
valueHelp: '/tmp/snapshot.arm64-v8a.json',
);
argParser.addOption(
'package-config',
help: 'Dart package_config.json file generated by `pub get`.',
valueHelp: path.join(r'$FLUTTER_ROOT', '.dart_tool', 'package_config.json'),
defaultsTo: path.join(fs.currentDirectory.path, '.dart_tool', 'package_config.json'),
);
argParser.addMultiOption(
'forbidden-type',
help:
'Type name(s) to forbid from release compilation, e.g. "package:flutter/src/widgets/framework.dart::Widget".',
valueHelp: '<package_uri>::<type_name>',
);
argParser.addFlag('help', help: 'Prints usage.', negatable: false);
final ArgResults argResults = argParser.parse(args);
if (argResults['help'] == true) {
print(argParser.usage);
exit(0);
}
return Options(
snapshot: _getFileArg(argResults, 'snapshot'),
packageConfig: _getFileArg(argResults, 'package-config'),
forbiddenTypes: Set<String>.from(argResults['forbidden-type'] as List<String>),
);
}
final File snapshot;
final File packageConfig;
final Set<String> forbiddenTypes;
static File _getFileArg(ArgResults argResults, String argName) {
final File result = fs.file(argResults[argName] as String);
if (!result.existsSync()) {
print('The $argName file at $result could not be found.');
exit(-1);
}
return result;
}
}