mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
175 lines
6.1 KiB
Dart
175 lines
6.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter_devicelab/framework/metrics_center.dart';
|
|
import 'package:metrics_center/metrics_center.dart';
|
|
|
|
import 'common.dart';
|
|
|
|
class FakeFlutterDestination implements FlutterDestination {
|
|
/// Overrides the skia perf `update` function, which uploads new data to gcs if there
|
|
/// doesn't exist the commit, otherwise updates existing data by appending new ones.
|
|
@override
|
|
Future<void> update(List<MetricPoint> points, DateTime commitTime, String taskName) async {
|
|
lastUpdatedPoints = points;
|
|
time = commitTime;
|
|
name = taskName;
|
|
}
|
|
|
|
List<MetricPoint>? lastUpdatedPoints;
|
|
DateTime? time;
|
|
String? name;
|
|
}
|
|
|
|
void main() {
|
|
group('Parse', () {
|
|
test('duplicate entries for both builder name and test name', () {
|
|
final results = <String, dynamic>{
|
|
'CommitBranch': 'master',
|
|
'CommitSha': 'abc',
|
|
'BuilderName': 'Linux test',
|
|
'ResultData': <String, dynamic>{'average_frame_build_time_millis': 0.4550425531914895},
|
|
'BenchmarkScoreKeys': <String>['average_frame_build_time_millis'],
|
|
};
|
|
final List<MetricPoint> metricPoints = parse(results, <String, String>{}, 'test');
|
|
|
|
expect(metricPoints.length, 1);
|
|
expect(metricPoints[0].value, equals(0.4550425531914895));
|
|
expect(metricPoints[0].tags[kNameKey], 'test');
|
|
});
|
|
|
|
test('without additional benchmark tags', () {
|
|
final results = <String, dynamic>{
|
|
'CommitBranch': 'master',
|
|
'CommitSha': 'abc',
|
|
'BuilderName': 'test',
|
|
'ResultData': <String, dynamic>{
|
|
'average_frame_build_time_millis': 0.4550425531914895,
|
|
'90th_percentile_frame_build_time_millis': 0.473,
|
|
},
|
|
'BenchmarkScoreKeys': <String>[
|
|
'average_frame_build_time_millis',
|
|
'90th_percentile_frame_build_time_millis',
|
|
],
|
|
};
|
|
final List<MetricPoint> metricPoints = parse(results, <String, String>{}, 'task abc');
|
|
|
|
expect(metricPoints[0].value, equals(0.4550425531914895));
|
|
expect(metricPoints[1].value, equals(0.473));
|
|
});
|
|
|
|
test('with additional benchmark tags', () {
|
|
final results = <String, dynamic>{
|
|
'CommitBranch': 'master',
|
|
'CommitSha': 'abc',
|
|
'BuilderName': 'test',
|
|
'ResultData': <String, dynamic>{
|
|
'average_frame_build_time_millis': 0.4550425531914895,
|
|
'90th_percentile_frame_build_time_millis': 0.473,
|
|
},
|
|
'BenchmarkScoreKeys': <String>[
|
|
'average_frame_build_time_millis',
|
|
'90th_percentile_frame_build_time_millis',
|
|
],
|
|
};
|
|
final tags = <String, dynamic>{
|
|
'arch': 'intel',
|
|
'device_type': 'Moto G Play',
|
|
'device_version': 'android-25',
|
|
'host_type': 'linux',
|
|
'host_version': 'debian-10.11',
|
|
};
|
|
final List<MetricPoint> metricPoints = parse(results, tags, 'task abc');
|
|
|
|
expect(metricPoints[0].value, equals(0.4550425531914895));
|
|
expect(metricPoints[0].tags.keys.contains('arch'), isTrue);
|
|
expect(metricPoints[1].value, equals(0.473));
|
|
expect(metricPoints[1].tags.keys.contains('device_type'), isTrue);
|
|
});
|
|
|
|
test('succeeds - null ResultData', () {
|
|
final results = <String, dynamic>{
|
|
'CommitBranch': 'master',
|
|
'CommitSha': 'abc',
|
|
'BuilderName': 'test',
|
|
'ResultData': null,
|
|
'BenchmarkScoreKeys': null,
|
|
};
|
|
final List<MetricPoint> metricPoints = parse(results, <String, String>{}, 'tetask abcst');
|
|
|
|
expect(metricPoints.length, 0);
|
|
});
|
|
});
|
|
|
|
group('Update', () {
|
|
test('without taskName', () async {
|
|
final results = <String, dynamic>{
|
|
'CommitBranch': 'master',
|
|
'CommitSha': 'abc',
|
|
'BuilderName': 'test',
|
|
'ResultData': <String, dynamic>{
|
|
'average_frame_build_time_millis': 0.4550425531914895,
|
|
'90th_percentile_frame_build_time_millis': 0.473,
|
|
},
|
|
'BenchmarkScoreKeys': <String>[
|
|
'average_frame_build_time_millis',
|
|
'90th_percentile_frame_build_time_millis',
|
|
],
|
|
};
|
|
final List<MetricPoint> metricPoints = parse(results, <String, String>{}, 'task abc');
|
|
final flutterDestination = FakeFlutterDestination();
|
|
const taskName = 'default';
|
|
const commitTimeSinceEpoch = 1629220312;
|
|
|
|
await upload(flutterDestination, metricPoints, commitTimeSinceEpoch, taskName);
|
|
|
|
expect(flutterDestination.name, 'default');
|
|
});
|
|
|
|
test('with taskName', () async {
|
|
final results = <String, dynamic>{
|
|
'CommitBranch': 'master',
|
|
'CommitSha': 'abc',
|
|
'BuilderName': 'test',
|
|
'ResultData': <String, dynamic>{
|
|
'average_frame_build_time_millis': 0.4550425531914895,
|
|
'90th_percentile_frame_build_time_millis': 0.473,
|
|
},
|
|
'BenchmarkScoreKeys': <String>[
|
|
'average_frame_build_time_millis',
|
|
'90th_percentile_frame_build_time_millis',
|
|
],
|
|
};
|
|
final List<MetricPoint> metricPoints = parse(results, <String, String>{}, 'task abc');
|
|
final flutterDestination = FakeFlutterDestination();
|
|
const taskName = 'test';
|
|
const commitTimeSinceEpoch = 1629220312;
|
|
|
|
await upload(flutterDestination, metricPoints, commitTimeSinceEpoch, taskName);
|
|
|
|
expect(flutterDestination.name, taskName);
|
|
});
|
|
});
|
|
|
|
group('metric file name', () {
|
|
test('without tags', () async {
|
|
final tags = <String, dynamic>{};
|
|
final String fileName = metricFileName('test', tags);
|
|
expect(fileName, 'test');
|
|
});
|
|
|
|
test('with device tags', () async {
|
|
final tags = <String, dynamic>{'device_type': 'ab-c'};
|
|
final String fileName = metricFileName('test', tags);
|
|
expect(fileName, 'test_abc');
|
|
});
|
|
|
|
test('with device host and arch tags', () async {
|
|
final tags = <String, dynamic>{'device_type': 'ab-c', 'host_type': 'de-f', 'arch': 'm1'};
|
|
final String fileName = metricFileName('test', tags);
|
|
expect(fileName, 'test_m1_def_abc');
|
|
});
|
|
});
|
|
}
|