flutter_flutter/dev/devicelab/bin/tasks/hello_world_impeller.dart
Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

77 lines
2.9 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async' show Completer, StreamSubscription;
import 'dart:io' show Directory, Process;
import 'package:flutter_devicelab/framework/devices.dart'
show Device, DeviceOperatingSystem, deviceOperatingSystem, devices;
import 'package:flutter_devicelab/framework/framework.dart' show task;
import 'package:flutter_devicelab/framework/task_result.dart' show TaskResult;
import 'package:flutter_devicelab/framework/utils.dart'
show dir, flutter, flutterDirectory, inDirectory, startFlutter;
import 'package:path/path.dart' as path;
Future<TaskResult> run() async {
deviceOperatingSystem = DeviceOperatingSystem.android;
final Device device = await devices.workingDevice;
await device.unlock();
final Directory appDir = dir(path.join(flutterDirectory.path, 'examples/hello_world'));
var isUsingValidationLayers = false;
var hasValidationErrors = false;
var invalidBackendCount = 0;
final didReceiveBackendMessage = Completer<void>();
await inDirectory(appDir, () async {
await flutter('packages', options: <String>['get']);
const validationLayersMessage =
'Using the Impeller rendering backend (Vulkan with Validation Layers)';
final StreamSubscription<String> adb = device.logcat.listen((String data) {
if (data.contains('Using the Impeller rendering backend')) {
// Sometimes more than one of these will be printed out if there is a
// fallback.
if (!data.contains(validationLayersMessage)) {
invalidBackendCount += 1;
}
if (!didReceiveBackendMessage.isCompleted) {
didReceiveBackendMessage.complete();
}
}
if (data.contains(validationLayersMessage)) {
isUsingValidationLayers = true;
}
// "ImpellerValidationBreak" comes from the engine:
// https://github.com/flutter/engine/blob/4160ebacdae2081d6f3160432f5f0dd87dbebec1/impeller/base/validation.cc#L40
if (data.contains('ImpellerValidationBreak')) {
hasValidationErrors = true;
}
});
final Process process = await startFlutter(
'run',
options: <String>['--enable-impeller', '--enable-vulkan-validation', '-d', device.deviceId],
);
await didReceiveBackendMessage.future;
// Since we are waiting for the lack of errors, there is no determinate
// amount of time we can wait.
await Future<void>.delayed(const Duration(seconds: 30));
process.stdin.write('q');
await adb.cancel();
});
if (!isUsingValidationLayers || invalidBackendCount != 0) {
return TaskResult.failure('Not using Vulkan validation layers.');
}
if (hasValidationErrors) {
return TaskResult.failure('Impeller validation errors detected.');
}
return TaskResult.success(null);
}
Future<void> main() async {
await task(run);
}