mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
147 lines
4.6 KiB
Dart
147 lines
4.6 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io' show File, Platform;
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:collection/collection.dart';
|
|
import 'package:flutter_devicelab/framework/devices.dart';
|
|
import 'package:flutter_devicelab/framework/framework.dart';
|
|
import 'package:flutter_devicelab/framework/task_result.dart';
|
|
import 'package:flutter_devicelab/framework/utils.dart';
|
|
import 'package:flutter_devicelab/tasks/integration_tests.dart';
|
|
import 'package:path/path.dart' as path;
|
|
import 'package:standard_message_codec/standard_message_codec.dart';
|
|
|
|
Future<void> main() async {
|
|
deviceOperatingSystem = DeviceOperatingSystem.android;
|
|
await task(() async {
|
|
await createFlavorsTest().call();
|
|
await createIntegrationTestFlavorsTest().call();
|
|
|
|
final projectPath = '${flutterDirectory.path}/dev/integration_tests/flavors';
|
|
final TaskResult installTestsResult = await inDirectory(projectPath, () async {
|
|
final testResults = <TaskResult>[
|
|
await _testInstallDebugPaidFlavor(projectPath),
|
|
await _testInstallBogusFlavor(),
|
|
];
|
|
|
|
final TaskResult? firstInstallFailure = testResults.firstWhereOrNull(
|
|
(TaskResult element) => element.failed,
|
|
);
|
|
|
|
return firstInstallFailure ?? TaskResult.success(null);
|
|
});
|
|
|
|
await _testFlavorsWhenBuildStartsWithGradle(projectPath);
|
|
|
|
return installTestsResult;
|
|
});
|
|
}
|
|
|
|
// Ensures installation works. Also tests asset bundling while we are at it.
|
|
Future<TaskResult> _testInstallDebugPaidFlavor(String projectDir) async {
|
|
await evalFlutter('install', options: <String>['--debug', '--flavor', 'paid']);
|
|
|
|
final Uint8List assetManifestFileData = File(
|
|
path.join(
|
|
projectDir,
|
|
'build',
|
|
'app',
|
|
'intermediates',
|
|
'assets',
|
|
'paidDebug',
|
|
'mergePaidDebugAssets',
|
|
'flutter_assets',
|
|
'AssetManifest.bin',
|
|
),
|
|
).readAsBytesSync();
|
|
|
|
final assetManifest =
|
|
const StandardMessageCodec().decodeMessage(ByteData.sublistView(assetManifestFileData))
|
|
as Map<Object?, Object?>;
|
|
|
|
if (assetManifest.containsKey('assets/free/free.txt')) {
|
|
return TaskResult.failure(
|
|
'Expected the asset "assets/free/free.txt", which '
|
|
' was declared with a flavor of "free" to not be included in the asset bundle '
|
|
' because the --flavor was set to "paid".',
|
|
);
|
|
}
|
|
|
|
if (!assetManifest.containsKey('assets/paid/paid.txt')) {
|
|
return TaskResult.failure(
|
|
'Expected the asset "assets/paid/paid.txt", which '
|
|
' was declared with a flavor of "paid" to be included in the asset bundle '
|
|
' because the --flavor was set to "paid".',
|
|
);
|
|
}
|
|
|
|
await flutter('install', options: <String>['--debug', '--flavor', 'paid', '--uninstall-only']);
|
|
|
|
return TaskResult.success(null);
|
|
}
|
|
|
|
Future<TaskResult> _testInstallBogusFlavor() async {
|
|
final stderr = StringBuffer();
|
|
await evalFlutter(
|
|
'install',
|
|
canFail: true,
|
|
stderr: stderr,
|
|
options: <String>['--flavor', 'bogus'],
|
|
);
|
|
|
|
final stderrString = stderr.toString();
|
|
final String expectedApkPath = path.join(
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'flutter-apk',
|
|
'app-bogus-release.apk',
|
|
);
|
|
if (!stderrString.contains('"$expectedApkPath" does not exist.')) {
|
|
print(stderrString);
|
|
return TaskResult.failure('Should not succeed with bogus flavor');
|
|
}
|
|
|
|
return TaskResult.success(null);
|
|
}
|
|
|
|
Future<TaskResult> _testFlavorsWhenBuildStartsWithGradle(String projectDir) async {
|
|
final gradlew = Platform.isWindows ? 'gradlew.bat' : 'gradlew';
|
|
final gradlewExecutable = Platform.isWindows ? '.\\$gradlew' : './$gradlew';
|
|
|
|
final androidDirPath = '$projectDir/android';
|
|
final stdout = StringBuffer();
|
|
|
|
// Prebuild the project to generate the Android gradle wrapper files.
|
|
await inDirectory(projectDir, () async {
|
|
await flutter('build', options: <String>['apk', '--config-only']);
|
|
});
|
|
|
|
await inDirectory(androidDirPath, () async {
|
|
await exec(gradlewExecutable, <String>['clean']);
|
|
await exec(gradlewExecutable, <String>[':app:assemblePaidDebug', '--info'], output: stdout);
|
|
});
|
|
|
|
final stdoutString = stdout.toString();
|
|
|
|
if (!stdoutString.contains('-dFlavor=paid')) {
|
|
return TaskResult.failure('Expected to see -dFlavor=paid in the gradle verbose output');
|
|
}
|
|
|
|
final String appPath = path.join(
|
|
projectDir,
|
|
'build',
|
|
'app',
|
|
'outputs',
|
|
'flutter-apk',
|
|
'app-paid-debug.apk',
|
|
);
|
|
|
|
return createFlavorsTest(
|
|
extraOptions: <String>['--flavor', 'paid', '--use-application-binary=$appPath'],
|
|
).call();
|
|
}
|