Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

166 lines
5.4 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/foundation.dart';
import '../common.dart';
const int _kNumIterations = 65536;
const int _kNumWarmUp = 100;
const int _kScale = 1000;
Future<void> execute() async {
assert(false, "Don't run benchmarks in debug mode! Use 'flutter run --release'.");
// In the following benchmarks, we won't remove the listeners when we don't
// want to measure removeListener because we know that everything will be
// GC'ed in the end.
// Not removing listeners would cause memory leaks in a real application.
final printer = BenchmarkResultPrinter();
void runAddListenerBenchmark(int iteration, {bool addResult = true}) {
const name = 'add';
for (var listenerCount = 1; listenerCount <= 5; listenerCount += 1) {
final notifiers = List<_Notifier>.generate(iteration, (_) => _Notifier(), growable: false);
final watch = Stopwatch();
watch.start();
for (var i = 0; i < iteration; i += 1) {
for (var l = 0; l < listenerCount; l += 1) {
notifiers[i].addListener(() {});
}
}
watch.stop();
final int elapsed = watch.elapsedMicroseconds;
final double averagePerIteration = elapsed / iteration;
if (addResult) {
printer.addResult(
description: '$name ($listenerCount listeners)',
value: averagePerIteration * _kScale,
unit: 'ns per iteration',
name: '$name$listenerCount',
);
}
}
}
void runNotifyListenerBenchmark(int iteration, {bool addResult = true}) {
const name = 'notify';
for (var listenerCount = 0; listenerCount <= 5; listenerCount += 1) {
final notifier = _Notifier();
for (var i = 1; i <= listenerCount; i += 1) {
notifier.addListener(() {});
}
final watch = Stopwatch();
watch.start();
for (var i = 0; i < iteration; i += 1) {
notifier.notify();
}
watch.stop();
final int elapsed = watch.elapsedMicroseconds;
final double averagePerIteration = elapsed / iteration;
if (addResult) {
printer.addResult(
description: '$name ($listenerCount listeners)',
value: averagePerIteration * _kScale,
unit: 'ns per iteration',
name: '$name$listenerCount',
);
}
}
}
void runRemoveListenerBenchmark(int iteration, {bool addResult = true}) {
const name = 'remove';
final listeners = <VoidCallback>[() {}, () {}, () {}, () {}, () {}];
for (var listenerCount = 1; listenerCount <= 5; listenerCount += 1) {
final notifiers = List<_Notifier>.generate(iteration, (_) {
final notifier = _Notifier();
for (var l = 0; l < listenerCount; l += 1) {
notifier.addListener(listeners[l]);
}
return notifier;
}, growable: false);
final watch = Stopwatch();
watch.start();
for (var i = 0; i < iteration; i += 1) {
for (var l = 0; l < listenerCount; l += 1) {
notifiers[i].removeListener(listeners[l]);
}
}
watch.stop();
final int elapsed = watch.elapsedMicroseconds;
final double averagePerIteration = elapsed / iteration;
if (addResult) {
printer.addResult(
description: '$name ($listenerCount listeners)',
value: averagePerIteration * _kScale,
unit: 'ns per iteration',
name: '$name$listenerCount',
);
}
}
}
void runRemoveListenerWhileNotifyingBenchmark(int iteration, {bool addResult = true}) {
const name = 'removeWhileNotify';
final listeners = <VoidCallback>[() {}, () {}, () {}, () {}, () {}];
for (var listenerCount = 1; listenerCount <= 5; listenerCount += 1) {
final notifiers = List<_Notifier>.generate(iteration, (_) {
final notifier = _Notifier();
notifier.addListener(() {
// This listener will remove all other listeners. So that only this
// one is called and measured.
for (var l = 0; l < listenerCount; l += 1) {
notifier.removeListener(listeners[l]);
}
});
for (var l = 0; l < listenerCount; l += 1) {
notifier.addListener(listeners[l]);
}
return notifier;
}, growable: false);
final watch = Stopwatch();
watch.start();
for (var i = 0; i < iteration; i += 1) {
notifiers[i].notify();
}
watch.stop();
final int elapsed = watch.elapsedMicroseconds;
final double averagePerIteration = elapsed / iteration;
if (addResult) {
printer.addResult(
description: '$name ($listenerCount listeners)',
value: averagePerIteration * _kScale,
unit: 'ns per iteration',
name: '$name$listenerCount',
);
}
}
}
runAddListenerBenchmark(_kNumWarmUp, addResult: false);
runAddListenerBenchmark(_kNumIterations);
runNotifyListenerBenchmark(_kNumWarmUp, addResult: false);
runNotifyListenerBenchmark(_kNumIterations);
runRemoveListenerBenchmark(_kNumWarmUp, addResult: false);
runRemoveListenerBenchmark(_kNumIterations);
runRemoveListenerWhileNotifyingBenchmark(_kNumWarmUp, addResult: false);
runRemoveListenerWhileNotifyingBenchmark(_kNumIterations);
printer.printToStdout();
}
class _Notifier extends ChangeNotifier {
void notify() => notifyListeners();
}