mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
284ec6804d
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/174082 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples The `MenuController` class is marked `final` and breaks apps that extend this class. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Apps that used to rely on extended `MenuController`s won't build. ### Workaround: Is there a workaround for this issue? The app will have to modify their local Flutter repository. Otherwise, if the app really rely on extending the `MenuController` class to do custom logic, I can think of no ways for them to continue this customization under this restriction. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? The following snippet builds. ``` import 'package:flutter/material.dart'; class ExtendedMenuController extends MenuController { ExtendedMenuController(); } ```