Gray Mackall
2948917a47
[Reland] Force automatic ndk download when building for Android (#160260)
Relands https://github.com/flutter/flutter/pull/159756.
The original caused some stderr because
1. the configurable `ndkVersion` value that AGP provides used to be null
by default.
2. Now it is not, instead it has a default value
3. `integration_test` doesn't actually use the NDK, but default for
`integration_test` was higher that `flutter.ndkVersion`
4. We have code that checks if a plugin uses a higher ndk version and
tells you to consider upgrading
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L921
This reverts the revert, and then aligns `integration_test`'s NDK
version (which again, it doesn't actually use, so I'm not too concerned
about the downgrade) with `flutter.ndkVersion`.
It also starts using the `flutter.min/compile/ndkVersion` values in
`integration_test`, which was unrelated to the original pr. Can remove
if you think it should land separately.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2024-12-13 20:27:23 +00:00
..
2022-02-28 10:16:21 -08:00
2024-08-21 18:27:00 +00:00
2024-10-29 18:01:19 +00:00
2022-03-01 15:26:21 -08:00
2022-10-04 03:37:22 +00:00
2022-02-08 16:10:43 -08:00
2024-12-04 18:13:07 +00:00
2024-01-03 01:17:08 +00:00
2024-01-24 23:11:12 +00:00
2023-08-09 10:57:35 -07:00
2023-08-09 10:57:35 -07:00
2023-08-09 10:57:35 -07:00
2023-03-31 20:54:51 +00:00
2023-03-31 20:54:51 +00:00
2023-08-03 22:31:06 +00:00
2022-11-29 01:59:19 +00:00
2022-04-25 18:14:06 -07:00
2022-08-26 14:06:26 -07:00
2023-01-18 22:33:49 +00:00
2022-08-26 15:29:14 +00:00
2024-11-22 19:41:08 +00:00
2024-12-05 21:32:58 +00:00
2024-12-05 21:32:58 +00:00
2024-10-23 23:35:10 +00:00
2022-09-08 22:39:07 +00:00
2022-05-13 14:04:06 +08:00
2022-08-26 14:06:26 -07:00
2022-03-16 19:15:13 -07:00
2022-07-20 19:13:06 +00:00
2022-08-25 23:35:00 +00:00
2024-06-17 17:14:47 +00:00
2022-08-26 18:50:07 +00:00
2023-12-04 19:23:26 +00:00
2023-12-04 19:23:26 +00:00
2023-01-19 21:29:19 +00:00
2024-04-17 21:08:47 +00:00
2022-08-17 09:38:41 -04:00
2023-08-14 18:47:08 +00:00
2023-08-14 18:47:08 +00:00
2023-08-14 18:47:08 +00:00
2023-05-15 19:14:58 +00:00
2023-08-14 18:47:08 +00:00
2023-08-14 18:47:08 +00:00
2023-08-14 18:47:08 +00:00
2024-04-17 21:08:47 +00:00
2023-08-14 18:47:08 +00:00
2023-08-14 18:47:08 +00:00
2024-10-22 17:28:31 +00:00
2022-03-28 18:15:10 -07:00
2024-01-26 01:07:08 +00:00
2024-07-29 20:15:25 +00:00
2022-07-12 21:41:08 +00:00
2022-07-12 21:41:08 +00:00
2024-02-23 19:02:22 +00:00
2023-12-21 20:30:21 +00:00
2024-10-29 18:01:19 +00:00
2024-09-17 19:17:06 +00:00
2024-10-21 21:50:04 +00:00
2024-06-17 17:14:47 +00:00
2023-05-10 00:50:11 +00:00
2022-09-07 20:19:20 +00:00
2022-09-07 20:19:20 +00:00
2022-05-12 09:54:10 -07:00
2022-08-26 17:29:39 +00:00
2022-09-08 16:49:17 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2022-08-17 09:38:41 -04:00
2022-08-17 09:38:41 -04:00
2023-03-08 19:44:40 +00:00
2023-04-21 22:33:07 +00:00
2022-09-14 23:44:14 +00:00
2022-08-17 09:38:41 -04:00
2022-08-26 14:06:26 -07:00
2022-04-08 17:20:22 -07:00
2022-04-08 17:20:22 -07:00
2022-04-08 17:20:22 -07:00
2024-12-13 20:27:23 +00:00
2022-04-27 09:15:35 +02:00
2022-04-20 22:34:07 -07:00
2024-12-04 18:13:07 +00:00
2024-04-17 21:08:47 +00:00
2024-10-09 08:40:04 -07:00
2022-08-24 18:04:42 +00:00
2022-08-17 09:38:41 -04:00
2024-03-18 18:51:26 +00:00
2023-10-12 15:53:00 +00:00
2022-10-18 22:26:16 +00:00
2022-10-20 03:23:12 +00:00
2022-08-26 14:06:26 -07:00
2022-09-26 17:45:19 +00:00
2022-10-27 22:05:05 +00:00
2024-10-31 21:31:07 +00:00
2023-03-10 16:16:30 +00:00
2022-06-21 18:17:07 +00:00
2024-10-31 21:31:07 +00:00
2024-12-05 17:07:12 +00:00
2024-12-05 17:07:12 +00:00
2023-12-07 16:29:11 +00:00
2024-05-23 18:30:55 +02:00
2023-09-10 08:07:13 +00:00
2022-09-07 22:45:26 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2024-02-15 22:32:38 +00:00
2022-06-27 23:36:06 +00:00
2022-01-27 13:25:17 -08:00
2022-01-27 13:25:17 -08:00
2022-07-21 20:01:06 +00:00
2023-03-23 11:56:23 -07:00
2022-06-30 14:54:07 +00:00
2024-04-17 21:08:47 +00:00
2022-09-08 19:35:20 +00:00
2022-08-17 09:38:41 -04:00
2024-03-16 05:44:21 +00:00
2024-07-08 21:01:58 +00:00
2023-06-23 18:40:17 -07:00
2023-03-10 16:16:30 +00:00
2024-12-05 21:39:53 +00:00
2023-12-19 20:19:52 +00:00
2024-01-16 15:36:38 +00:00
2023-02-15 19:13:11 +00:00
2023-01-09 10:33:03 -08:00
2023-01-24 18:23:57 +00:00
2023-05-15 17:55:55 +00:00
2024-04-17 21:08:47 +00:00
2023-03-08 19:44:40 +00:00
2024-05-29 22:19:10 +00:00
2024-05-29 22:19:10 +00:00
2022-12-12 22:39:49 +00:00
2023-01-13 19:17:12 +00:00
2022-12-12 22:39:49 +00:00
2022-12-12 22:39:49 +00:00
2023-01-13 19:17:12 +00:00
2022-11-08 23:00:04 +00:00
2022-12-08 14:05:53 -08:00
2022-12-06 21:57:25 +00:00
2024-04-17 21:08:47 +00:00
2022-03-28 00:15:07 -07:00
2023-04-24 23:25:28 +00:00
2022-12-20 14:15:39 -08:00
2022-07-28 09:07:49 -07:00
2023-11-29 08:41:27 +00:00
2022-12-22 02:47:11 +00:00
2022-08-17 16:16:02 +00:00
2023-08-14 18:47:08 +00:00
2023-08-14 18:47:08 +00:00
2022-11-08 09:26:55 -08:00
2023-08-31 19:03:14 +00:00
2023-08-31 19:03:14 +00:00
2024-11-15 16:24:20 +00:00
2024-11-15 16:24:20 +00:00
2024-11-15 16:24:20 +00:00
2023-02-13 22:33:19 +00:00
2024-10-31 21:31:07 +00:00
2022-03-04 15:41:14 -08:00
2022-08-25 18:54:20 -07:00