mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Following https://github.com/flutter/flutter/pull/176992, this PR fixes all leaks in `flutter_test` tests. A new method is added to reliably dispose the root layer of render views. Feel free to let me know if you have suggestions for the name! ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
188 lines
6.7 KiB
Dart
188 lines
6.7 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
|
|
// dependencies have been fixed.
|
|
// https://github.com/flutter/flutter/issues/85160
|
|
// Fails with "flutter test --test-randomize-ordering-seed=20210721"
|
|
@Tags(<String>['no-shuffle'])
|
|
library;
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
testWidgets('enterText works', (WidgetTester tester) async {
|
|
await tester.pumpWidget(const MaterialApp(home: Material(child: TextField())));
|
|
|
|
final EditableTextState state = tester.state(find.byType(EditableText));
|
|
expect(state.textEditingValue.text, '');
|
|
|
|
await tester.enterText(find.byType(EditableText), 'let there be text');
|
|
expect(state.textEditingValue.text, 'let there be text');
|
|
expect(state.textEditingValue.selection.isCollapsed, isTrue);
|
|
expect(state.textEditingValue.selection.baseOffset, 17);
|
|
});
|
|
|
|
group('method call handler', () {
|
|
tearDown(() {
|
|
// Since all of these tests call setMethodCallHandler, reset the default
|
|
// method call handler here.
|
|
TextInput.setChannel(SystemChannels.textInput);
|
|
});
|
|
|
|
testWidgets(
|
|
'receiveAction() forwards exception when exception occurs during action processing',
|
|
(WidgetTester tester) async {
|
|
// Setup a widget that can receive focus so that we can open the keyboard.
|
|
const Widget widget = MaterialApp(home: Material(child: TextField()));
|
|
await tester.pumpWidget(widget);
|
|
|
|
// Keyboard must be shown for receiveAction() to function.
|
|
await tester.showKeyboard(find.byType(TextField));
|
|
|
|
// Register a handler for the text input channel that throws an error. This
|
|
// error should be reported within a PlatformException by TestTextInput.
|
|
SystemChannels.textInput.setMethodCallHandler((MethodCall call) {
|
|
throw FlutterError('A fake error occurred during action processing.');
|
|
});
|
|
|
|
await expectLater(
|
|
() => tester.testTextInput.receiveAction(TextInputAction.done),
|
|
throwsA(isA<PlatformException>()),
|
|
);
|
|
},
|
|
);
|
|
|
|
testWidgets('selectors are called on macOS', (WidgetTester tester) async {
|
|
List<dynamic>? selectorNames;
|
|
await SystemChannels.textInput.invokeMethod('TextInput.setClient', <dynamic>[
|
|
1,
|
|
<String, dynamic>{},
|
|
]);
|
|
await SystemChannels.textInput.invokeMethod('TextInput.show');
|
|
SystemChannels.textInput.setMethodCallHandler((MethodCall call) async {
|
|
if (call.method == 'TextInputClient.performSelectors') {
|
|
selectorNames = (call.arguments as List<dynamic>)[1] as List<dynamic>;
|
|
}
|
|
});
|
|
await tester.sendKeyDownEvent(LogicalKeyboardKey.altLeft);
|
|
await tester.sendKeyDownEvent(LogicalKeyboardKey.arrowUp);
|
|
await SystemChannels.textInput.invokeMethod('TextInput.clearClient');
|
|
|
|
if (defaultTargetPlatform == TargetPlatform.macOS) {
|
|
expect(selectorNames, <dynamic>['moveBackward:', 'moveToBeginningOfParagraph:']);
|
|
} else {
|
|
expect(selectorNames, isNull);
|
|
}
|
|
}, variant: TargetPlatformVariant.all());
|
|
|
|
testWidgets('selector is called for ctrl + backspace on macOS', (WidgetTester tester) async {
|
|
List<dynamic>? selectorNames;
|
|
await SystemChannels.textInput.invokeMethod('TextInput.setClient', <dynamic>[
|
|
1,
|
|
<String, dynamic>{},
|
|
]);
|
|
await SystemChannels.textInput.invokeMethod('TextInput.show');
|
|
SystemChannels.textInput.setMethodCallHandler((MethodCall call) async {
|
|
if (call.method == 'TextInputClient.performSelectors') {
|
|
selectorNames = (call.arguments as List<dynamic>)[1] as List<dynamic>;
|
|
}
|
|
});
|
|
await tester.sendKeyDownEvent(LogicalKeyboardKey.control);
|
|
await tester.sendKeyDownEvent(LogicalKeyboardKey.backspace);
|
|
await tester.sendKeyUpEvent(LogicalKeyboardKey.backspace);
|
|
await tester.sendKeyUpEvent(LogicalKeyboardKey.control);
|
|
await SystemChannels.textInput.invokeMethod('TextInput.clearClient');
|
|
|
|
if (defaultTargetPlatform == TargetPlatform.macOS) {
|
|
expect(selectorNames, <dynamic>['deleteBackwardByDecomposingPreviousCharacter:']);
|
|
} else {
|
|
expect(selectorNames, isNull);
|
|
}
|
|
}, variant: TargetPlatformVariant.all());
|
|
});
|
|
|
|
// Run this test twice to ensure that the TestTextInputKeyHandler is cleared
|
|
// between tests.
|
|
// Regression test for https://github.com/flutter/flutter/issues/171491.
|
|
for (var i = 0; i < 2; i++) {
|
|
testWidgets(
|
|
'keyboard shortcut handling is cleared between tests (${i + 1}/2)',
|
|
(WidgetTester tester) async {
|
|
final client = _PerformSelectorInputClient();
|
|
|
|
final focusNode = FocusNode();
|
|
addTearDown(focusNode.dispose);
|
|
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: Scaffold(
|
|
body: Focus(focusNode: focusNode, autofocus: true, child: Container()),
|
|
),
|
|
),
|
|
);
|
|
|
|
final TextInputConnection connection = TextInput.attach(
|
|
client,
|
|
const TextInputConfiguration(),
|
|
);
|
|
addTearDown(() {
|
|
connection.close();
|
|
});
|
|
connection.show();
|
|
|
|
// Press the left arrow, which should trigger a "moveLeft:" selector call.
|
|
await tester.sendKeyEvent(LogicalKeyboardKey.arrowLeft, platform: 'macos');
|
|
|
|
expect(client.performSelectorCalled, isTrue);
|
|
},
|
|
variant: TargetPlatformVariant.only(TargetPlatform.macOS),
|
|
);
|
|
}
|
|
}
|
|
|
|
/// A [TextInputClient] that reports whether the `performSelector` method was
|
|
/// called.
|
|
class _PerformSelectorInputClient with TextInputClient {
|
|
bool get performSelectorCalled => _performSelectorCalled;
|
|
bool _performSelectorCalled = false;
|
|
|
|
@override
|
|
AutofillScope? get currentAutofillScope => null;
|
|
|
|
@override
|
|
TextEditingValue? get currentTextEditingValue => _currentTextEditingValue;
|
|
TextEditingValue _currentTextEditingValue = TextEditingValue.empty;
|
|
|
|
@override
|
|
void performSelector(String selectorName) {
|
|
super.performSelector(selectorName);
|
|
_performSelectorCalled = true;
|
|
}
|
|
|
|
@override
|
|
void connectionClosed() {}
|
|
|
|
@override
|
|
void updateEditingValue(TextEditingValue value) {
|
|
_currentTextEditingValue = value;
|
|
}
|
|
|
|
@override
|
|
void performAction(TextInputAction action) {}
|
|
|
|
@override
|
|
void performPrivateCommand(String action, Map<String, dynamic> data) {}
|
|
|
|
@override
|
|
void showAutocorrectionPromptRect(int start, int end) {}
|
|
|
|
@override
|
|
void updateFloatingCursor(RawFloatingCursorPoint point) {}
|
|
}
|