Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

210 lines
6.2 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
class TestFlowDelegate extends FlowDelegate {
TestFlowDelegate({required this.startOffset}) : super(repaint: startOffset);
final Animation<double> startOffset;
@override
BoxConstraints getConstraintsForChild(int i, BoxConstraints constraints) {
return constraints.loosen();
}
@override
void paintChildren(FlowPaintingContext context) {
double dy = startOffset.value;
for (var i = 0; i < context.childCount; ++i) {
context.paintChild(i, transform: Matrix4.translationValues(0.0, dy, 0.0));
dy += 0.75 * context.getChildSize(i)!.height;
}
}
@override
bool shouldRepaint(TestFlowDelegate oldDelegate) => startOffset == oldDelegate.startOffset;
}
class OpacityFlowDelegate extends FlowDelegate {
OpacityFlowDelegate(this.opacity);
double opacity;
@override
void paintChildren(FlowPaintingContext context) {
for (var i = 0; i < context.childCount; ++i) {
context.paintChild(i, opacity: opacity);
}
}
@override
bool shouldRepaint(OpacityFlowDelegate oldDelegate) => opacity != oldDelegate.opacity;
}
// OpacityFlowDelegate that paints one of its children twice
class DuplicatePainterOpacityFlowDelegate extends OpacityFlowDelegate {
DuplicatePainterOpacityFlowDelegate(super.opacity);
@override
void paintChildren(FlowPaintingContext context) {
for (var i = 0; i < context.childCount; ++i) {
context.paintChild(i, opacity: opacity);
}
if (context.childCount > 0) {
context.paintChild(0, opacity: opacity);
}
}
}
void main() {
testWidgets('Flow control test', (WidgetTester tester) async {
final startOffset = AnimationController.unbounded(vsync: tester);
addTearDown(startOffset.dispose);
final log = <int>[];
Widget buildBox(int i) {
return GestureDetector(
onTap: () {
log.add(i);
},
child: Container(
width: 100.0,
height: 100.0,
color: const Color(0xFF0000FF),
child: Text('$i', textDirection: TextDirection.ltr),
),
);
}
await tester.pumpWidget(
Flow(
delegate: TestFlowDelegate(startOffset: startOffset),
children: <Widget>[
buildBox(0),
buildBox(1),
buildBox(2),
buildBox(3),
buildBox(4),
buildBox(5),
buildBox(6),
],
),
);
await tester.tap(find.text('0'));
expect(log, equals(<int>[0]));
await tester.tap(find.text('1'));
expect(log, equals(<int>[0, 1]));
await tester.tap(find.text('2'));
expect(log, equals(<int>[0, 1, 2]));
log.clear();
await tester.tapAt(const Offset(20.0, 90.0));
expect(log, equals(<int>[1]));
startOffset.value = 50.0;
await tester.pump();
log.clear();
await tester.tapAt(const Offset(20.0, 90.0));
expect(log, equals(<int>[0]));
});
testWidgets('paintChild gets called twice', (WidgetTester tester) async {
await tester.pumpWidget(
Flow(
delegate: DuplicatePainterOpacityFlowDelegate(1.0),
children: const <Widget>[
SizedBox(width: 100.0, height: 100.0),
SizedBox(width: 100.0, height: 100.0),
],
),
);
final dynamic exception = tester.takeException();
expect(exception, isFlutterError);
final error = exception as FlutterError;
expect(
error.toStringDeep(),
equalsIgnoringHashCodes(
'FlutterError\n'
' Cannot call paintChild twice for the same child.\n'
' The flow delegate of type DuplicatePainterOpacityFlowDelegate\n'
' attempted to paint child 0 multiple times, which is not\n'
' permitted.\n',
),
);
});
testWidgets('Flow opacity layer', (WidgetTester tester) async {
const opacity = 0.2;
await tester.pumpWidget(
Flow(
delegate: OpacityFlowDelegate(opacity),
children: const <Widget>[SizedBox(width: 100.0, height: 100.0)],
),
);
ContainerLayer? layer = RendererBinding.instance.renderView.debugLayer;
while (layer != null && layer is! OpacityLayer) {
layer = layer.firstChild as ContainerLayer?;
}
expect(layer, isA<OpacityLayer>());
final opacityLayer = layer as OpacityLayer?;
expect(opacityLayer!.alpha, equals(opacity * 255));
expect(layer!.firstChild, isA<TransformLayer>());
});
testWidgets('Flow can set and update clipBehavior', (WidgetTester tester) async {
const opacity = 0.2;
await tester.pumpWidget(
Flow(
delegate: OpacityFlowDelegate(opacity),
children: const <Widget>[SizedBox(width: 100.0, height: 100.0)],
),
);
// By default, clipBehavior should be Clip.hardEdge
final RenderFlow renderObject = tester.renderObject(find.byType(Flow));
expect(renderObject.clipBehavior, equals(Clip.hardEdge));
for (final Clip clip in Clip.values) {
await tester.pumpWidget(
Flow(
delegate: OpacityFlowDelegate(opacity),
clipBehavior: clip,
children: const <Widget>[SizedBox(width: 100.0, height: 100.0)],
),
);
expect(renderObject.clipBehavior, clip);
}
});
testWidgets('Flow.unwrapped can set and update clipBehavior', (WidgetTester tester) async {
const opacity = 0.2;
await tester.pumpWidget(
Flow.unwrapped(
delegate: OpacityFlowDelegate(opacity),
children: const <Widget>[SizedBox(width: 100.0, height: 100.0)],
),
);
// By default, clipBehavior should be Clip.hardEdge
final RenderFlow renderObject = tester.renderObject(find.byType(Flow));
expect(renderObject.clipBehavior, equals(Clip.hardEdge));
for (final Clip clip in Clip.values) {
await tester.pumpWidget(
Flow.unwrapped(
delegate: OpacityFlowDelegate(opacity),
clipBehavior: clip,
children: const <Widget>[SizedBox(width: 100.0, height: 100.0)],
),
);
expect(renderObject.clipBehavior, clip);
}
});
}