Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

352 lines
11 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
Widget constrainedFlex({
required Axis direction,
required MainAxisAlignment mainAxisAlignment,
required double spacing,
}) {
return Directionality(
textDirection: TextDirection.ltr,
child: Center(
child: SizedBox(
width: 300.0,
height: 300.0,
child: Flex(
direction: direction,
mainAxisAlignment: mainAxisAlignment,
spacing: spacing,
children: const <Widget>[
SizedBox(width: 50.0, height: 50.0),
SizedBox(width: 50.0, height: 50.0),
SizedBox(width: 50.0, height: 50.0),
],
),
),
),
);
}
testWidgets('Can hit test flex children of stacks', (WidgetTester tester) async {
var didReceiveTap = false;
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: ColoredBox(
color: const Color(0xFF00FF00),
child: Stack(
children: <Widget>[
Positioned(
top: 10.0,
left: 10.0,
child: Column(
children: <Widget>[
GestureDetector(
onTap: () {
didReceiveTap = true;
},
child: Container(
color: const Color(0xFF0000FF),
width: 100.0,
height: 100.0,
child: const Center(child: Text('X', textDirection: TextDirection.ltr)),
),
),
],
),
),
],
),
),
),
);
await tester.tap(find.text('X'));
expect(didReceiveTap, isTrue);
});
testWidgets('Flexible defaults to loose', (WidgetTester tester) async {
await tester.pumpWidget(
const Row(
textDirection: TextDirection.ltr,
children: <Widget>[Flexible(child: SizedBox(width: 100.0, height: 200.0))],
),
);
final RenderBox box = tester.renderObject(find.byType(SizedBox));
expect(box.size.width, 100.0);
});
testWidgets("Doesn't overflow because of floating point accumulated error", (
WidgetTester tester,
) async {
// both of these cases have failed in the past due to floating point issues
await tester.pumpWidget(
const Center(
child: SizedBox(
height: 400.0,
child: Column(
children: <Widget>[
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
],
),
),
),
);
await tester.pumpWidget(
const Center(
child: SizedBox(
height: 199.0,
child: Column(
children: <Widget>[
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
Expanded(child: SizedBox()),
],
),
),
),
);
});
testWidgets('Error information is printed correctly', (WidgetTester tester) async {
// We run this twice, the first time without an error, so that the second time
// we only get a single exception. Otherwise we'd get two, the one we want and
// an extra one when we discover we never computed a size.
await tester.pumpWidget(
const Column(children: <Widget>[Column()]),
duration: Duration.zero,
phase: EnginePhase.layout,
);
// Turn off intrinsics checking, which also fails with the same exception.
debugCheckIntrinsicSizes = false;
await tester.pumpWidget(
Column(
children: <Widget>[
Column(children: <Widget>[Expanded(child: Container())]),
],
),
duration: Duration.zero,
phase: EnginePhase.layout,
);
debugCheckIntrinsicSizes = true;
final message = tester.takeException().toString();
expect(message, contains('\nSee also:'));
});
testWidgets('Can set and update clipBehavior', (WidgetTester tester) async {
await tester.pumpWidget(const Flex(direction: Axis.vertical));
final RenderFlex renderObject = tester.allRenderObjects.whereType<RenderFlex>().first;
expect(renderObject.clipBehavior, equals(Clip.none));
await tester.pumpWidget(const Flex(direction: Axis.vertical, clipBehavior: Clip.antiAlias));
expect(renderObject.clipBehavior, equals(Clip.antiAlias));
});
test('Flex/Column/Row can be const-constructed', () {
const Flex(direction: Axis.vertical);
const Column();
const Row();
});
testWidgets('Default Flex.spacing value', (WidgetTester tester) async {
await tester.pumpWidget(const Flex(direction: Axis.vertical));
final Flex flex = tester.widget(find.byType(Flex));
expect(flex.spacing, 0.0);
});
testWidgets('Can update Flex.spacing value', (WidgetTester tester) async {
Widget buildFlex({required double spacing}) {
return Center(
child: Directionality(
textDirection: TextDirection.ltr,
child: Flex(
spacing: spacing,
direction: Axis.vertical,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
Container(height: 100.0, width: 100.0, color: const Color(0xFFFF0000)),
Container(height: 100.0, width: 100.0, color: const Color(0xFF0000FF)),
Container(height: 100.0, width: 100.0, color: const Color(0xff00FF00)),
],
),
),
);
}
await tester.pumpWidget(buildFlex(spacing: 8.0));
RenderFlex renderObject = tester.allRenderObjects.whereType<RenderFlex>().first;
expect(renderObject.spacing, equals(8.0));
expect(tester.getSize(find.byType(Flex)).width, equals(100.0));
expect(tester.getSize(find.byType(Flex)).height, equals(316.0));
await tester.pumpWidget(buildFlex(spacing: 18.0));
renderObject = tester.allRenderObjects.whereType<RenderFlex>().first;
expect(renderObject.spacing, equals(18.0));
expect(tester.getSize(find.byType(Flex)).width, equals(100.0));
expect(tester.getSize(find.byType(Flex)).height, equals(336.0));
});
testWidgets('Overconstrained Flex with MainAxisAlignment.start and spacing', (
WidgetTester tester,
) async {
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.start,
spacing: 50.0,
),
);
// 50.0 * 3 (children) + 50.0 * 2 (spacing) = 250.0 < 300.0 (constraints)
expect(tester.takeException(), isNull);
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.start,
spacing: 100.0,
),
);
// 50.0 * 3 (children) + 100.0 * 2 (spacing) = 350.0 > 300.0 (constraints)
expect(tester.takeException(), isAssertionError);
});
testWidgets('Overconstrained Flex with MainAxisAlignment.end and spacing', (
WidgetTester tester,
) async {
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.end,
spacing: 50.0,
),
);
// 50.0 * 3 (children) + 50.0 * 2 (spacing) = 250.0 < 300.0 (constraints)
expect(tester.takeException(), isNull);
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.end,
spacing: 100.0,
),
);
// 50.0 * 3 (children) + 100.0 * 2 (spacing) = 350.0 > 300.0 (constraints)
expect(tester.takeException(), isAssertionError);
});
testWidgets('Overconstrained Flex with MainAxisAlignment.center and spacing', (
WidgetTester tester,
) async {
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.center,
spacing: 50.0,
),
);
// 50.0 * 3 (children) + 50.0 * 2 (spacing) = 250.0 < 300.0 (constraints)
expect(tester.takeException(), isNull);
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.center,
spacing: 100.0,
),
);
// 50.0 * 3 (children) + 100.0 * 2 (spacing) = 350.0 > 300.0 (constraints)
expect(tester.takeException(), isAssertionError);
});
testWidgets('Overconstrained Flex with MainAxisAlignment.spaceAround and spacing', (
WidgetTester tester,
) async {
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.spaceAround,
spacing: 50.0,
),
);
// 50.0 * 3 (children) + 50.0 * 2 (spacing) = 250.0 < 300.0 (constraints)
expect(tester.takeException(), isNull);
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.spaceAround,
spacing: 100.0,
),
);
// 50.0 * 3 (children) + 100.0 * 2 (spacing) = 350.0 > 300.0 (constraints)
expect(tester.takeException(), isAssertionError);
});
testWidgets('Overconstrained Flex with MainAxisAlignment.spaceEvenly and spacing', (
WidgetTester tester,
) async {
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
spacing: 50.0,
),
);
// 50.0 * 3 (children) + 50.0 * 2 (spacing) = 250.0 < 300.0 (constraints)
expect(tester.takeException(), isNull);
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
spacing: 100.0,
),
);
// 50.0 * 3 (children) + 100.0 * 2 (spacing) = 350.0 > 300.0 (constraints)
expect(tester.takeException(), isAssertionError);
});
testWidgets('Overconstrained Flex with MainAxisAlignment.spaceBetween and spacing', (
WidgetTester tester,
) async {
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
spacing: 50.0,
),
);
// 50.0 * 3 (children) + 50.0 * 2 (spacing) = 250.0 < 300.0 (constraints)
expect(tester.takeException(), isNull);
await tester.pumpWidget(
constrainedFlex(
direction: Axis.vertical,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
spacing: 100.0,
),
);
// 50.0 * 3 (children) + 100.0 * 2 (spacing) = 350.0 > 300.0 (constraints)
expect(tester.takeException(), isAssertionError);
});
}