mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
bef11d207f
There is a lot of cross-library importing in the framework unit tests that I'd like to clean up, see the design doc for more: https://docs.google.com/document/d/1UHxALQqCbmgjnM1RNV9xE2pK3IGyx-UktGX1D7hYCjs/edit?tab=t.0 This PR cleans up a few obvious instances and adds TODOs for others. I created this while doing an investigation for the design doc linked above. I hope that we'll be able to follow up with fixes for all of the problematic tests (tracked in the issue below). Part of https://github.com/flutter/flutter/issues/177028
65 lines
2.8 KiB
Dart
65 lines
2.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
// This file is for tests for WidgetsBinding that require a `LiveTestWidgetsFlutterBinding`.
|
|
void main() {
|
|
LiveTestWidgetsFlutterBinding();
|
|
testWidgets('ReportTiming callback records the sendFramesToEngine when it was scheduled', (
|
|
WidgetTester tester,
|
|
) async {
|
|
// Addresses https://github.com/flutter/flutter/issues/144261
|
|
// This test needs LiveTestWidgetsFlutterBinding for multiple reasons.
|
|
//
|
|
// First, this was the environment that this bug was discovered.
|
|
//
|
|
// Second, unlike `AutomatedTestWidgetsFlutterBinding`, which overrides
|
|
// `scheduleWarmUpFrame` to execute the handlers synchronously,
|
|
// `LiveTestWidgetsFlutterBinding` still calls them asynchronously. This
|
|
// allows `runApp`, which also schedules a warm-up frame, to bind a widget
|
|
// without rendering a frame, which is needed to for `deferFirstFrame` to
|
|
// take effect.
|
|
|
|
// Before `testWidgets` executes the test body, it pumps a frame with a
|
|
// fixed dummy widget, then calls `resetFirstFrameSent`. The pumped frame
|
|
// schedules a reportTiming call that has yet to arrive.
|
|
//
|
|
// This puts the test in an inconsistent state: a reportTiming callback is
|
|
// supposed to happen only after a frame is rendered, but due to
|
|
// `resetFirstFrameSent`, the framework thinks no frames have been rendered.
|
|
|
|
expect(tester.binding.sendFramesToEngine, true);
|
|
// Push the widget with `runApp` instead of `tester.pump`, avoiding
|
|
// rendering a frame, which is needed for `deferFirstFrame` later to work.
|
|
runApp(const DummyWidget());
|
|
// Verify that no widget tree is built and nothing is rendered.
|
|
expect(find.text('First frame'), findsNothing);
|
|
// Defer the first frame, making `sendFramesToEngine` false, so that widget
|
|
// tree will be built but not sent to the engine.
|
|
tester.binding.deferFirstFrame();
|
|
expect(tester.binding.sendFramesToEngine, false);
|
|
// Pump a frame, letting the reportTiming callback to run. If the
|
|
// reportTiming callback were to assume that `sendFramesToEngine` is true,
|
|
// the callback would crash.
|
|
await tester.pump(const Duration(milliseconds: 1));
|
|
await tester.binding.waitUntilFirstFrameRasterized;
|
|
expect(find.text('First frame'), findsOne);
|
|
}, skip: kIsWeb); // [intended] Web doesn't use LiveTestWidgetsFlutterBinding
|
|
}
|
|
|
|
class DummyWidget extends StatelessWidget {
|
|
const DummyWidget({super.key});
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
return const Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: Center(child: Text('First frame')),
|
|
);
|
|
}
|
|
}
|