mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
- A part of https://github.com/flutter/flutter/issues/177415 - In this PR: - Build a minimal TestListTile widget in `list_tile_test_utils.dart`. It's basically a Container with necessary properties like min height, padding, onTap callback with `HitTestBehavior.opaque` to illustrate InkWell used in ListTile. - Replace material ListTile widget with TestListTile for all appearances in `packages/flutter/test/widgets` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Signed-off-by: huycozy <huy@nevercode.io>
172 lines
4.7 KiB
Dart
172 lines
4.7 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'list_tile_test_utils.dart';
|
|
|
|
void main() {
|
|
testWidgets('Baseline - control test', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const Center(
|
|
child: DefaultTextStyle(
|
|
style: TextStyle(fontSize: 100.0),
|
|
child: Text('X', textDirection: TextDirection.ltr),
|
|
),
|
|
),
|
|
);
|
|
expect(tester.renderObject<RenderBox>(find.text('X')).size, const Size(100.0, 100.0));
|
|
});
|
|
|
|
testWidgets('Baseline - position test', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const Center(
|
|
child: Baseline(
|
|
baseline: 175.0,
|
|
baselineType: TextBaseline.alphabetic,
|
|
child: DefaultTextStyle(
|
|
style: TextStyle(fontFamily: 'FlutterTest', fontSize: 100.0),
|
|
child: Text('X', textDirection: TextDirection.ltr),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
expect(tester.renderObject<RenderBox>(find.text('X')).size, const Size(100.0, 100.0));
|
|
expect(tester.renderObject<RenderBox>(find.byType(Baseline)).size, const Size(100.0, 200));
|
|
});
|
|
|
|
testWidgets('Chip caches baseline', (WidgetTester tester) async {
|
|
final bool checkIntrinsicSizes = debugCheckIntrinsicSizes;
|
|
debugCheckIntrinsicSizes = false;
|
|
var calls = 0;
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Material(
|
|
child: Baseline(
|
|
baseline: 100.0,
|
|
baselineType: TextBaseline.alphabetic,
|
|
child: Chip(
|
|
label: BaselineDetector(() {
|
|
assert(!debugCheckIntrinsicSizes);
|
|
calls += 1;
|
|
}),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
expect(calls, 1);
|
|
await tester.pump();
|
|
expect(calls, 1);
|
|
tester.renderObject<RenderBaselineDetector>(find.byType(BaselineDetector)).dirty();
|
|
await tester.pump();
|
|
expect(calls, 2);
|
|
debugCheckIntrinsicSizes = checkIntrinsicSizes;
|
|
});
|
|
|
|
testWidgets('ListTile caches baseline', (WidgetTester tester) async {
|
|
final bool checkIntrinsicSizes = debugCheckIntrinsicSizes;
|
|
debugCheckIntrinsicSizes = false;
|
|
var calls = 0;
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Material(
|
|
child: Baseline(
|
|
baseline: 100.0,
|
|
baselineType: TextBaseline.alphabetic,
|
|
child: TestListTile(
|
|
title: BaselineDetector(() {
|
|
assert(!debugCheckIntrinsicSizes);
|
|
calls += 1;
|
|
}),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
expect(calls, 1);
|
|
await tester.pump();
|
|
expect(calls, 1);
|
|
tester.renderObject<RenderBaselineDetector>(find.byType(BaselineDetector)).dirty();
|
|
await tester.pump();
|
|
expect(calls, 2);
|
|
debugCheckIntrinsicSizes = checkIntrinsicSizes;
|
|
});
|
|
|
|
testWidgets("LayoutBuilder returns child's baseline", (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Material(
|
|
child: Baseline(
|
|
baseline: 180.0,
|
|
baselineType: TextBaseline.alphabetic,
|
|
child: LayoutBuilder(
|
|
builder: (BuildContext context, BoxConstraints constraints) {
|
|
return BaselineDetector(() {});
|
|
},
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
expect(tester.getRect(find.byType(BaselineDetector)).top, 160.0);
|
|
});
|
|
}
|
|
|
|
class BaselineDetector extends LeafRenderObjectWidget {
|
|
const BaselineDetector(this.callback, {super.key});
|
|
|
|
final VoidCallback callback;
|
|
|
|
@override
|
|
RenderBaselineDetector createRenderObject(BuildContext context) =>
|
|
RenderBaselineDetector(callback);
|
|
|
|
@override
|
|
void updateRenderObject(BuildContext context, RenderBaselineDetector renderObject) {
|
|
renderObject.callback = callback;
|
|
}
|
|
}
|
|
|
|
class RenderBaselineDetector extends RenderBox {
|
|
RenderBaselineDetector(this.callback);
|
|
|
|
VoidCallback callback;
|
|
|
|
@override
|
|
bool get sizedByParent => true;
|
|
|
|
@override
|
|
double computeMinIntrinsicWidth(double height) => 0.0;
|
|
|
|
@override
|
|
double computeMaxIntrinsicWidth(double height) => 0.0;
|
|
|
|
@override
|
|
double computeMinIntrinsicHeight(double width) => 0.0;
|
|
|
|
@override
|
|
double computeMaxIntrinsicHeight(double width) => 0.0;
|
|
|
|
@override
|
|
double computeDistanceToActualBaseline(TextBaseline baseline) {
|
|
callback();
|
|
return 20.0;
|
|
}
|
|
|
|
void dirty() {
|
|
markNeedsLayout();
|
|
}
|
|
|
|
@override
|
|
Size computeDryLayout(BoxConstraints constraints) {
|
|
return constraints.smallest;
|
|
}
|
|
|
|
@override
|
|
void paint(PaintingContext context, Offset offset) {}
|
|
}
|