mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
140 lines
4.2 KiB
Dart
140 lines
4.2 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'rendering_tester.dart';
|
|
|
|
void main() {
|
|
TestRenderingFlutterBinding.ensureInitialized();
|
|
|
|
test('nested repaint boundaries - smoke test', () {
|
|
RenderOpacity a, b, c;
|
|
a = RenderOpacity(
|
|
child: RenderRepaintBoundary(
|
|
child: b = RenderOpacity(child: RenderRepaintBoundary(child: c = RenderOpacity())),
|
|
),
|
|
);
|
|
layout(a, phase: EnginePhase.flushSemantics);
|
|
c.opacity = 0.9;
|
|
pumpFrame(phase: EnginePhase.flushSemantics);
|
|
a.opacity = 0.8;
|
|
c.opacity = 0.8;
|
|
pumpFrame(phase: EnginePhase.flushSemantics);
|
|
a.opacity = 0.7;
|
|
b.opacity = 0.7;
|
|
c.opacity = 0.7;
|
|
pumpFrame(phase: EnginePhase.flushSemantics);
|
|
});
|
|
|
|
test('Repaint boundary can get new parent after markNeedsCompositingBitsUpdate', () {
|
|
// Regression test for https://github.com/flutter/flutter/issues/24029.
|
|
|
|
final repaintBoundary = RenderRepaintBoundary();
|
|
layout(repaintBoundary, phase: EnginePhase.flushSemantics);
|
|
|
|
repaintBoundary.markNeedsCompositingBitsUpdate();
|
|
|
|
TestRenderingFlutterBinding.instance.renderView.child = null;
|
|
final padding = RenderPadding(padding: const EdgeInsets.all(50));
|
|
TestRenderingFlutterBinding.instance.renderView.child = padding;
|
|
padding.child = repaintBoundary;
|
|
pumpFrame(phase: EnginePhase.flushSemantics);
|
|
});
|
|
|
|
test('Framework creates an OffsetLayer for a repaint boundary', () {
|
|
final repaintBoundary = _TestRepaintBoundary();
|
|
final opacity = RenderOpacity(child: repaintBoundary);
|
|
layout(opacity, phase: EnginePhase.flushSemantics);
|
|
expect(repaintBoundary.debugLayer, isA<OffsetLayer>());
|
|
});
|
|
|
|
test('Framework does not create an OffsetLayer for a non-repaint boundary', () {
|
|
final nonCompositedBox = _TestNonCompositedBox();
|
|
final opacity = RenderOpacity(child: nonCompositedBox);
|
|
layout(opacity, phase: EnginePhase.flushSemantics);
|
|
expect(nonCompositedBox.debugLayer, null);
|
|
});
|
|
|
|
test('Framework allows a non-repaint boundary to create own layer', () {
|
|
final compositedBox = _TestCompositedBox();
|
|
final opacity = RenderOpacity(child: compositedBox);
|
|
layout(opacity, phase: EnginePhase.flushSemantics);
|
|
expect(compositedBox.debugLayer, isA<OpacityLayer>());
|
|
});
|
|
|
|
test('Framework ensures repaint boundary layer is not overwritten', () {
|
|
final faultyRenderObject = _TestRepaintBoundaryThatOverwritesItsLayer();
|
|
final opacity = RenderOpacity(child: faultyRenderObject);
|
|
|
|
late FlutterErrorDetails error;
|
|
layout(
|
|
opacity,
|
|
phase: EnginePhase.flushSemantics,
|
|
onErrors: () {
|
|
error = TestRenderingFlutterBinding.instance.takeFlutterErrorDetails()!;
|
|
},
|
|
);
|
|
expect(
|
|
'${error.exception}',
|
|
contains('Attempted to set a layer to a repaint boundary render object.'),
|
|
);
|
|
});
|
|
}
|
|
|
|
// A plain render object that's a repaint boundary.
|
|
class _TestRepaintBoundary extends RenderBox {
|
|
@override
|
|
bool get isRepaintBoundary => true;
|
|
|
|
@override
|
|
void performLayout() {
|
|
size = constraints.smallest;
|
|
}
|
|
}
|
|
|
|
// A render object that's a repaint boundary and (incorrectly) creates its own layer.
|
|
class _TestRepaintBoundaryThatOverwritesItsLayer extends RenderBox {
|
|
@override
|
|
bool get isRepaintBoundary => true;
|
|
|
|
@override
|
|
void performLayout() {
|
|
size = constraints.smallest;
|
|
}
|
|
|
|
@override
|
|
void paint(PaintingContext context, Offset offset) {
|
|
layer = OpacityLayer(alpha: 50);
|
|
}
|
|
}
|
|
|
|
// A render object that's neither a repaint boundary nor creates its own layer.
|
|
class _TestNonCompositedBox extends RenderBox {
|
|
@override
|
|
bool get isRepaintBoundary => false;
|
|
|
|
@override
|
|
void performLayout() {
|
|
size = constraints.smallest;
|
|
}
|
|
}
|
|
|
|
// A render object that's not a repaint boundary but creates its own layer.
|
|
class _TestCompositedBox extends RenderBox {
|
|
@override
|
|
bool get isRepaintBoundary => false;
|
|
|
|
@override
|
|
void performLayout() {
|
|
size = constraints.smallest;
|
|
}
|
|
|
|
@override
|
|
void paint(PaintingContext context, Offset offset) {
|
|
layer = OpacityLayer(alpha: 50);
|
|
}
|
|
}
|