Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

473 lines
12 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'dart:typed_data';
import 'package:collection/collection.dart' show ListEquality, MapEquality;
import 'package:flutter_devicelab/framework/devices.dart';
import 'package:meta/meta.dart';
import 'common.dart';
void main() {
group('device', () {
late Device device;
setUp(() {
FakeDevice.resetLog();
device = FakeDevice(deviceId: 'fakeDeviceId');
});
tearDown(() {
FakeDevice.resetLog();
});
group('cpu check', () {
test('arm64', () async {
FakeDevice.pretendArm64();
final androidDevice = device as AndroidDevice;
expect(await androidDevice.isArm64(), isTrue);
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'getprop', arguments: <String>['ro.product.cpu.abi']),
]);
});
});
group('isAwake/isAsleep', () {
test('reads Awake', () async {
FakeDevice.pretendAwake();
expect(await device.isAwake(), isTrue);
expect(await device.isAsleep(), isFalse);
});
test('reads Awake - samsung devices', () async {
FakeDevice.pretendAwakeSamsung();
expect(await device.isAwake(), isTrue);
expect(await device.isAsleep(), isFalse);
});
test('reads Asleep', () async {
FakeDevice.pretendAsleep();
expect(await device.isAwake(), isFalse);
expect(await device.isAsleep(), isTrue);
});
});
group('togglePower', () {
test('sends power event', () async {
await device.togglePower();
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'input', arguments: <String>['keyevent', '26']),
]);
});
});
group('wakeUp', () {
test('when awake', () async {
FakeDevice.pretendAwake();
await device.wakeUp();
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'dumpsys', arguments: <String>['power']),
]);
});
test('when asleep', () async {
FakeDevice.pretendAsleep();
await device.wakeUp();
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'dumpsys', arguments: <String>['power']),
cmd(command: 'input', arguments: <String>['keyevent', '26']),
]);
});
});
group('sendToSleep', () {
test('when asleep', () async {
FakeDevice.pretendAsleep();
await device.sendToSleep();
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'dumpsys', arguments: <String>['power']),
]);
});
test('when awake', () async {
FakeDevice.pretendAwake();
await device.sendToSleep();
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'dumpsys', arguments: <String>['power']),
cmd(command: 'input', arguments: <String>['keyevent', '26']),
]);
});
});
group('unlock', () {
test('sends unlock event', () async {
FakeDevice.pretendAwake();
await device.unlock();
expectLog(<CommandArgs>[
cmd(
command: 'getprop',
arguments: <String>[
'ro.bootimage.build.fingerprint',
';',
'getprop',
'ro.build.version.release',
';',
'getprop',
'ro.build.version.sdk',
],
),
cmd(command: 'dumpsys', arguments: <String>['power']),
cmd(command: 'input', arguments: <String>['keyevent', '82']),
]);
});
});
group('adb', () {
test('tap', () async {
FakeDevice.resetLog();
await device.tap(100, 200);
expectLog(<CommandArgs>[
cmd(command: 'input', arguments: <String>['tap', '100', '200']),
]);
});
test('awaitDevice', () async {
FakeDevice.resetLog();
// The expected value from `adb shell getprop sys.boot_completed`
FakeDevice.output = '1';
await device.awaitDevice();
expectLog(<CommandArgs>[
cmd(
command: 'adb',
environment: <String, String>{FakeDevice.canFailKey: 'false'},
arguments: <String>['-s', device.deviceId, 'wait-for-device'],
),
cmd(
command: 'adb',
environment: <String, String>{FakeDevice.canFailKey: 'false'},
arguments: <String>['-s', device.deviceId, 'shell', 'getprop sys.boot_completed'],
),
]);
});
test('reboot', () async {
FakeDevice.resetLog();
await device.reboot();
expectLog(<CommandArgs>[
cmd(
command: 'adb',
environment: <String, String>{FakeDevice.canFailKey: 'false'},
arguments: <String>['-s', device.deviceId, 'reboot'],
),
]);
});
test('clearLog', () async {
FakeDevice.resetLog();
await device.clearLogs();
expectLog(<CommandArgs>[
cmd(
command: 'adb',
environment: <String, String>{FakeDevice.canFailKey: 'true'},
arguments: <String>['-s', device.deviceId, 'logcat', '-c'],
),
]);
});
test('startLoggingToSink calls adb', () async {
FakeDevice.resetLog();
await device.startLoggingToSink(IOSink(_MemoryIOSink()));
expectLog(<CommandArgs>[
cmd(
command: 'adb',
environment: <String, String>{FakeDevice.canFailKey: 'true'},
arguments: <String>['-s', device.deviceId, 'logcat', '--clear'],
),
]);
});
});
});
}
void expectLog(List<CommandArgs> log) {
expect(FakeDevice.commandLog, log);
}
CommandArgs cmd({
required String command,
List<String>? arguments,
Map<String, String>? environment,
}) {
return CommandArgs(command: command, arguments: arguments, environment: environment);
}
@immutable
class CommandArgs {
const CommandArgs({required this.command, this.arguments, this.environment});
final String command;
final List<String>? arguments;
final Map<String, String>? environment;
@override
String toString() =>
'CommandArgs(command: $command, arguments: $arguments, environment: $environment)';
@override
bool operator ==(Object other) {
if (other.runtimeType != CommandArgs) {
return false;
}
return other is CommandArgs &&
other.command == command &&
const ListEquality<String>().equals(other.arguments, arguments) &&
const MapEquality<String, String>().equals(other.environment, environment);
}
@override
int get hashCode {
return Object.hash(
command,
Object.hashAll(arguments ?? const <String>[]),
Object.hashAllUnordered(environment?.keys ?? const <String>[]),
Object.hashAllUnordered(environment?.values ?? const <String>[]),
);
}
}
class FakeDevice extends AndroidDevice {
FakeDevice({required super.deviceId});
static const String canFailKey = 'canFail';
static String output = '';
static List<CommandArgs> commandLog = <CommandArgs>[];
static void resetLog() {
commandLog.clear();
}
static void pretendAwake() {
// Emit an integer value in addition to the state string to ensure only
// the state string is matched.
//
// Regression testing for https://github.com/flutter/flutter/issues/174952.
output = '''
mWakefulness=1
mWakefulness=Awake
''';
}
static void pretendAwakeSamsung() {
// Emit an integer value in addition to the state string to ensure only
// the state string is matched.
//
// Regression testing for https://github.com/flutter/flutter/issues/174952.
output = '''
getWakefulnessLocked()=1
getWakefulnessLocked()=Awake
''';
}
static void pretendAsleep() {
// Emit an integer value in addition to the state string to ensure only
// the state string is matched.
//
// Regression testing for https://github.com/flutter/flutter/issues/174952.
output = '''
mWakefulness=0
mWakefulness=Asleep
''';
}
static void pretendArm64() {
output = '''
arm64
''';
}
@override
Future<String> adb(
List<String> arguments, {
Map<String, String>? environment,
bool silent = false,
bool canFail = false,
}) async {
environment ??= <String, String>{};
commandLog.add(
CommandArgs(
command: 'adb',
// ignore: prefer_spread_collections
arguments: <String>['-s', deviceId]..addAll(arguments),
environment: environment..putIfAbsent('canFail', () => '$canFail'),
),
);
return output;
}
@override
Future<String> shellEval(
String command,
List<String> arguments, {
Map<String, String>? environment,
bool silent = false,
}) async {
commandLog.add(CommandArgs(command: command, arguments: arguments, environment: environment));
return output;
}
@override
Future<void> shellExec(
String command,
List<String> arguments, {
Map<String, String>? environment,
bool silent = false,
}) async {
commandLog.add(CommandArgs(command: command, arguments: arguments, environment: environment));
}
}
/// An IOSink that collects whatever is written to it.
/// Inspired by packages/flutter_tools/lib/src/base/net.dart
class _MemoryIOSink implements IOSink {
@override
Encoding encoding = utf8;
final BytesBuilder writes = BytesBuilder(copy: false);
@override
void add(List<int> data) {
writes.add(data);
}
@override
Future<void> addStream(Stream<List<int>> stream) {
final completer = Completer<void>();
stream.listen(add).onDone(completer.complete);
return completer.future;
}
@override
void writeCharCode(int charCode) {
add(<int>[charCode]);
}
@override
void write(Object? obj) {
add(encoding.encode('$obj'));
}
@override
void writeln([Object? obj = '']) {
add(encoding.encode('$obj\n'));
}
@override
void writeAll(Iterable<dynamic> objects, [String separator = '']) {
var addSeparator = false;
for (final dynamic object in objects) {
if (addSeparator) {
write(separator);
}
write(object);
addSeparator = true;
}
}
@override
void addError(dynamic error, [StackTrace? stackTrace]) {
throw UnimplementedError();
}
@override
Future<void> get done => close();
@override
Future<void> close() async {}
@override
Future<void> flush() async {}
}