Kate Lovett 9d96df2364
Modernize framework lints (#179089)
WIP

Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues 
- Run `dart format .` in the right places.

Local analysis and testing passes. Checking CI now.

Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00

259 lines
7.7 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'dart:math' as math;
import 'package:flutter/foundation.dart' show kDebugMode;
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:microbenchmarks/common.dart';
List<Object?> _makeTestBuffer(int size) {
return <Object?>[
for (int i = 0; i < size; i++)
switch (i % 9) {
0 => 1,
1 => math.pow(2, 65),
2 => 1234.0,
3 => null,
4 => <int>[1234],
5 => <String, int>{'hello': 1234},
6 => 'this is a test',
7 => true,
_ => Uint8List(64),
},
];
}
Future<double> _runBasicStandardSmall(BasicMessageChannel<Object?> basicStandard, int count) async {
final watch = Stopwatch();
watch.start();
for (var i = 0; i < count; ++i) {
await basicStandard.send(1234);
}
watch.stop();
return watch.elapsedMicroseconds / count;
}
class _Counter {
int count = 0;
}
void _runBasicStandardParallelRecurse(
BasicMessageChannel<Object?> basicStandard,
_Counter counter,
int count,
Completer<int> completer,
Object? payload,
) {
counter.count += 1;
if (counter.count == count) {
completer.complete(counter.count);
} else if (counter.count < count) {
basicStandard.send(payload).then((Object? result) {
_runBasicStandardParallelRecurse(basicStandard, counter, count, completer, payload);
});
}
}
Future<double> _runBasicStandardParallel(
BasicMessageChannel<Object?> basicStandard,
int count,
Object? payload,
int parallel,
) async {
final watch = Stopwatch();
final completer = Completer<int>();
final counter = _Counter();
watch.start();
for (var i = 0; i < parallel; ++i) {
basicStandard.send(payload).then((Object? result) {
_runBasicStandardParallelRecurse(basicStandard, counter, count, completer, payload);
});
}
await completer.future;
watch.stop();
return watch.elapsedMicroseconds / count;
}
Future<double> _runBasicStandardLarge(
BasicMessageChannel<Object?> basicStandard,
List<Object?> largeBuffer,
int count,
) async {
var size = 0;
final watch = Stopwatch();
watch.start();
for (var i = 0; i < count; ++i) {
final result = await basicStandard.send(largeBuffer) as List<Object?>?;
// This check should be tiny compared to the actual channel send/receive.
size += (result == null) ? 0 : result.length;
}
watch.stop();
if (size != largeBuffer.length * count) {
throw Exception("There is an error with the echo channel, the results don't add up: $size");
}
return watch.elapsedMicroseconds / count;
}
Future<double> _runBasicBinary(
BasicMessageChannel<ByteData> basicBinary,
ByteData buffer,
int count,
) async {
var size = 0;
final watch = Stopwatch();
watch.start();
for (var i = 0; i < count; ++i) {
final ByteData? result = await basicBinary.send(buffer);
// This check should be tiny compared to the actual channel send/receive.
size += (result == null) ? 0 : result.lengthInBytes;
}
watch.stop();
if (size != buffer.lengthInBytes * count) {
throw Exception("There is an error with the echo channel, the results don't add up: $size");
}
return watch.elapsedMicroseconds / count;
}
Future<void> _runTest({
required Future<double> Function(int) test,
required BasicMessageChannel<Object?> resetChannel,
required BenchmarkResultPrinter printer,
required String description,
required String name,
required int numMessages,
}) async {
print('running $name');
resetChannel.send(true);
// Prime test.
await test(1);
printer.addResult(
description: description,
value: await test(numMessages),
unit: 'µs',
name: name,
);
}
Future<void> _runTests() async {
if (kDebugMode) {
throw Exception("Must be run in profile mode! Use 'flutter run --profile'.");
}
const resetChannel = BasicMessageChannel<Object?>(
'dev.flutter.echo.reset',
StandardMessageCodec(),
);
const basicStandard = BasicMessageChannel<Object?>(
'dev.flutter.echo.basic.standard',
StandardMessageCodec(),
);
const basicBinary = BasicMessageChannel<ByteData>('dev.flutter.echo.basic.binary', BinaryCodec());
/// WARNING: Don't change the following line of code, it will invalidate
/// `Large` tests. Instead make a different test. The size of largeBuffer
/// serialized is 14214 bytes.
final List<Object?> largeBuffer = _makeTestBuffer(1000);
final ByteData largeBufferBytes = const StandardMessageCodec().encodeMessage(largeBuffer)!;
final oneMB = ByteData(1024 * 1024);
const numMessages = 2500;
final printer = BenchmarkResultPrinter();
await _runTest(
test: (int x) => _runBasicStandardSmall(basicStandard, x),
resetChannel: resetChannel,
printer: printer,
description: 'BasicMessageChannel/StandardMessageCodec/Flutter->Host/Small',
name: 'platform_channel_basic_standard_2host_small',
numMessages: numMessages,
);
await _runTest(
test: (int x) => _runBasicStandardLarge(basicStandard, largeBuffer, x),
resetChannel: resetChannel,
printer: printer,
description: 'BasicMessageChannel/StandardMessageCodec/Flutter->Host/Large',
name: 'platform_channel_basic_standard_2host_large',
numMessages: numMessages,
);
await _runTest(
test: (int x) => _runBasicBinary(basicBinary, largeBufferBytes, x),
resetChannel: resetChannel,
printer: printer,
description: 'BasicMessageChannel/BinaryCodec/Flutter->Host/Large',
name: 'platform_channel_basic_binary_2host_large',
numMessages: numMessages,
);
await _runTest(
test: (int x) => _runBasicBinary(basicBinary, oneMB, x),
resetChannel: resetChannel,
printer: printer,
description: 'BasicMessageChannel/BinaryCodec/Flutter->Host/1MB',
name: 'platform_channel_basic_binary_2host_1MB',
numMessages: numMessages,
);
await _runTest(
test: (int x) => _runBasicStandardParallel(basicStandard, x, 1234, 3),
resetChannel: resetChannel,
printer: printer,
description: 'BasicMessageChannel/StandardMessageCodec/Flutter->Host/SmallParallel3',
name: 'platform_channel_basic_standard_2host_small_parallel_3',
numMessages: numMessages,
);
// Background platform channels aren't yet implemented for iOS.
const backgroundStandard = BasicMessageChannel<Object?>(
'dev.flutter.echo.background.standard',
StandardMessageCodec(),
);
await _runTest(
test: (int x) => _runBasicStandardSmall(backgroundStandard, x),
resetChannel: resetChannel,
printer: printer,
description: 'BasicMessageChannel/StandardMessageCodec/Flutter->Host (background)/Small',
name: 'platform_channel_basic_standard_2hostbackground_small',
numMessages: numMessages,
);
await _runTest(
test: (int x) => _runBasicStandardParallel(backgroundStandard, x, 1234, 3),
resetChannel: resetChannel,
printer: printer,
description:
'BasicMessageChannel/StandardMessageCodec/Flutter->Host (background)/SmallParallel3',
name: 'platform_channel_basic_standard_2hostbackground_small_parallel_3',
numMessages: numMessages,
);
printer.printToStdout();
// Signal the end of our benchmark
print('\n\n╡ ••• Done ••• ╞\n\n');
}
class _BenchmarkWidget extends StatefulWidget {
const _BenchmarkWidget(this.tests);
final Future<void> Function() tests;
@override
_BenchmarkWidgetState createState() => _BenchmarkWidgetState();
}
class _BenchmarkWidgetState extends State<_BenchmarkWidget> {
@override
void initState() {
widget.tests();
super.initState();
}
@override
Widget build(BuildContext context) => Container();
}
void main() {
runApp(const _BenchmarkWidget(_runTests));
}