mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
370 lines
13 KiB
Dart
370 lines
13 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
class TestScrollPhysics extends ScrollPhysics {
|
|
const TestScrollPhysics({required this.name, super.parent});
|
|
final String name;
|
|
|
|
@override
|
|
TestScrollPhysics applyTo(ScrollPhysics? ancestor) {
|
|
return TestScrollPhysics(name: name, parent: parent?.applyTo(ancestor) ?? ancestor!);
|
|
}
|
|
|
|
TestScrollPhysics get namedParent => parent! as TestScrollPhysics;
|
|
String get names => parent == null ? name : '$name ${namedParent.names}';
|
|
|
|
@override
|
|
String toString() {
|
|
if (parent == null) {
|
|
return '${objectRuntimeType(this, 'TestScrollPhysics')}($name)';
|
|
}
|
|
return '${objectRuntimeType(this, 'TestScrollPhysics')}($name) -> $parent';
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
test('ScrollPhysics applyTo()', () {
|
|
const a = TestScrollPhysics(name: 'a');
|
|
const b = TestScrollPhysics(name: 'b');
|
|
const c = TestScrollPhysics(name: 'c');
|
|
const d = TestScrollPhysics(name: 'd');
|
|
const e = TestScrollPhysics(name: 'e');
|
|
|
|
expect(a.parent, null);
|
|
expect(b.parent, null);
|
|
expect(c.parent, null);
|
|
|
|
final TestScrollPhysics ab = a.applyTo(b);
|
|
expect(ab.names, 'a b');
|
|
|
|
final TestScrollPhysics abc = ab.applyTo(c);
|
|
expect(abc.names, 'a b c');
|
|
|
|
final TestScrollPhysics de = d.applyTo(e);
|
|
expect(de.names, 'd e');
|
|
|
|
final TestScrollPhysics abcde = abc.applyTo(de);
|
|
expect(abcde.names, 'a b c d e');
|
|
});
|
|
|
|
test('ScrollPhysics subclasses applyTo()', () {
|
|
const ScrollPhysics bounce = BouncingScrollPhysics();
|
|
const ScrollPhysics clamp = ClampingScrollPhysics();
|
|
const ScrollPhysics never = NeverScrollableScrollPhysics();
|
|
const ScrollPhysics always = AlwaysScrollableScrollPhysics();
|
|
const ScrollPhysics page = PageScrollPhysics();
|
|
const ScrollPhysics bounceDesktop = BouncingScrollPhysics(
|
|
decelerationRate: ScrollDecelerationRate.fast,
|
|
);
|
|
|
|
String types(ScrollPhysics? value) => value!.parent == null
|
|
? '${value.runtimeType}'
|
|
: '${value.runtimeType} ${types(value.parent)}';
|
|
|
|
expect(
|
|
types(bounce.applyTo(clamp.applyTo(never.applyTo(always.applyTo(page))))),
|
|
'BouncingScrollPhysics ClampingScrollPhysics NeverScrollableScrollPhysics AlwaysScrollableScrollPhysics PageScrollPhysics',
|
|
);
|
|
|
|
expect(
|
|
types(clamp.applyTo(never.applyTo(always.applyTo(page.applyTo(bounce))))),
|
|
'ClampingScrollPhysics NeverScrollableScrollPhysics AlwaysScrollableScrollPhysics PageScrollPhysics BouncingScrollPhysics',
|
|
);
|
|
|
|
expect(
|
|
types(never.applyTo(always.applyTo(page.applyTo(bounce.applyTo(clamp))))),
|
|
'NeverScrollableScrollPhysics AlwaysScrollableScrollPhysics PageScrollPhysics BouncingScrollPhysics ClampingScrollPhysics',
|
|
);
|
|
|
|
expect(
|
|
types(always.applyTo(page.applyTo(bounce.applyTo(clamp.applyTo(never))))),
|
|
'AlwaysScrollableScrollPhysics PageScrollPhysics BouncingScrollPhysics ClampingScrollPhysics NeverScrollableScrollPhysics',
|
|
);
|
|
|
|
expect(
|
|
types(page.applyTo(bounce.applyTo(clamp.applyTo(never.applyTo(always))))),
|
|
'PageScrollPhysics BouncingScrollPhysics ClampingScrollPhysics NeverScrollableScrollPhysics AlwaysScrollableScrollPhysics',
|
|
);
|
|
|
|
expect(
|
|
bounceDesktop.applyTo(always),
|
|
(BouncingScrollPhysics x) => x.decelerationRate == ScrollDecelerationRate.fast,
|
|
);
|
|
});
|
|
|
|
test(
|
|
"ScrollPhysics scrolling subclasses - Creating the simulation doesn't alter the velocity for time 0",
|
|
() {
|
|
final ScrollMetrics position = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 100.0,
|
|
pixels: 20.0,
|
|
viewportDimension: 500.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
const bounce = BouncingScrollPhysics();
|
|
const clamp = ClampingScrollPhysics();
|
|
const page = PageScrollPhysics();
|
|
|
|
// Calls to createBallisticSimulation may happen on every frame (i.e. when the maxScrollExtent changes)
|
|
// Changing velocity for time 0 may cause a sudden, unwanted damping/speedup effect
|
|
expect(bounce.createBallisticSimulation(position, 1000)!.dx(0), moreOrLessEquals(1000));
|
|
expect(clamp.createBallisticSimulation(position, 1000)!.dx(0), moreOrLessEquals(1000));
|
|
expect(page.createBallisticSimulation(position, 1000)!.dx(0), moreOrLessEquals(1000));
|
|
},
|
|
);
|
|
|
|
group('BouncingScrollPhysics test', () {
|
|
late BouncingScrollPhysics physicsUnderTest;
|
|
|
|
setUp(() {
|
|
physicsUnderTest = const BouncingScrollPhysics();
|
|
});
|
|
|
|
test('overscroll is progressively harder', () {
|
|
final ScrollMetrics lessOverscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: -20.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final ScrollMetrics moreOverscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: -40.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final double lessOverscrollApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
lessOverscrolledPosition,
|
|
10.0,
|
|
);
|
|
|
|
final double moreOverscrollApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
moreOverscrolledPosition,
|
|
10.0,
|
|
);
|
|
|
|
expect(lessOverscrollApplied, greaterThan(1.0));
|
|
expect(lessOverscrollApplied, lessThan(20.0));
|
|
|
|
expect(moreOverscrollApplied, greaterThan(1.0));
|
|
expect(moreOverscrollApplied, lessThan(20.0));
|
|
|
|
// Scrolling from a more overscrolled position meets more resistance.
|
|
expect(lessOverscrollApplied.abs(), greaterThan(moreOverscrollApplied.abs()));
|
|
});
|
|
|
|
test('easing an overscroll still has resistance', () {
|
|
final ScrollMetrics overscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: -20.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final double easingApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
overscrolledPosition,
|
|
-10.0,
|
|
);
|
|
|
|
expect(easingApplied, lessThan(-1.0));
|
|
expect(easingApplied, greaterThan(-10.0));
|
|
});
|
|
|
|
test('no resistance when not overscrolled', () {
|
|
final ScrollMetrics scrollPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: 300.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
expect(physicsUnderTest.applyPhysicsToUserOffset(scrollPosition, 10.0), 10.0);
|
|
expect(physicsUnderTest.applyPhysicsToUserOffset(scrollPosition, -10.0), -10.0);
|
|
});
|
|
|
|
test('easing an overscroll meets less resistance than tensioning', () {
|
|
final ScrollMetrics overscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: -20.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final double easingApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
overscrolledPosition,
|
|
-10.0,
|
|
);
|
|
final double tensioningApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
overscrolledPosition,
|
|
10.0,
|
|
);
|
|
|
|
expect(easingApplied.abs(), greaterThan(tensioningApplied.abs()));
|
|
});
|
|
|
|
test('no easing resistance for ScrollDecelerationRate.fast', () {
|
|
const desktop = BouncingScrollPhysics(decelerationRate: ScrollDecelerationRate.fast);
|
|
final ScrollMetrics overscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: -20.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final double easingApplied = desktop.applyPhysicsToUserOffset(overscrolledPosition, -10.0);
|
|
final double tensioningApplied = desktop.applyPhysicsToUserOffset(overscrolledPosition, 10.0);
|
|
|
|
expect(tensioningApplied.abs(), lessThan(easingApplied.abs()));
|
|
expect(easingApplied, -10);
|
|
});
|
|
|
|
test('overscroll a small list and a big list works the same way', () {
|
|
final ScrollMetrics smallListOverscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 10.0,
|
|
pixels: -20.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final ScrollMetrics bigListOverscrolledPosition = FixedScrollMetrics(
|
|
minScrollExtent: 0.0,
|
|
maxScrollExtent: 1000.0,
|
|
pixels: -20.0,
|
|
viewportDimension: 100.0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
|
|
final double smallListOverscrollApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
smallListOverscrolledPosition,
|
|
10.0,
|
|
);
|
|
|
|
final double bigListOverscrollApplied = physicsUnderTest.applyPhysicsToUserOffset(
|
|
bigListOverscrolledPosition,
|
|
10.0,
|
|
);
|
|
|
|
expect(smallListOverscrollApplied, equals(bigListOverscrollApplied));
|
|
|
|
expect(smallListOverscrollApplied, greaterThan(1.0));
|
|
expect(smallListOverscrollApplied, lessThan(20.0));
|
|
});
|
|
|
|
test('frictionFactor', () {
|
|
const mobile = BouncingScrollPhysics();
|
|
const desktop = BouncingScrollPhysics(decelerationRate: ScrollDecelerationRate.fast);
|
|
|
|
expect(desktop.frictionFactor(0), 0.26);
|
|
expect(mobile.frictionFactor(0), 0.52);
|
|
|
|
expect(desktop.frictionFactor(0.4), moreOrLessEquals(0.0936));
|
|
expect(mobile.frictionFactor(0.4), moreOrLessEquals(0.1872));
|
|
|
|
expect(desktop.frictionFactor(0.8), moreOrLessEquals(0.0104));
|
|
expect(mobile.frictionFactor(0.8), moreOrLessEquals(0.0208));
|
|
});
|
|
});
|
|
|
|
test('ClampingScrollPhysics assertion test', () {
|
|
const physics = ClampingScrollPhysics();
|
|
const double pixels = 500;
|
|
final ScrollMetrics position = FixedScrollMetrics(
|
|
pixels: pixels,
|
|
minScrollExtent: 0,
|
|
maxScrollExtent: 1000,
|
|
viewportDimension: 0,
|
|
axisDirection: AxisDirection.down,
|
|
devicePixelRatio: 3.0,
|
|
);
|
|
expect(position.pixels, pixels);
|
|
late FlutterError error;
|
|
try {
|
|
physics.applyBoundaryConditions(position, pixels);
|
|
} on FlutterError catch (e) {
|
|
error = e;
|
|
} finally {
|
|
expect(error, isNotNull);
|
|
expect(error.diagnostics.length, 4);
|
|
expect(error.diagnostics[2], isA<DiagnosticsProperty<ScrollPhysics>>());
|
|
expect(error.diagnostics[2].style, DiagnosticsTreeStyle.errorProperty);
|
|
expect(error.diagnostics[2].value, physics);
|
|
expect(error.diagnostics[3], isA<DiagnosticsProperty<ScrollMetrics>>());
|
|
expect(error.diagnostics[3].style, DiagnosticsTreeStyle.errorProperty);
|
|
expect(error.diagnostics[3].value, position);
|
|
// RegExp matcher is required here due to flutter web and flutter mobile generating
|
|
// slightly different floating point numbers
|
|
// in Flutter web 0.0 sometimes just appears as 0. or 0
|
|
expect(
|
|
error.toStringDeep(),
|
|
matches(
|
|
RegExp(r'''
|
|
FlutterError
|
|
ClampingScrollPhysics\.applyBoundaryConditions\(\) was called
|
|
redundantly\.
|
|
The proposed new position\, 500(\.\d*)?, is exactly equal to the current
|
|
position of the given FixedScrollMetrics, 500(\.\d*)?\.
|
|
The applyBoundaryConditions method should only be called when the
|
|
value is going to actually change the pixels, otherwise it is
|
|
redundant\.
|
|
The physics object in question was\:
|
|
ClampingScrollPhysics
|
|
The position object in question was\:
|
|
FixedScrollMetrics\(500(\.\d*)?..\[0(\.\d*)?\]..500(\.\d*)?\)
|
|
''', multiLine: true),
|
|
),
|
|
);
|
|
}
|
|
});
|
|
|
|
testWidgets('PageScrollPhysics work with NestedScrollView', (WidgetTester tester) async {
|
|
// Regression test for: https://github.com/flutter/flutter/issues/47850
|
|
await tester.pumpWidget(
|
|
Material(
|
|
child: Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: NestedScrollView(
|
|
physics: const PageScrollPhysics(),
|
|
headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) {
|
|
return <Widget>[
|
|
SliverToBoxAdapter(child: Container(height: 300, color: Colors.blue)),
|
|
];
|
|
},
|
|
body: ListView.builder(
|
|
itemBuilder: (BuildContext context, int index) {
|
|
return Text('Index $index');
|
|
},
|
|
itemCount: 100,
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
await tester.fling(find.text('Index 2'), const Offset(0.0, -300.0), 10000.0);
|
|
});
|
|
}
|