mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
284 lines
8.0 KiB
Dart
284 lines
8.0 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
@immutable
|
|
class Pair<T> {
|
|
const Pair(this.first, this.second);
|
|
final T? first;
|
|
final T second;
|
|
|
|
@override
|
|
bool operator ==(Object other) {
|
|
return other is Pair<T> && other.first == first && other.second == second;
|
|
}
|
|
|
|
@override
|
|
int get hashCode => Object.hash(first, second);
|
|
|
|
@override
|
|
String toString() => '($first,$second)';
|
|
}
|
|
|
|
/// Widget that will layout one child in the top half of this widget's size
|
|
/// and the other child in the bottom half. It will swap which child is on top
|
|
/// and which is on bottom every time the widget is rendered.
|
|
abstract class Swapper extends RenderObjectWidget {
|
|
const Swapper({super.key, this.stable, this.swapper});
|
|
|
|
final Widget? stable;
|
|
final Widget? swapper;
|
|
|
|
@override
|
|
SwapperElement createElement();
|
|
|
|
@override
|
|
RenderObject createRenderObject(BuildContext context) => RenderSwapper();
|
|
}
|
|
|
|
class SwapperWithProperOverrides extends Swapper {
|
|
const SwapperWithProperOverrides({super.key, super.stable, super.swapper});
|
|
|
|
@override
|
|
SwapperElement createElement() => SwapperElementWithProperOverrides(this);
|
|
}
|
|
|
|
abstract class SwapperElement extends RenderObjectElement {
|
|
SwapperElement(Swapper super.widget);
|
|
|
|
Element? stable;
|
|
Element? swapper;
|
|
bool swapperIsOnTop = true;
|
|
List<dynamic> insertSlots = <dynamic>[];
|
|
List<Pair<dynamic>> moveSlots = <Pair<dynamic>>[];
|
|
List<dynamic> removeSlots = <dynamic>[];
|
|
|
|
@override
|
|
Swapper get widget => super.widget as Swapper;
|
|
|
|
@override
|
|
RenderSwapper get renderObject => super.renderObject as RenderSwapper;
|
|
|
|
@override
|
|
void visitChildren(ElementVisitor visitor) {
|
|
if (stable != null) {
|
|
visitor(stable!);
|
|
}
|
|
if (swapper != null) {
|
|
visitor(swapper!);
|
|
}
|
|
}
|
|
|
|
@override
|
|
void update(Swapper newWidget) {
|
|
super.update(newWidget);
|
|
_updateChildren(newWidget);
|
|
}
|
|
|
|
@override
|
|
void mount(Element? parent, Object? newSlot) {
|
|
super.mount(parent, newSlot);
|
|
_updateChildren(widget);
|
|
}
|
|
|
|
void _updateChildren(Swapper widget) {
|
|
stable = updateChild(stable, widget.stable, 'stable');
|
|
swapper = updateChild(swapper, widget.swapper, swapperIsOnTop);
|
|
swapperIsOnTop = !swapperIsOnTop;
|
|
}
|
|
|
|
@override
|
|
void insertRenderObjectChild(covariant RenderObject child, covariant Object? slot) {}
|
|
|
|
@override
|
|
void moveRenderObjectChild(
|
|
covariant RenderObject child,
|
|
covariant Object? oldSlot,
|
|
covariant Object? newSlot,
|
|
) {}
|
|
|
|
@override
|
|
void removeRenderObjectChild(covariant RenderObject child, covariant Object? slot) {}
|
|
}
|
|
|
|
class SwapperElementWithProperOverrides extends SwapperElement {
|
|
SwapperElementWithProperOverrides(super.widget);
|
|
|
|
@override
|
|
void insertRenderObjectChild(RenderBox child, Object? slot) {
|
|
insertSlots.add(slot);
|
|
if (slot == 'stable') {
|
|
renderObject.stable = child;
|
|
} else {
|
|
renderObject.setSwapper(child, slot! as bool);
|
|
}
|
|
}
|
|
|
|
@override
|
|
void moveRenderObjectChild(RenderBox child, bool oldIsOnTop, bool newIsOnTop) {
|
|
moveSlots.add(Pair<bool>(oldIsOnTop, newIsOnTop));
|
|
assert(oldIsOnTop == !newIsOnTop);
|
|
renderObject.setSwapper(child, newIsOnTop);
|
|
}
|
|
|
|
@override
|
|
void removeRenderObjectChild(RenderBox child, Object? slot) {
|
|
removeSlots.add(slot);
|
|
if (slot == 'stable') {
|
|
renderObject.stable = null;
|
|
} else {
|
|
renderObject.setSwapper(null, slot! as bool);
|
|
}
|
|
}
|
|
}
|
|
|
|
class RenderSwapper extends RenderBox {
|
|
RenderBox? get stable => _stable;
|
|
RenderBox? _stable;
|
|
set stable(RenderBox? child) {
|
|
if (child == _stable) {
|
|
return;
|
|
}
|
|
if (_stable != null) {
|
|
dropChild(_stable!);
|
|
}
|
|
_stable = child;
|
|
if (child != null) {
|
|
adoptChild(child);
|
|
}
|
|
}
|
|
|
|
bool? _swapperIsOnTop;
|
|
RenderBox? get swapper => _swapper;
|
|
RenderBox? _swapper;
|
|
void setSwapper(RenderBox? child, bool isOnTop) {
|
|
if (isOnTop != _swapperIsOnTop) {
|
|
_swapperIsOnTop = isOnTop;
|
|
markNeedsLayout();
|
|
}
|
|
if (child == _swapper) {
|
|
return;
|
|
}
|
|
if (_swapper != null) {
|
|
dropChild(_swapper!);
|
|
}
|
|
_swapper = child;
|
|
if (child != null) {
|
|
adoptChild(child);
|
|
}
|
|
}
|
|
|
|
@override
|
|
void visitChildren(RenderObjectVisitor visitor) {
|
|
if (stable != null) {
|
|
visitor(stable!);
|
|
}
|
|
if (swapper != null) {
|
|
visitor(swapper!);
|
|
}
|
|
}
|
|
|
|
@override
|
|
void attach(PipelineOwner owner) {
|
|
super.attach(owner);
|
|
visitChildren((RenderObject child) => child.attach(owner));
|
|
}
|
|
|
|
@override
|
|
void detach() {
|
|
super.detach();
|
|
visitChildren((RenderObject child) => child.detach());
|
|
}
|
|
|
|
@override
|
|
Size computeDryLayout(BoxConstraints constraints) {
|
|
return constraints.biggest;
|
|
}
|
|
|
|
@override
|
|
void performLayout() {
|
|
assert(constraints.hasBoundedWidth);
|
|
assert(constraints.hasTightHeight);
|
|
size = constraints.biggest;
|
|
const Offset topOffset = Offset.zero;
|
|
final bottomOffset = Offset(0, size.height / 2);
|
|
final BoxConstraints childConstraints = constraints.copyWith(
|
|
minHeight: constraints.minHeight / 2,
|
|
maxHeight: constraints.maxHeight / 2,
|
|
);
|
|
if (stable != null) {
|
|
final stableParentData = stable!.parentData! as BoxParentData;
|
|
stable!.layout(childConstraints);
|
|
stableParentData.offset = _swapperIsOnTop! ? bottomOffset : topOffset;
|
|
}
|
|
if (swapper != null) {
|
|
final swapperParentData = swapper!.parentData! as BoxParentData;
|
|
swapper!.layout(childConstraints);
|
|
swapperParentData.offset = _swapperIsOnTop! ? topOffset : bottomOffset;
|
|
}
|
|
}
|
|
|
|
@override
|
|
void paint(PaintingContext context, Offset offset) {
|
|
visitChildren((RenderObject child) {
|
|
final childParentData = child.parentData! as BoxParentData;
|
|
context.paintChild(child, offset + childParentData.offset);
|
|
});
|
|
}
|
|
|
|
@override
|
|
void redepthChildren() {
|
|
visitChildren((RenderObject child) => redepthChild(child));
|
|
}
|
|
}
|
|
|
|
BoxParentData parentDataFor(RenderObject renderObject) => renderObject.parentData! as BoxParentData;
|
|
|
|
void main() {
|
|
testWidgets('RenderObjectElement *RenderObjectChild methods get called with correct arguments', (
|
|
WidgetTester tester,
|
|
) async {
|
|
const Key redKey = ValueKey<String>('red');
|
|
const Key blueKey = ValueKey<String>('blue');
|
|
Widget widget() {
|
|
return SwapperWithProperOverrides(
|
|
stable: ColoredBox(key: redKey, color: Color(nonconst(0xffff0000))),
|
|
swapper: ColoredBox(key: blueKey, color: Color(nonconst(0xff0000ff))),
|
|
);
|
|
}
|
|
|
|
await tester.pumpWidget(widget());
|
|
final SwapperElement swapper = tester.element<SwapperElement>(
|
|
find.byType(SwapperWithProperOverrides),
|
|
);
|
|
final RenderBox redBox = tester.renderObject<RenderBox>(find.byKey(redKey));
|
|
final RenderBox blueBox = tester.renderObject<RenderBox>(find.byKey(blueKey));
|
|
expect(swapper.insertSlots.length, 2);
|
|
expect(swapper.insertSlots, contains('stable'));
|
|
expect(swapper.insertSlots, contains(true));
|
|
expect(swapper.moveSlots, isEmpty);
|
|
expect(swapper.removeSlots, isEmpty);
|
|
expect(parentDataFor(redBox).offset, const Offset(0, 300));
|
|
expect(parentDataFor(blueBox).offset, Offset.zero);
|
|
await tester.pumpWidget(widget());
|
|
expect(swapper.insertSlots.length, 2);
|
|
expect(swapper.moveSlots.length, 1);
|
|
expect(swapper.moveSlots, contains(const Pair<bool>(true, false)));
|
|
expect(swapper.removeSlots, isEmpty);
|
|
expect(parentDataFor(redBox).offset, Offset.zero);
|
|
expect(parentDataFor(blueBox).offset, const Offset(0, 300));
|
|
await tester.pumpWidget(const SwapperWithProperOverrides());
|
|
expect(redBox.attached, false);
|
|
expect(blueBox.attached, false);
|
|
expect(swapper.insertSlots.length, 2);
|
|
expect(swapper.moveSlots.length, 1);
|
|
expect(swapper.removeSlots.length, 2);
|
|
expect(swapper.removeSlots, contains('stable'));
|
|
expect(swapper.removeSlots, contains(false));
|
|
});
|
|
}
|