6296 Commits

Author SHA1 Message Date
Justin McCandless
63438b9244
Fix Vertical Alignment Regression (#34859)
Change the way outlined inputs vertically align their text to be more similar to how it used to be before a refactor. Fixes an edge case uncovered by a SCUBA test.
2019-06-21 11:24:54 -07:00
Emily Fortuna
bd9c900fce
Added some Widgets of the Week Videos to documentation (#34758)
* Added some Widgets of the Week to documentation: AspectRatio and AnimatedIcon.
2019-06-20 12:58:41 -07:00
Dan Field
71b9d461c8
Fix inline text span semantics (#34434) 2019-06-20 12:26:06 -07:00
Jacob Richman
38f849015c
Add more structure to errors messages. (#34684)
Breaking change to extremely rarely used ParentDataWidget.debugDescribeInvalidAncestorChain api changing the return type of the method from String to DiagnosticsNode.
2019-06-20 10:56:03 -07:00
Shi-Hao Hong
71254a6147
Custom height parameters for DataTable header and data rows (#33535)
* Custom dataRowHeight for DataTable and PaginatedDataTable

* Custom headingRowHeight for DataTable and PaginatedDataTable
2019-06-19 22:01:37 -07:00
chunhtai
c8c20fbc1f
add read only semantics flag (#34683) 2019-06-19 14:41:44 -07:00
Shi-Hao Hong
42d8383c9e
DataTable Custom Horizontal Padding (#33628)
* Add optional horizontalMargin and columnSpacing properties to DataTable

* Add horizontalMargin and columnSpacing tests for DataTable and PaginatedDataTable
2019-06-19 12:59:41 -07:00
Jim Graham
e6f896e336
Adjust defaults in docs to match new defaults in code. (#34664)
(and fix grammar)

See: https://github.com/flutter/flutter/pull/21826
2019-06-19 12:55:44 -07:00
Yegor
b15b5b90a0
Do not copy paths, rects, and rrects when layer offset is zero (#34587) 2019-06-19 12:32:12 -07:00
Justin McCandless
b798b27bbd
Text field vertical align (#34355)
Adds the `textAlignVertical` param to TextField and InputDecorator, allowing arbitrary vertical positioning of text in its input.
2019-06-19 08:23:59 -07:00
Haijun
91213e2ed6 fixed cupertinoTextField placeholder textAlign (#33739) 2019-06-18 23:36:40 -07:00
Michael Goderbauer
b106fd0da9
Fix-up code sample for TweenSequence (#34679) 2019-06-18 18:30:34 -07:00
LongCatIsLooong
2602119194
Cupertino text edit tooltip rework (#34095) 2019-06-18 18:29:10 -07:00
chunhtai
9d38db421c
fix ExpansionPanelList merge the header semantics when it is not necessart (#33808) 2019-06-18 15:24:34 -07:00
chunhtai
00d95e6212
fix page scroll position rounding error (#34519) 2019-06-18 15:23:26 -07:00
Kate Lovett
7d95e8e0c1
Splitting golden file versioning out as an argument of matchesGoldenFile (#33880)
* Splitting golden file versioning out as an argument of matchesGoldenFile

* Fixing description implementation.

* Removing unused imports

* Removing unused import

* Review feedback
2019-06-18 11:32:13 -07:00
Dan Field
4a60bee7c0
Release diagnostics (#34474)
Skip diagnostics on release mode, add test in firebase testlab
2019-06-18 11:06:09 -07:00
Jonah Williams
5e467bda3a
Remove @protected annotation on ImageProvider.obtainKey (#34600) 2019-06-17 14:59:21 -07:00
Van Looveren Koen
60d2735e1a Added customizable padding for the segmented controll (#34555) 2019-06-16 14:58:04 -07:00
Devon Carew
5f521eea22
add route information to Flutter.Navigation events (#34508)
* add route information to Flutter.Navigation events

* route can be null; re-work how we send route info to accomidate that
2019-06-15 20:40:34 -07:00
Jonah Williams
dfa39f3ee5
Separate web and io implementations of network image (#34112)
* add web and io implemenations of network and asset image

* fix foundation import

* update to remove extra asset image indirection

* skip chunk test

* address comments

* disable non-functional test

* disable all golden tests

* address comments
2019-06-15 10:20:45 -07:00
Anthony
8b2ccca3a4
[Material] Fix TextDirection and selected thumb for RangeSliderThumbShape and RangeSliderValueIndicatorShape (#34501)
Expose the RangeSlider's TextDirection in the RangeSliderThumbShape's abstract paint() method, and ensure that start and end thumb are non-null when being passed to the thumb and value indicator shape paint methods.
2019-06-15 09:44:01 -04:00
Dan Field
3d58400e76
Revert "Revert "redux of a change to use new engine APIs for Flutter.Frame events (#34365)" (#34514)" (#34530)
This reverts commit 8f75d53735bcfc2b988e84f50e3b4e43dbbd1c7f.
2019-06-15 00:01:35 -07:00
Dan Field
1427fef8f8
Make sure fab semantics end up on top (#34512) 2019-06-14 14:47:54 -07:00
Keerti Parthasarathy
8f75d53735
Revert "redux of a change to use new engine APIs for Flutter.Frame events (#34365)" (#34514)
This reverts commit ceb09b8badbfbc983bdf27ae51008935c7d584ee.
2019-06-14 13:08:14 -07:00
Devon Carew
ceb09b8bad
redux of a change to use new engine APIs for Flutter.Frame events (#34365) 2019-06-14 11:16:54 -07:00
Kate Lovett
81bbd3e12c
SliverFillRemaining flag for different use cases (#33627)
* WIP

* Fixing nested scroll view tests

* Fixing nested scroll view tests

* Fixing nested scroll view tests

* WIP

* Added flag for SliverFillRemaining

* Clean up

* Review

* Reverted nested scroll view tests

* Updating tests

* Updated for overscroll behavior
2019-06-14 09:44:57 -07:00
LongCatIsLooong
ef1e64124d
SizedBox documentation (#34424) 2019-06-14 09:18:40 -07:00
LongCatIsLooong
731e9819e2
Allow "from" hero state to survive hero animation in a push transition (#32842) 2019-06-13 20:41:43 -07:00
Dan Field
ea6b758720
Fix semantics_tester (#34368) 2019-06-13 16:15:00 -07:00
Michael Goderbauer
72828d66cf
Include raw value in Diagnostics json for basic types (#34417) 2019-06-13 16:14:14 -07:00
Jonah Williams
8c6841c738
skip bottom_sheet (#34430) 2019-06-13 12:23:18 -07:00
Michael Goderbauer
eb9160eb93
Extract DiagnosticsNode serializer from WidgetInspector (#34012) 2019-06-13 11:30:18 -07:00
Jonah Williams
aedf46afc7
Disable flaky tests (#34419) 2019-06-13 11:19:09 -07:00
LongCatIsLooong
5f39487740
Don't show scrollbar if there isn't enough content (#34175) 2019-06-12 17:55:31 -07:00
Jonah Williams
3ae6abd9e8
Compatibility pass on flutter/material tests for JavaScript compilation. (9) (#33378) 2019-06-12 17:06:01 -07:00
chunhtai
ad507723ec
fix Applying decoration for a table row widget will cause render exception (#34285) 2019-06-12 16:58:24 -07:00
Todd Volkert
c40c687b2d
Add widget of the week videos (#34356)
* Spacer
* MediaQuery
* InheritedWidget
2019-06-12 16:36:09 -07:00
Todd Volkert
8163c0aebb
Re-apply compressionState changes. (#34341)
This re-applies the changes that were made in #33697 and #33729,
but which were reverted in #33792 and #33790, respectively due to
the Dart SDK not having received the update within Google yet.
The SDK has now rolled, so these changes can be re-applied.

https://github.com/flutter/flutter/issues/32374
https://github.com/flutter/flutter/issues/33791
2019-06-12 13:47:47 -07:00
Devon Carew
25c84001c4
Revert "update the Flutter.Frame event to use new engine APIs (#34243)" (#34352)
This reverts commit 446179f6c1c9c7101c9a8f88edebfd7643a13c2d.
2019-06-12 13:14:20 -07:00
Devon Carew
446179f6c1
update the Flutter.Frame event to use new engine APIs (#34243)
* update the Flutter.Frame event to use new engine APIs

* add a test

* update test
2019-06-12 11:20:10 -07:00
Jonah Williams
9d724d4c44
Compatibility pass on flutter/widgets tests for JavaScript compilation. (8) (#33377) 2019-06-11 14:51:03 -07:00
LongCatIsLooong
1eb8c640bb
Fix CupertinoTabScaffold index out of range (#33624) 2019-06-11 14:14:54 -07:00
guoskyhero
1bc8402478 Add hintStyle in SearchDelegate (#30388)
SearchDelegate hintStyle parameter
2019-06-11 11:15:50 -07:00
Jonah Williams
7feddfdec0
make sure this test doesnt run for real (#34199) 2019-06-11 10:35:10 -07:00
Neevash Ramdial
d850d69c3f Added tool sample for PageController (#34137)
* Added tool sample for PageController

* Fixed text directionality bug
2019-06-11 09:57:17 -07:00
Jonah Williams
05e92c828b
Compatibility pass on flutter/physics tests for JavaScript compilation. (6) (#33359) 2019-06-11 09:09:13 -07:00
LongCatIsLooong
e9ca112e44
update CupertinoDialogAction isDefaultAction documentation (#34163) 2019-06-10 19:17:55 -07:00
Jonah Williams
ca14af6b92
Compatibility pass on flutter/rendering tests for JavaScript compilation. (5) (#33355) 2019-06-10 17:29:46 -07:00
Anthony
0bbac72558
[Material] Fix slider track shape to rounded (#34178)
The slider track shape for the onPrimaryColors constructor should be rounded, but it was accidentally changed to rectangular in #31681. This change restores the original behavior. This only affects sliders that are themed with SliderThemeData.onPrimaryColors().
2019-06-10 19:02:44 -04:00