6211 Commits

Author SHA1 Message Date
Greg Spencer
387e2b0602
Add actions and keyboard shortcut map support (#33298)
This implements the keyboard shortcut handling and action invocation in order to provide a place in the infrastructure for keyboard events to trigger actions. This will allow binding of key events to actions like "move the focus to the next widget" and "activate button".
2019-06-04 11:30:24 -07:00
Justin McCandless
a35d6615ee
Double double tap toggles instead of error (#33802)
Fix exception that was happening when double-double-tapping a TextField (or double long tapping).
2019-06-04 10:39:08 -07:00
Tong Mu
c482edac4f
Revert "Move declaration of semantic handlers from detectors to recognizers (#33475)" (#33851)
This reverts commit 572f349f5c7db7a783870ea8d4ecc641a365563f.
2019-06-04 10:13:15 -07:00
Justin McCandless
fce54ae685
Handles hidden by keyboard (#32838)
Extra space when scrolling to selected input so that the selection caret is visible.
2019-06-04 08:37:29 -07:00
Kate Lovett
04015b987b
Fixing duplicate test names. (#33805) 2019-06-04 07:01:52 -07:00
Jonah Williams
7442eeafe5
Reland https://github.com/flutter/flutter/pull/33663 (#33828) 2019-06-04 00:41:21 -07:00
Jonah Williams
83986acbdb
Add a real-er web restart, doctor, workflow (#33786) 2019-06-03 23:19:42 -07:00
Todd Volkert
6d554827b6
Revert "Use conditional imports for flutter foundation libraries (#33663)" (#33825)
This reverts commit 90500a5dc4341dd41f3ae0d99fc92daa5ffd2a9c.
2019-06-03 22:00:45 -07:00
Greg Spencer
a70b020e18
Add pseudo-key synonyms for keys like shift, meta, alt, and control. (#33695)
This adds a list of key synonyms for non-printable keyboard keys that appear in more than one place So keys like LogicalKeyboardKey.shiftLeft and LogicalKeyboardKey.shiftRight now can be mapped to just LogicalKeyboardKey.shift.

I also fixed a bug in the gen_keycodes tool where GLFW entries would get removed if they weren't parsed from the source on the web.
2019-06-03 18:41:04 -07:00
Todd Volkert
cb90617911
Revert "ModalRoute resumes previous focus on didPopNext (#33152)" (#33815)
This reverts commit 0f2254a5c334b2435167083b48e681f4fb18acd4.
2019-06-03 17:24:56 -07:00
Shi-Hao Hong
3b75fbe31d
Move dropdownValue into State in sample (#33665) 2019-06-03 16:22:16 -07:00
Tong Mu
572f349f5c
Move declaration of semantic handlers from detectors to recognizers (#33475)
- A refactor that moves the semantics declaration from detectors to recognizers to allow custom recognizers to respond to semantic gectures.
- Renames all handlers related to semantics from Gesture* to Semantics*.
2019-06-03 15:07:23 -07:00
Jonah Williams
90500a5dc4
Use conditional imports for flutter foundation libraries (#33663) 2019-06-03 14:56:15 -07:00
chunhtai
730025fa17
fix issue 14014 read only text field (#32059) 2019-06-03 14:00:43 -07:00
Todd Volkert
5441044132
Revert "Update consolidateHttpClientResponseBytes() to use compressionState (#33729)" (#33790)
This reverts commit 306a09a384e6ba0fe02ae3a44d28ceeb372b3a25.
2019-06-03 13:48:27 -07:00
Jonah Williams
6619ab8fea
Add web safe indirection to Platform.isPlatform getters (2) (#33780) 2019-06-03 13:16:14 -07:00
Jonah Williams
cd1d40a7c9
Revert "Add web safe indirection to Platform.isPlatform getters (#33406)" (#33776)
This reverts commit d92b3b40d2113a216bdfd7c2c69d9d0f4d905a0d.
2019-06-03 11:08:30 -07:00
Jonah Williams
d92b3b40d2
Add web safe indirection to Platform.isPlatform getters (#33406) 2019-06-03 10:55:36 -07:00
SimonIT
683238e82a Fix disabled CupertinoTextField style (#32974) 2019-06-03 10:34:47 -07:00
Ian Hickson
2767d37c96 RTL caret in text fields (#33461) 2019-06-03 10:25:54 -07:00
Brandon
f7bfd54934 fix GridView documentation (#33442) 2019-06-03 10:25:20 -07:00
Todd Volkert
306a09a384
Update consolidateHttpClientResponseBytes() to use compressionState (#33729)
This updates to use the new HttpClientResponse.compressionState
API that was recently added in the SDK.

https://github.com/flutter/flutter/issues/32374
2019-06-03 09:50:21 -07:00
Todd Volkert
31318b0ebf
Add documentation to ImplicitlyAnimatedWidgetState (#33674)
This is a follow-on to #33370 based on review comments
therein.
2019-06-01 15:49:19 -07:00
Chris Bracken
98ea501995
Revert "Add real-er restart for web using webkit inspection protocol (#33629)" (#33703)
Revert "fix devicelab manfiest (#33698)"

This reverts commit 5a6a00dc54cb9c5f6865fd31f930ca5665a0e4af.
This reverts commit 0d79f0fc79f1ab46f80a3d8d734fdadccea1fb4a.
2019-05-31 21:53:30 -07:00
Jonah Williams
5a6a00dc54
Add real-er restart for web using webkit inspection protocol (#33629) 2019-05-31 17:37:01 -07:00
Michael Goderbauer
ae23d4a490
Transform PointerEvents to the local coordinate system of the event receiver (#32192) 2019-05-31 16:48:50 -07:00
Todd Volkert
56940b544f
Update FadeInImage to use new Image APIs (#33370)
This updates FadeInImage to use the new Image.frameBuilder
API (added in #33369), to greatly simplify the implementation
of FadeInImage.

This also removes the FadeInImage.placeholderSemanticLabel property.
This property was added in #28799 for the sake of completeness (the bug
it fixed was the lack of any semantic label support in FadeInImage), but a
placeholder is a transient visual artifact, not something that affects the
underlying semantic meaning of the image.
2019-05-31 14:42:48 -07:00
Tong Mu
0f2254a5c3
ModalRoute resumes previous focus on didPopNext (#33152)
This PR changes ModalRoute so that, when the route on top of it is popped, it requests to focus on the last focus.
2019-05-31 14:15:20 -07:00
Greg Spencer
c289c99858
Update the keycodes from source (#33632)
Ran gen_keycodes.dart, which pulled a new keycode from the Chromium source. This PR just checks in that change.
2019-05-31 09:41:14 -07:00
Justin McCandless
d963e4fe35
Text selection handles are sometimes not interactive (#31852)
The text selection handles now feel a lot more responsive, and their implementation was cleaned up a bit.
2019-05-30 12:31:18 -07:00
Todd Volkert
cba41ca2ec
Remove assert from Image._handleImageFrame() (#33602)
Tickers being disabled and re-enabled can cause the
condition of a synchronous notification happening after
image frames have been delivered, which is valid in that
case. As such, this removes the assert.

https://github.com/flutter/flutter/issues/32374
2019-05-30 12:04:01 -07:00
chunhtai
170309d6fb
fix 23723 rounding error (#33473) 2019-05-30 11:59:07 -07:00
Greg Spencer
c7c0965cc5
Add DiagnosticableMixin (#33595)
This adds DiagnosticableMixin as a mixin class that provides the implementaion for Diagnosticable, so that we can now add diagnostics to classes which already have a base class.
2019-05-30 11:36:38 -07:00
Gary Qian
2cb5b24b02
Fix text scaling of strut style (#33462) 2019-05-30 10:13:17 -07:00
Tong Mu
fa3fbc89a3
Material allows "select all" when not collapsed (#32950)
This PR enables "Select all" on MaterialTextSelection when text is partially selected.
2019-05-30 10:03:31 -07:00
Greg Spencer
07aede4c31
Fix onExit calling when the mouse is removed. (#33477)
This PR solves two problems: currently, the onExit is called for a mouse pointer the moment the removal message is received, except that by the time it actually calls it, there is no _lastEvent for it in the mouse tracker (it's already been removed), resulting in an event being passed to the onExit that contains nulls for the position. Also, removePointer events don't actually get created with a position, although they easily could be, so that even the the _lastEvent in the mouse tracker were still populated, it would still give a null position and delta.

This PR adds support for the position and delta in a PointerRemovedEvent, and populates them. In addition, when a remove event is received, it doesn't actually remove the pointer until the mouse position check that gets scheduled actually happens.
2019-05-30 09:55:38 -07:00
chunhtai
bfc6df0e4f
fixed 33347 fill the gap during performLayout in SliverGrid and SliverFixedExtentList (#33467) 2019-05-30 09:24:02 -07:00
Jonah Williams
6feedcc6a4
use toFixedAsString and DoubleProperty in diagnosticProperties (#33488) 2019-05-30 08:57:10 -07:00
Todd Volkert
ca13add9c8
Fix/update several HTML links (#33539) 2019-05-29 20:14:52 -07:00
Jason Simmons
311cde98a6
Reland "Clean up some flutter_tools tests and roll dependencies" (#33225)
This relands flutter/flutter#33163 with a fix to the integration_ui test.
2019-05-29 19:04:35 -07:00
LongCatIsLooong
22ea031e28
Fix ScrollbarPainter thumbExtent calculation and add padding (#31763)
- Fixed extentInside calculation in ScrollMetrics
- Added asserts to extentInside getter, as well as ScrollPosition.applyContentDimensions to enforce minScrollExtent <= maxScrollExtent
- Added padding to ScrollbarPainter, updated implementation. Took care of some edge cases.
- Changed some scroll bar constants on Cupertino side.
2019-05-29 16:52:21 -07:00
Ben Konyi
c926aae4c7
Fixed broken link in debugProfileBuildsEnabled documentation (#33531) 2019-05-29 15:53:12 -07:00
Darren Austin
252a14ba2f
Fixed for DropdownButton crashing when a style was used that didn't include a fontSize (#33474)
Fixed an issue with a DropdownButton crashing when a style was used that didn't include a fontSize.
2019-05-29 13:18:34 -07:00
Todd Volkert
6884146925
Add loading support to Image (#33369)
This adds two new builders to the `Image` class:

* `frameBuilder`, which allows callers to control the widget
  created by an [Image].
* `loadingBuilder`, which allows callers fine-grained control
  over how to display loading progress of an image to the user.

`FadeInImage` can be simplified by migrating to the new API.
This is done in a follow-on commit.

https://github.com/flutter/flutter/issues/32374
2019-05-29 12:52:05 -07:00
Jonah Williams
925f5f1c53
Revert "Wire up hot restart and incremental rebuilds for web (#33197)" (#33529)
This reverts commit 52ae99682e4ced7e6f9575a571d3feaf5a2cec84.
2019-05-29 12:09:01 -07:00
Jonah Williams
52ae99682e
Wire up hot restart and incremental rebuilds for web (#33197) 2019-05-29 09:49:16 -07:00
Jonah Williams
0c517aecbb
remove empty file (#33489) 2019-05-29 09:24:36 -07:00
Jason Simmons
786d9cee50
Fix a missing_return analyzer error in a code example (#33468)
This will fix a failure in dev/bots/analyze-sample-code.dart when using
the tip of tree Dart SDK.
2019-05-28 16:32:09 -07:00
Jonah Williams
2d9b158faf
Revert "Framework support for font features in text styles (#33230)" (#33444)
This reverts commit 841286d652379a6e9f1e95d54c8c9e628f4f1d5c.
2019-05-28 11:35:03 -07:00
Harry Terkelsen
13e9bfcc94
Add binaryMessenger constructor argument to platform channels (#30406)
* Deprecates `BinaryMessages` in favor of a default instance of `BinaryMessenger`, called `defaultBinaryMessenger`
* Platform channels use the `defaultBinaryMessenger` for their binaryMessenger default argument.
2019-05-28 11:18:22 -07:00