5825 Commits

Author SHA1 Message Date
rami-a
4feefa3c9a
[Material] Fix radio ink ripple to be centered (#28845) 2019-03-14 10:21:03 -04:00
Dan Field
7ac2486a4c Revert "Always composite PhysicalModels (#28919)" (#29314)
This reverts commit 58fb183298643bb0c57acd0b50b2480e9d1d5779.
2019-03-13 22:19:31 -04:00
Gary Qian
96cb84a18c
Expose decorationThickness in TextStyle. Roll engine (12 commits) (#28751)
31b289f27 Fix indexing error in dart:ui TextStyle.toString (flutter/engine#8143)
fc2e6b61c Typo "fast an inline" to "fast and inline" (flutter/engine#8142)
0f19b2de0 Reland PerformanceOverlayLayer golden test (flutter/engine#8140)
073aadde1 Fix TextStyle decode misalignment (flutter/engine#8141)
d87d29054 Roll src/third_party/skia 406b068942f0..2eecc3ea3d71 (11 commits) (flutter/engine#8138)
5cef4a022 Use final state passed to dart before initialization as the initial lifecycleState. (flutter/engine#8124)
ffef51be6 Roll src/third_party/skia 665bc64a2dc4..406b068942f0 (8 commits) (flutter/engine#8137)
48efd0fb7 Roll src/third_party/skia 762ddd7e4352..665bc64a2dc4 (2 commits) (flutter/engine#8129)
f666adbbd Roll src/third_party/skia 2932a458957d..762ddd7e4352 (3 commits) (flutter/engine#8128)
8b0df6ded Bugfix #29203: NPE in getAccessibilityProvider in old FlutterView. (flutter/engine#8126)
8f7b18345 Roll src/third_party/skia c6d8781c4036..2932a458957d (2 commits) (flutter/engine#8125)
52b67fdd5 Expose decorationThickness to dart:ui (flutter/engine#8008)
2019-03-13 11:52:47 -07:00
sjindel-google
88a477cace
Fix text selection handles showing outside the visible text region (#24476)
Don't show handles outside the text field's boundary.
2019-03-13 18:10:02 +01:00
Michael Goderbauer
89a51272d5
Fix DartDoc for UniqueKey (#29245) 2019-03-12 18:32:42 -07:00
Dan Field
58fb183298
Always composite PhysicalModels (#28919)
* Always composite PhysicalModels
* Update tests to check layer tree instead of canvas for Physical shadows
2019-03-12 16:34:13 -07:00
guoskyhero
e82a7f06c6 Document that SearchDelegate.buildResults can be called multiple time… (#26785) 2019-03-12 16:17:33 -07:00
Sean D'Souza
a32810bc54 Docs edit for Tab Label Color (#29165) 2019-03-12 16:17:12 -07:00
liyuqian
8915cad443 No image shader caching in default shader warm-up (#29179)
* No image shader caching in default shader warm-up

It turns out that no matter how small the image is, too much memory will
be used. Hence remove the image shader caching and let the client
implement itself based on needs.

Fixes https://github.com/flutter/flutter/issues/29172

* Fix
2019-03-12 16:13:39 -07:00
Hans Muller
47f56712cc
Ensure that animated pairs of Tabs TextStyles have matching inherited values (#29175) 2019-03-12 12:27:30 -07:00
Michael Goderbauer
854d8bb0d9
Heroes and nested Navigators (#29069) 2019-03-12 11:49:17 -07:00
Hans Muller
d9096a4226
MaterialButton shape should override ButtonTheme shape (#29189) 2019-03-12 09:44:39 -07:00
Kate Lovett
c4ffbb5eb9
Update to ListView Sample Code in API Docs (#29072)
* Updated ListView Sample code with more examples for different constructors and also to match asset diagrams.

* Fixed MIA semicolons.

* Code cleanup.

* Added context for ListView.builder example.

* Analyzer does not like const and static usages.

* Replaced the const declarations with final. The analyzer does not like the use of const here, at all.

* Fixed parameterized declarations.
2019-03-12 09:31:15 -07:00
Michael Goderbauer
816ae4b193
Include platformViewId in semantics tree (#28953) 2019-03-12 07:44:39 -07:00
Dwayne Slater
b19df00c8e Fix MouseTracker annotation leak (#28990)
* Fix MouseTracker annotation leak

Map's remove method is typed `remove(Object key)`, which can cause bugs.

Modified the existing test to check if the annotation has been removed
from MouseTracker.
2019-03-11 13:41:10 -07:00
Michael Goderbauer
e9be230a06
Deprecate profile() (#29054) 2019-03-11 13:16:13 -07:00
stuartmorgan
5922a40e6a
Add support for scrollwheels (#22762)
Adds support for discrete scroll events, such as those sent by a scroll wheel.

Includes the plumbing to convert, dispatch, and handle these events, as well as
Scrollable support for consuming them.
2019-03-11 10:08:12 -07:00
Hiroki Matsue
e1005143dd Fix typo in RefreshIndicator constructor API doc 2019-03-11 09:16:12 -07:00
Kate Lovett
c7bb476b87
Update to Container Sample Code in API Docs (#29053)
* Updating sample code for container to match forthcoming diagrams in assets-for-api-docs.

* Analyzer unhappy with Colors, fixing.

* Resolving push conflict (hopefully)

* Analyzer fix.

* Corrected color to match brand gallery

* Fixing wrap and indentation.
2019-03-11 09:14:36 -07:00
Todd Volkert
f21497ee8c
Revert "Fix TextField height issues (#27205)" (#29093)
This reverts commit 9e9f48dabb8423a6285bddfb21e69f0751060459.
2019-03-09 01:17:58 -08:00
Alexandre Ardhuin
a0d1f93b07
fix block formatting (#29051) 2019-03-09 09:03:11 +01:00
Terje Lønøy
f20a3c2595 Add key support to cupertino button (#28900) 2019-03-08 16:14:43 -08:00
xster
34a85b3932
Fix CupertinoTabView tree re-shape on view inset change (#29024) 2019-03-08 16:13:51 -08:00
Yuqian Li
cb1b6502f1 Update docs 2019-03-08 15:42:54 -08:00
Justin McCandless
9e9f48dabb
Fix TextField height issues (#27205)
* Create new TextField attribute to control maxLength behaviour

* Create test case for maxLinesIncrementalHeight

* fix maxLinesIncrementalHeight set method

* fix editable_test.dart

* Just introducing some proposed API additions, renaming to expands

* Pass minLines and expands through to child widgets and validate

* minLines can't be null, and expands can't be true when maxLines is 1

* Implement minLines and maxLines height sizing logic

* Simplify minLines validation logic

* expands parameter proof of concept

* min/max mixup bug fix, and tests work with expands false

* Test expands=true cases, and fix textPainter.height being out of date

* Test all behavior matrix cases

* min/max assertion more strict, can't be equal

* Tests work that were missing expands serialization

* Action sheet tests no longer fail due to rounding error

* TextFieldFocus test no longer mysteriously fails

* TODOs for making expands nullable. Will depend on how Expanded wrapping works

* Expanded growth happens when expanded is true and maxLines is null

* Test Expanded wrapper

* No more overflow when wrapped in Expanded

* Docs improvements

* expands can be null

* Simplify error cases to support existing behavior

* Docs examples and other docs cleanup

* Expansion up to perfectly meet the parent size

* Fix analyze null error

* Fix test after move to nullable expands

* minLines defaults to null

* expands is now exclusively for expanding to parent height and not growth between min and max

* _layout rewritten to handle max height. Need to fix prefix tests and
reenable expands

* Tests for textfield overflowing parent

* layoutLineBox is documented and private

* expands works in new _layout

* _layout return numbers seem to perfectly match original _layout

* inputWidth comment after trying it out and failing tests

* Fix analyze errors

* WIP prefix/suffix do affect height

* Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original

* Tall prefix test that verifies pixel perfect layout

* Fix overflowing edge case and test it

* Clean up comments, old code, and todos

* Changing _expands causes relayout. Wasnt able to figure out how to test though...

* Clean up code review comments

* Fix misalignment when tall prefix and border, and clean up related test

* Simple code review cleanup

* Bring back inputWidth to _layout method

* Fix rounding errors showing up in mac tests

* Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine.

* Fix more rounding error mac tests
2019-03-08 12:22:43 -08:00
Greg Spencer
80082ac4d3
Remove references to obsolete SemanticsSortOrder (#29012)
This removes references to SemanticsSortOrder, which was removed a long time ago.
2019-03-08 09:39:45 -08:00
Greg Spencer
89512e46f6
Add/rewrite tests for FocusScope. (#28169)
In anticipation of changing a lot of the focus code, I'm adding some tests for the FocusScope.

As a result, I was able to find and fix a bug where there was an incorrect assert.

I also added some more documentation.

Several of the tests enforce what I think is incorrect behavior related to passing focus off when the widget tree gets rebuilt without focus nodes that were previously there, but I'm not going to change that behavior in this PR.

I also renamed focus_test.dart to focus_scope_test.dart to be more in line with our naming conventions.
2019-03-08 09:39:20 -08:00
Gary Qian
8f1a430557
Initialize the lifecycle state with initial state in window. Roll engine (19 commits) (#28688)
git log --oneline --no-merges f4951df193a7966f9ed4da43d555eee0913d84d1..a48cd16e077778a7aa5908e4faa4da07714260f2
a48cd16e0 Update a11y word forward/back enum names (https://github.com/flutter/engine/pull/8073)
b5f59ed89 Delay the vsync callback till the frame start time specified by embedder. (https://github.com/flutter/engine/pull/8072)
7426305f5 Mark const extern (https://github.com/flutter/engine/pull/8077)
d3f6d7a21 only partial rule revert (https://github.com/flutter/engine/pull/8078)
d71bfe58d Only build a full Dart SDK when building for the host system (https://github.com/flutter/engine/pull/8071)
de90dbff7 Refactor web configuration/ Add dartdevc (https://github.com/flutter/engine/pull/7978)
ff46dd38f Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (https://github.com/flutter/engine/pull/8070)
80c6dd286 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (https://github.com/flutter/engine/pull/8069)
68ed654ea Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (https://github.com/flutter/engine/pull/8067)
ca0bac4fb Revert "add signal to pointer kinds" (https://github.com/flutter/engine/pull/8066)
3fb627f2c add signal to pointer kinds (https://github.com/flutter/engine/pull/8065)
5a06afa2a Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (https://github.com/flutter/engine/pull/8063)
a93d99db9 A11y callback (https://github.com/flutter/engine/pull/8005)
3661d5e43 Re-land "Buffer lifecycle in WindowData" (https://github.com/flutter/engine/pull/8032)
471a2c89a Send scroll events from the macOS shell (https://github.com/flutter/engine/pull/8056)
2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (https://github.com/flutter/engine/pull/8060)
3335764ae Skip skp files in license check (https://github.com/flutter/engine/pull/8050)
7f16789b2 Remove redundant thread checker in FML. (https://github.com/flutter/engine/pull/8053)
840c5233a Correct URL for Cirrus CI build status badge (https://github.com/flutter/engine/pull/8054)
57c120a29 remove extra source files (https://github.com/flutter/engine/pull/8052)
4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (https://github.com/flutter/engine/pull/8051)
70a18b515 Add clang static analysis support to gn wrapper (https://github.com/flutter/engine/pull/8047)
b30f9897b Improve elevation bounds for physical shape layers (https://github.com/flutter/engine/pull/8044)
e37bd27b4 Fix weak pointer use violations in shell and platform view. (https://github.com/flutter/engine/pull/8046)
dd80fc9ff Add engine support for scrollwheel events (https://github.com/flutter/engine/pull/7494)
2019-03-07 20:05:42 -08:00
Kate Lovett
64d31016ed
Form Snippet for API Docs (#28857)
* Added code snippet for Form Class. ref:#21136

* Formatting adjustments.

* Changed wording related to GlobalKey.
2019-03-07 13:35:42 -08:00
xster
acf51d8e36
Add more doc pointing to the EditableText's rudimentary nature around gesture handling (#28955) 2019-03-07 13:25:32 -08:00
liyuqian
da8b340c4a
Quick fix for shader warm up (#28951)
Fix issues in https://github.com/flutter/flutter/pull/28687
2019-03-07 12:45:39 -08:00
Alexandre Ardhuin
440ce8fde6
Fix indentations of statements in BlockFunctionBody (#28933)
* fix indentof statements in BlockFunctionBody

* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
Tong Mu
2e1a8c746f
Add minimum time gap requirement to double tap (#28749)
* First impl with StopwatchWithZone

* Clean up params and name

* Remove outdated TODO

* Fix style

* Fix a missing param. Add @require

* Fix import meta

* Fix code style

* Add missing require. Fix comment style.

* Fix code style

* Fix code style
2019-03-06 15:58:37 -08:00
xster
0b6b39b39e
Move material iOS back swipe test to material (#28855) 2019-03-06 15:48:59 -08:00
Muhammed Salih Guler
11678da3b0 Add semantics label to FadeInImage. (#28799) 2019-03-06 15:38:35 -08:00
Ivan
ec27e04582 fix missing variable name (#28944) 2019-03-06 15:22:02 -08:00
Phil Quitslund
802eca29d2
set literal conversions (#27811) 2019-03-06 11:05:16 -08:00
Dan Field
608b03c79b
Update docs for ancestorWidgetOfExactType (#28675)
* doc update
2019-03-06 10:51:15 -08:00
Alexandre Ardhuin
4c1f4d14e1
fix some formatting issues (#28809)
* fix some formatting issues

* address review comments

* fix indent
2019-03-06 09:37:32 +01:00
Amir Hardon
5099701f88
Make RenderUiKitView reject absorbed touch events (#28666)
When a touch event that is in the bounds of a RenderUiKitView is absorbed by another render object,
the RenderUiKitView's handleEvent is not called for that object. On the platform side, the touch event hits the FlutterTouchInterceptingView which is waiting for a framework decision that never arrived on whether to reject or accept the gesture.

This change fixes the issue by having RenderUiKitView register a global PointerRoute, that is used to reject absorbed touch events.
2019-03-04 14:26:50 -08:00
Kate Lovett
013fd2112b
FAB Snippet for API Docs (#28752)
* Added code snippets for FloatingActionButton Class. ref:#21136

* Extraneous white spaces.

Co-Authored-By: Piinks <katelovett@google.com>

* Alignment correction.

* The analyze result wasn't showing on github interface. Checked through Cirrus and it's all-green.

Co-Authored-By: Piinks <katelovett@google.com>
2019-03-04 13:09:25 -08:00
Hans Muller
e8b87203c5
Handle Cupertino back gesture interrupted by Navigator push (#28756) 2019-03-04 11:42:00 -08:00
Jason Simmons
a1aea2e442
Use a simpler implementation of Diagnosticable.toString when running in profile/release mode (#28661)
Diagnosticable.toString may be called in performance sensitive contexts
(for example, creating debug labels for Tickers)
2019-03-04 11:05:20 -08:00
Jason Simmons
c3527389b6
Avoid the overhead of instantiating a generator in paintImage (#28736)
This function is called frequently with non-repeating images during many
animations
2019-03-04 11:04:51 -08:00
Kate Lovett
9b01d8a578
Expanded Snippet for API Docs (#28681)
* Added code snippet for Expanded class. ref:#21136

* Changed the code samples into snippet application samples.
2019-03-01 15:46:58 -08:00
Tong Mu
2a046aa42e
Add animation curve slowMiddle (#28540)
* Add curve fastInFastOut

* Rename it to slowCenter

* Rename to slowMiddle

* Add continuous test
2019-03-01 14:41:21 -08:00
Mouad Debbar
b94bf87c70
Text selection via mouse (#28290) 2019-03-01 13:57:10 -08:00
ocavue
1df28e8b7a Fix ink highlight effect of RawChip (#28653) 2019-03-01 10:33:58 -08:00
Dan Field
be083da9c6
improve error messages on Text constructors (#28709) 2019-03-01 10:20:08 -08:00
Hans Muller
4f185ecde6
Update TabController.indexIsChanging doc (#28663) 2019-03-01 08:03:01 -08:00