5764 Commits

Author SHA1 Message Date
Moein Porkamel
90d090e366 Fix typo (#28558) 2019-02-27 09:45:19 -08:00
liyuqian
19a6a6f431
Reland "Shader warm up (#27660)" (#28537)
This reverts commit adc8e159a548121a45ff7a45b4e556aff998d4bd.

This should be safe to land once https://github.com/flutter/flutter/pull/28530 gets merged

Merge on yellow doc test because the doc test is actually green.
2019-02-27 09:33:08 -08:00
liyuqian
dd5559a5b8
Add LICENSE test to presubmit checks (#28369)
## Description

Also update the existing dart files with missing licenses.

Without the fix, we'll emit the following error message
```
License headers cannot be found at the beginning of the following files.

/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
```

## Related Issues

Fixes https://github.com/flutter/flutter/issues/28368

## Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
- [x] All existing and new tests are passing.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I am willing to follow-up on review comments in a timely manner.

## Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

- [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
- [x] No, this is *not* a breaking change.

<!-- Links -->
[issue database]: https://github.com/flutter/flutter/issues
[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
2019-02-26 17:38:21 -08:00
Sander Kersten
d27f53904b Add lerping between Gradients with arbitrary number of colors and stops (#27435) 2019-02-26 15:16:59 -08:00
Anthony
70c8b63e15
[Material] Unit test for skipping Slider tick mark due to overdensity (#28013)
Added a unit test to check that the tick marks are skipped over when the divisions are set to a number that makes them less than 6dp away from each other.
2019-02-26 17:39:48 -05:00
xster
b09e64e142
Support iOS devices reporting pressure data of 0 (#28478) 2019-02-26 14:16:25 -08:00
Michael Goderbauer
1e5992a3c5
Fuschia -> Fuchsia (#28482) 2019-02-25 22:19:47 -08:00
lsaudon
6cc6e7e1f7 Add shapeBorder option on App Bar (#21834) 2019-02-25 16:03:32 -08:00
xster
ec00e974d0
Add long-press-move support for text fields 2 (#28242) 2019-02-25 14:34:54 -08:00
jslavitz
47724f97fa
Breaks the moveBy call from drag and dragFrom into two separate calls and changes the default behavior of DragStartBehavior to DragStartBehavior.start (#26438)
* Breaking change which sets the default DragStartBehavior to DragStartBehavior.start and changes WidgetTester.drag and WidgetTester.dragFrom by breaking the moveBy function call into multiple pieces.
2019-02-25 14:15:31 -08:00
stuartmorgan
62e55a45d4
Convert PointerEvent's toString to Diagnosticable (#27904)
Rather than building a description string by hand, use Diagnosticable
properties. Simplifies output, since many fields have uninteresting
default values in many cases, and makes it easier to add more loggable
properties in subclasses.

Issue #28014
2019-02-25 11:42:50 -08:00
Hans Muller
751f119c93
Ensure that the DropdownButton menu respects its parents bounds (#28371) 2019-02-25 10:58:17 -08:00
rami-a
fc6079a24f
[Material] Add the ability to theme trailing app bar actions independently from leading (#28214)
* Allow app bar actions to be themed independently if needed

* Update SliverAppBar docs that were out of date

* Clarify fallback behavior in a comment

* Analyzer

* Address PR feedback

* Address PR feedback

* Put back checks on actions icon theme

* Address PR feedback

* Retrigger CI
2019-02-25 13:47:05 -05:00
Brandon Rodriguez
c26a69e9cf [Typo] Update 'use' to 'user' (#28245) 2019-02-25 10:32:23 -08:00
Michael Goderbauer
b7f29f2b32
Add more docs to BackdropFilter (#28017) 2019-02-25 10:27:20 -08:00
Dan Field
ad68ba303b
fix red build for analysis (#28398) 2019-02-23 09:39:36 -08:00
Gary Qian
7b5a769b31
Force line height in TextFields with strut (#27612) 2019-02-23 03:35:37 -08:00
liyuqian
adc8e159a5
Revert "Shader warm up (#27660)" (#28376)
This reverts commit a44f174efc218ac1b4b94b9d77dafdb5dfea1432.

Reason: start_up tests become flaky.

See https://github.com/flutter/flutter/issues/28374

TBR: xster

Merge on red to fix the tree
2019-02-22 17:32:37 -08:00
liyuqian
a44f174efc
Shader warm up (#27660)
This patch adds a default shader warm up process which moves shader compilation from the animation time to the startup time. This also provides an extension for `runApp` so developers can customize the warm up process.

This should reduce our worst_frame_rasterizer_time_millis from ~100ms to ~20-30ms for both flutter_gallery and complex_layout benchmarks. Besides, this should also have a significant improvement on 90th and 99th percentile time (50%-100% speedup in some cases, but I haven't tested them thoroughly; I'll let our device lab collect the data afterwards).

The tradeoff the is the startup time (time to first frame). Our `flutter run --profile --trace-startup` seems to be a little noisy and I see about 100ms-200ms increase in that measurement for complex_layout and flutter_gallery. Note that this only happens on the first run after install or data wipe. Later the Skia persistent cache will remove the overhead.

This also adds a cubic_bezier benchmark to test the custom shader warm up process.

This should fix https://github.com/flutter/flutter/issues/813 (either by `defaultShaderWarmUp`, or a `customShaderWarmUp`).
2019-02-22 15:37:02 -08:00
rami-a
b73dd0e81e
[Material] Add ability to set shadow color and selected shadow color for chips and for chip themes (#28163)
* Add ability to set shadow color for chips and for chip themes

* Add selected shadow color as a property as well

* Update phrasing of documentation

* Address PR feedback
2019-02-22 15:50:39 -05:00
ocavue
0f218e427c Make extended FAB's icon optional (#27711) 2019-02-22 12:47:52 -08:00
xster
d749e0b573
Add some more CupertinoPicker doc (#28166) 2019-02-21 22:16:29 -08:00
Stanislav Baranov
3837ec9e96
Reland #27754, now that bsdiff has moved to flutter/packages. (#28291) 2019-02-21 21:59:41 -08:00
xster
98455df459
Add slight clarification to debugDeterministicCursor (#27898) 2019-02-21 16:18:42 -08:00
Hans Muller
617ca62709
[Material] Expand BottomNavigationBar API (reprise) (#28159) 2019-02-21 16:05:36 -08:00
Michael Goderbauer
b96ae03b42
Add backgroundColor argument to TextStyle for convenience (#28172) 2019-02-21 15:58:30 -08:00
Alexandre Ardhuin
5169ab5974
format parameter list (#27261) 2019-02-21 09:27:07 +01:00
jslavitz
2c558fdb21
Adds fix for NAN value and pressure values outside of device reported min and max (#26659)
* Fix for nan pressure values and values outside min and max pressure ranges
2019-02-20 16:15:53 -08:00
jslavitz
a5820011b3
Adds media query check in editable_text (#27955)
* media query check
2019-02-20 16:14:48 -08:00
Matt Sullivan
088b6062fd
Added sample code to AnimatedWidget (#27803)
* Added sample to AnimatedWidget

* Updated AnimatedWidget example to use listenable from parent

* Made progress private and changed widget name
2019-02-20 15:50:34 -08:00
Ali EP
307848953f Fixes crossAxisSpacing overflow in RTL (#27945) 2019-02-20 15:43:01 -08:00
Sander Kersten
d1136e3109 Fix issue where SliverPersistentHeader that is both floating and pinned would scroll down when scrolling past the beginning of the ScrollView (#27433) 2019-02-20 15:42:15 -08:00
Michael Goderbauer
655800260a
Add TextOverflow.visible (#28182) 2019-02-20 15:40:25 -08:00
xster
e100ddfe26
Rename SuperellipseShare ContinuousRectangleBorder (#28183) 2019-02-20 15:35:22 -08:00
xster
39b1ff1aa3
revert 26001 (#28032) 2019-02-20 15:34:44 -08:00
Kaushik Iska
9931a275b9
Add outer try block for obtainKey errors. Add docs. (#27953)
* Add outer try block for obtainKey errors. Add docs.

* change to // from ///, and do specific error handling

* Add return statement after error

* Add test
2019-02-20 15:31:07 -08:00
Michael Goderbauer
fbafe64fd7
Fix 'to to' (#28216) 2019-02-20 09:57:42 -08:00
Dan Field
dd23be3936
Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560 (#28178)
* Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560

* update goldens

* update goldens version
2019-02-19 21:35:31 -08:00
Hans Muller
19f79ac8da
Add extendBody parameter to Scaffold, body MediaQuery reflects BAB height (#27973) 2019-02-15 14:48:39 -08:00
Jonah Williams
c8c67b79c3
remove accidentally commited libs (#28011) 2019-02-15 11:59:23 -08:00
jslavitz
07fdfb70d3
Fixes switch vibration (#27900)
* Fixes Cupertino switch vibration
2019-02-15 10:55:06 -08:00
Gary Qian
29618f0b04
Roll engine for flutter/engine#7791 - Add trailing whitespace tracking. 2019-02-15 10:28:21 -08:00
Kate Lovett
70dfe01a15
Sample code for Icon class (#27968)
* Added sample code for a simple Icon, ref: #21136

* Removed duplicate line.

* Fixed incoreect parameter.

* Update icon.dart

Removed empty prose and added better context for sample code. Changed sample code for better visibility in execution of default app themes.

* Alas, Trailing space.

Nixed trailing space in comments.
2019-02-15 10:24:14 -08:00
Michael Goderbauer
a4de06ade0
Reapply "Fix overflow clipping/fading for text (#27892)" (#27980)
Fixes https://github.com/flutter/flutter/issues/25025
2019-02-15 09:37:33 -08:00
Todd Volkert
3b47b44348
Re-apply "Ensure all curves return 0 and 1 in .transform(t) when t=0/1" (#28006)
Re-applies #27409 by reverting #27919

The analyzer issue (dart-lang/sdk#35940) has been temporarily
worked around by virtue of #27929
2019-02-15 12:29:09 -05:00
Greg Spencer
262f12b4a9
Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793)
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.

I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.

This PR fixes these problems with examples:

1. Switching tabs in a snippet now works if there is more than one snippet in
   a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
   recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
   it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
   widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
   samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
   remove the contents of the supplied temp directory before running, since
   having files that hang around is problematic (only a problem when running
   locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
   exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
   the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
   the samples thanks to dartfmt, but still).

Fixes #26398
Fixes #27411
2019-02-15 07:48:49 -08:00
Martin Kustermann
7862bef13a
Use double literals where a double type is expected (#27929)
This makes the code more consistent but also fixes our flutter-analyze bot.

Issue https://github.com/dart-lang/sdk/issues/35940
2019-02-15 14:10:55 +01:00
Jonah Williams
9bc5656637
Wire dart2js through flutter tool, add compilation test (#27668) 2019-02-14 22:42:30 -08:00
xster
8661d8aecd
Test text paint orders by color (#27983) 2019-02-14 19:19:53 -08:00
xster
22f8880909
Make sure the selection is still painted under the text (#27970) 2019-02-14 16:50:06 -08:00