5627 Commits

Author SHA1 Message Date
Gary Qian
d0595f6bbd
Explain font platform inconsistency (#26996) 2019-01-25 13:40:05 -05:00
Dan Field
496c57386b
Update packages (#27046)
* Update packages

* Change test for isFile
2019-01-24 16:02:45 -08:00
Frederik Schweiger
d1bde2edde Add reverse functionality to repeat() of AnimationController (#25125) 2019-01-24 09:30:45 -08:00
Will Larche
c362d8da07 [Material] Theme data type for cards (#26796)
This change adds a CardTheme and tests for it.

Golden is here:
ec26eeebb4/packages/flutter/test/material/card_theme.custom_shape.png

From commit:
ec26eeebb4 (diff-7564b206413654283ddc5cb59ecd64d4)
2019-01-24 11:01:21 -05:00
Chris Bracken
65a70bc7d3
Re-enable use of ParagraphConstrains const ctor (#26990)
All embedders of Flutter within Google have all been updated to an
engine version that includes the const constructor added in
flutter/engine#7346 and rolled into the framework in
flutter/flutter#26252.

This reverts commit 88b77a7d0fe5b00baaf63280d48398cf85a99ce6.

This fixes https://github.com/flutter/flutter/issues/26390.
2019-01-23 16:32:23 -08:00
Dan Field
ded49cda27
Assert when calling a method that tries to use the ticker unsafely after dispose (#26991) 2019-01-23 16:30:41 -08:00
Alexandre Ardhuin
66f424f0f8
fix some bad indentations (#26921)
* fix some bad indentations

* remove suspicious line
2019-01-23 15:43:27 +01:00
Hans Muller
7619c68655
Add Dismissible.confirmDismiss callback (#26901) 2019-01-22 16:39:09 -08:00
Hans Muller
c37b7c535c
Dismissible not dismissable (#26911) 2019-01-22 15:06:56 -08:00
jslavitz
cf4fc966f4
Transition Curve Fix (#25488)
* Changes Cupertino page transition curves to make paging animations more similar to those of native iOS
2019-01-22 12:46:39 -08:00
Kartik Sharma
5b3e933c7f Added Sample code for Stack widget (#26586) 2019-01-22 12:31:10 -08:00
xster
890085e9b0
Add another test to ImageStream (#26693) 2019-01-22 11:29:00 -08:00
xster
8098b5e63e
Fill editable_text.dart test coverage (#26793) 2019-01-22 10:51:39 -08:00
rami-a
af0758e67d
[Material] Implement App Bar Theme (#26597)
This change creates an `AppBarTheme` to be used with `AppBar` widgets. This allows for users to theme their AppBars separately from their overall Theme if they choose.
2019-01-22 09:39:58 -05:00
sjindel-google
4881777203
Fix behavior of handleDrawFrame() in benchmark mode. (#25049) 2019-01-22 11:46:14 +01:00
Mehmet Fidanboylu
c8379ad54f
Better ListTile leading/trailing widget alignment (#26778) 2019-01-19 11:55:05 -08:00
Ian Hickson
31a9626c48
[O] Removing all timeouts (mark II) (#26736)
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
2019-01-19 00:31:05 -08:00
jslavitz
7751144c23
Revert switch drag behavior (#26770) 2019-01-18 13:13:35 -08:00
rami-a
1b0f2015a2
Fix lerp in textTheme to allow for null parameters (#26764)
There's no reason to disallow this as TextStyle can handle lerping between null parameters just fine. This change also adds tests to ensure the correct behavior
2019-01-18 14:28:30 -05:00
MH Johnson
5d0c1b86ee
[Material] Inline the single Theme.of(context) call in BAB (#26765) 2019-01-18 14:13:14 -05:00
Jonah Williams
8c5a41113e
Add support for reverse to ReorderableListView (#26203) 2019-01-18 10:10:44 -08:00
Greg Spencer
179fa90489
Fix some doc references (#26441) 2019-01-18 10:07:55 -08:00
jslavitz
4fe79442c8 Reverts default DragStartBehavior to DragStartBehavior.down (#26734) 2019-01-17 19:36:48 -08:00
MH Johnson
6c07863f8d
[Material] Refactor _build<Widget> methods in BottomNavBar (#26722) 2019-01-17 19:02:34 -05:00
Michael Goderbauer
45a70efa8a
Respect EditableText.keyboardAppearance (#26721) 2019-01-17 14:54:35 -08:00
Will Larche
60e9c5856d
[FAB] Adding FAB as class in tests. (#26192)
* [FAB] Adding FAB as class in tests.

* [Material] FAB theme tests corrected. Also deeper into Material for elevation testing.

* [Material] Comment clarification.

* [Material] TODO formatting.

* [Material] Formatting.

* [Material] Comment correction.

* [Material] Updated values.

* [Material] Removing comment, low-level check, and adding safety.
2019-01-17 14:39:22 -08:00
David Shuckerow
9e4c964072
Add animation tests for changes to the FloatingActionButtonLocation (#23677)
* Add more animation tests for rotation

* Test animation progress

* Progress on the tests

* Everything 'works'

* We don't need to guarantee the rotation of the fab as it exits.

* Remove print statement

* Cleanup extra lines

* Remove whitespace
2019-01-17 14:48:28 -06:00
Michael Goderbauer
975ea595e9
Fix missing const analyzer warning (#26716)
Introduced by merging an old PR (https://github.com/flutter/flutter/pull/21157).
2019-01-17 12:23:55 -08:00
Remi Rousselet
649f49d4bf Swap scope with gesture (#21157) 2019-01-17 11:11:35 -08:00
Michael Goderbauer
56039b4ba7
Make getOffsetToReveal work with nested Viewports (#26663)
Fixes #20893, the most-upvoted bug for framework.

A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
2019-01-17 11:03:07 -08:00
Gazihan Alankus
7e22b5f2c5 Doc fix: SliverChildBuilderDelegate is the lazy one (#26690) 2019-01-17 09:51:50 -08:00
Jonah Williams
fb2467d0af
Add documentation for how to use annotated region (#24989) 2019-01-17 09:30:05 -08:00
Ian Hickson
800a6e1670 Quick fix for tap-to-show-keyboard regression (#26629)
* Fixes Android keyboard bug
2019-01-16 17:30:26 -08:00
Kenzie Schmoll
a172de0159
Send ServiceExtensionToggled event when service extension is set to a value. (#26426) 2019-01-16 12:29:20 -08:00
Kyrel Jerome
a0f58c5e7a Grammatical fix: "places" to "placed" (#26482) 2019-01-16 10:43:29 -08:00
Chris Bracken
9a7b1a73bd
Replace platform check with swtich (#24752)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-16 10:31:44 -08:00
MH Johnson
5e8e39723d
[Material] TabBarTheme text style parameters (#26533)
* Add labelStyle + unselectedLabelStyle to TabBarTheme
2019-01-16 13:30:21 -05:00
Michael Goderbauer
e4c8f1b993
3D SemanticsTree (#25670) 2019-01-16 10:29:00 -08:00
Justin McCandless
14faa8d935
Fix rounding error in build tests (#26652) 2019-01-16 09:48:04 -08:00
Michael Goderbauer
b4e9d0a440
Add tests for getOffsetToReveal on RenderSlivers (#26598) 2019-01-16 08:47:37 -08:00
rami-a
f22043e25f
Prevent crash when calling lerp for IconThemeData with null arguments (#26592)
The lerp method for IconThemeData was not doing anything to prevent exceptions when null arguments are used. This change fixes that and adds a test for it.
2019-01-16 11:42:29 -05:00
Hans Muller
14f486685e
Updated AlertDialog content doc (#26613) 2019-01-16 08:35:51 -08:00
Hans Muller
fbedd97682
IconButton backgroundColor doc sample (#26611) 2019-01-16 08:35:34 -08:00
Justin McCandless
105026cd68
Fix descenders cutoff in TextField (#26309)
* Include caret gaps in position calculation to avoid descender cutoff

* Calculate caret offset instead of exposing it

* Test that textfields scroll vertically by full line height

* Only add offset to end of caret to avoid going above 0.0

* Fix and test horizontal vs. vertical scrolling

* CR: docs and top caret offset logic

* Take max instead of assuming caretRect.top is always a full line down

* Always subtract caretOffset from caretTop since caretRect.top can be negative
2019-01-16 08:13:00 -08:00
Chris Bracken
584ef083c7
Replace Android-specific check with switch (#24754)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-15 19:42:55 -08:00
Seth Westphal
71a15896d8 Fix error message and other typos (#25126) 2019-01-15 19:22:32 -08:00
Michael Goderbauer
f3f2d5a1bd
Remove TODO, reduce tech debt (#26612)
I fixed this TODO a while ago during my a11y work.
2019-01-15 19:06:07 -08:00
Michael Goderbauer
e8bfa81b70
Roll engine to 5983e34a3c0e1217da7e8bbe9f2fe685048fe259 (#26596) 2019-01-15 19:00:05 -08:00
Gary Qian
fc779c69a7
Add Golden test for background painting order. (#25988) 2019-01-15 19:40:39 -05:00
Ian Hickson
29928a46ed
Support setting the elevation of disabled floating action buttons (#24728)
Previously, a disabled floating action button always had zero
elevation, which looks dumb.

This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.

This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
2019-01-15 15:06:29 -08:00