7295 Commits

Author SHA1 Message Date
LongCatIsLooong
87cbddddd8
Let cupertino & material switches move to the right state after dragging (#51606) 2020-03-20 15:56:01 -07:00
Yegor
2e36be7691
Enable more material and cupertino tests on the Web (#52961) 2020-03-20 11:36:24 -07:00
Tong Mu
bbc0cc07f6
Move mouse_tracking.dart to rendering (#52781)
* Move mouse_tracking to rendering

* Move test
2020-03-20 11:22:02 -07:00
Yegor
5ea13b8493
fix KeySet.hashCode; enable multiple web tests (#52861)
fix KeySet.hashCode; enable multiple web tests
2020-03-20 08:49:19 -07:00
chunhtai
3998549d52
Revert "fixes sliver list child layout offset calculation (#42703)" (#52923)
This reverts commit 11efa00f9f51d0f42fea4f206651ea974f59e42b.
2020-03-20 06:07:25 -07:00
rami-a
e2610a450c
[Material] Allow Appbar to exclude header semantics (#52894) 2020-03-19 15:06:02 -07:00
chunhtai
11efa00f9f
fixes sliver list child layout offset calculation (#42703) 2020-03-19 14:51:04 -07:00
Ayush Bherwani
6c2a29dd37
[Api Docs] Improves contentPadding documentation in InputDecoration (#52807) 2020-03-19 09:26:02 -07:00
Gary Qian
ee8131b430
Reland formatter changes (#52765) 2020-03-18 15:56:02 -07:00
Yegor
7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Kate Lovett
ea67a65bde
Re-land Luci Support for Gold (#52760) 2020-03-18 12:56:02 -07:00
Michael Goderbauer
1444e77205
Use stable IDs for TextSpan SemanticsNodes (#52769) 2020-03-18 09:56:02 -07:00
Justin McCandless
a811bce4b0
TextField behavior when at maxLength (#52130)
TextFields now disallow adding characters in the center of the text at maxLength.
2020-03-18 08:02:22 -07:00
Jonah Williams
6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
Ferhat
d3a66e3107
[web] Add support for ChunkEvents during image loading (#52558)
* Add support for ChunkEvents for web
* Add lint skip for webOnly call in _network_image_web
2020-03-17 16:07:21 -07:00
Dan Field
08768e87e4
Revert repeater (#52752)
Reverts repeat filter logic for text formatter
2020-03-17 12:24:13 -07:00
Kate Lovett
48fc135003
Revert "Refactoring Gold to enable both Luci & Cirrus support (#49815)" (#52670)
This reverts commit 7edcc92b1027f0f82cde50e6843acf9175de083d.
2020-03-16 10:26:09 -07:00
Greg Spencer
acd51a726e
Make AnimatedSwitcher example into a dartpad example (#52547) 2020-03-16 09:02:08 -07:00
Kate Lovett
7edcc92b10
Refactoring Gold to enable both Luci & Cirrus support (#49815) 2020-03-13 20:11:01 -07:00
Michel Feinstein
34b7030c1e
Fixed a typo. (#52562) 2020-03-13 19:11:04 -07:00
Ayush Bherwani
60b9d15495
[RaisedButton] Added padding property to RaisedButton.icon (#52393) 2020-03-13 17:21:02 -07:00
Kate Lovett
aa622fbb26
Switching to Gold Status Check (#51968) 2020-03-13 11:41:01 -07:00
JosepBove
6c0d2db57a
Correct broken curves asset links (#52501) 2020-03-13 11:10:40 -07:00
gaaclarke
f8e9a4fff2
Added option to specify you want the keyboard to be dismissed when you scroll. (#52068) 2020-03-13 09:44:24 -07:00
Tong Mu
c82c399eb7
[DataTable] Hide arrow padding when not sorting (#51667)
* Change onSort and add tests

* Add doc

* Regression test

* Remove if (true)

* Make test clearer

* Clearer comment
2020-03-12 18:20:15 -07:00
Tong Mu
b2d53f60e7
Tap gesture no longer add pointer after resetting (#52450)
* TapGestureRecognizer no longer adds the pointer after it resets.

* Adds an assertion to make sure TapGestureRecognizer.startTrackingPointer is never called when _down is null
2020-03-12 18:19:19 -07:00
Dan Field
73b2895ff1
Add errorBuilder to Image widget (#52481) 2020-03-12 16:21:01 -07:00
Wu Zhong
db6e2061aa
Fixes typo in comments (#52408) 2020-03-12 09:31:01 -07:00
Greg Spencer
7c9f95ac0a
Minor doc changes (#52433)
Just some very minor doc changes: an adjustment of my comments in #51495, and a typo fix.
2020-03-11 16:57:06 -07:00
Gary Qian
fed6ce17f8
Directionality formatter to move whitespace bidi handling into framework (#51964) 2020-03-11 16:25:12 -07:00
Gary Qian
d56266375b
Reland "Improve text formatter repeat filter logic (#52055)" (#52366) 2020-03-11 13:36:43 -07:00
Justin McCandless
4841a7ed6f
Text Selection Overflow (Android) (#49391)
Adds an overflow menu to the text selection menu on Android when the items overflow.
2020-03-11 13:36:10 -07:00
Greg Spencer
210f4d8313
Convert Diagnosticable to a mixin (#51495)
This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class.

It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
2020-03-11 10:03:05 -07:00
Greg Spencer
d19c44344b
Add sample for InheritedNotifier, convert two others to DartPa… (#52349)
This adds a sample for InheritedNotifier, and converts a couple of other samples to be DartPad samples. I also added a new sample template stateful_widget_material_ticker, which adds a TickerProviderStateMixin to the state object so that animation controllers can be created there easily.
2020-03-10 15:23:45 -07:00
Gary Qian
ac6ea52b37
Revert "Add missing features to DefaultTextStyleTransition and AnimatedDefaultTextStyle (#51517)" (#52352) 2020-03-10 14:11:03 -07:00
Michael Goderbauer
ade6a1b3c5
Fix a11y scrolling for reversed lists (#52332) 2020-03-10 13:04:22 -07:00
Francisco Magdaleno
e9905b6ad8
[Keyboard] Collects windows key data (#52265) 2020-03-09 17:21:02 -07:00
renyou
847280f72f
Revert "Improve text formatter repeat filter logic (#52055)" (#52274)
This reverts commit 91b0bcf1a8a192e8135a9289310d81deba5824ec.
2020-03-09 16:26:48 -07:00
Gary Qian
91b0bcf1a8
Improve text formatter repeat filter logic (#52055) 2020-03-09 13:05:07 -07:00
Per Classon
1546f41ec1
Add width constraints for FlexibleSpaceBar.title in its expanded state, so that overflow of long titles can be handled (#51335) 2020-03-09 12:06:01 -07:00
Chad Nehemiah
31df1d459e
made builder required (#51993) 2020-03-09 12:01:01 -07:00
Darren Austin
1c3ebad904
Fix for negative padding from a curve in AnimatedPadding. (#52072)
* Fix for negative padding from a curve in AnimatedPadding.

* Added a EdgeInsets.clamp function that would return an EdgeInsets instance instead of a _MixedEdgeInsets used by the base class. This was causing some tests to fail that didn't have a text direction.
2020-03-06 14:14:03 -08:00
Masayuki Ono
2294d75bfa
Fix englishLike2018 bodyText (#49756) 2020-03-06 07:28:38 -08:00
Per Classon
88852731a5
Validate text selection before updating it inside of EditableText (#51410) 2020-03-06 01:26:01 -08:00
Hans Muller
a68f96ae3f
Fixed a typo in a FAB build debugPrint message (#52034) 2020-03-05 16:08:44 -08:00
Alexandre Ardhuin
c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Flutter GitHub Bot
cccbf1f200
Custom onPressed behavior for CloseButton widget (#51925) 2020-03-04 20:36:02 -08:00
Flutter GitHub Bot
b0381df11f
Unlooping Golden File Tests (#51883) 2020-03-04 15:21:01 -08:00
Flutter GitHub Bot
d0c4357338
Keep render tree and element tree in sync when re-used elements move in a MultiChildRenderObjectElement's child list (#51674) 2020-03-04 11:46:03 -08:00
Ben Konyi
3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946)
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
2020-03-04 11:40:52 -08:00